From 092dd8db1293599a4b7f0ab33ea43e8082ec554f Mon Sep 17 00:00:00 2001
From: Martin Kosek <mkosek@redhat.com>
Date: Tue, 17 Jan 2012 11:19:00 +0100
Subject: Replace float with Decimal

Having float type as a base type for floating point parameters in
ipalib introduces several issues, e.g. problem with representation
or value comparison. Python language provides a Decimal type which
help overcome these issues.

This patch replaces a float type and Float parameter with a
decimal.Decimal type in Decimal parameter. A precision attribute
was added to Decimal parameter that can be used to limit a number
of decimal places in parameter representation. This approach fixes
a problem with API.txt validation where comparison of float values
may fail on different architectures due to float representation error.

In order to safely transfer the parameter value over RPC it is
being converted to string which is then converted back to
decimal.Decimal number on a server side.

https://fedorahosted.org/freeipa/ticket/2260
---
 ipalib/plugins/dns.py | 51 +++++++++++++++++++++++++++++++--------------------
 1 file changed, 31 insertions(+), 20 deletions(-)

(limited to 'ipalib/plugins')

diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py
index 8042c3a1..abb2e90b 100644
--- a/ipalib/plugins/dns.py
+++ b/ipalib/plugins/dns.py
@@ -25,7 +25,7 @@ import re
 from ipalib.request import context
 from ipalib import api, errors, output
 from ipalib import Command
-from ipalib.parameters import Flag, Bool, Int, Float, Str, StrEnum, Any
+from ipalib.parameters import Flag, Bool, Int, Decimal, Str, StrEnum, Any
 from ipalib.plugins.baseldap import *
 from ipalib import _, ngettext
 from ipalib.util import validate_zonemgr, normalize_zonemgr, validate_hostname
@@ -345,7 +345,12 @@ class DNSRecord(Str):
             if not values:
                 return value
 
-            new_values = [ part.normalize(values[part_id]) \
+            converted_values = [ part._convert_scalar(values[part_id]) \
+                                 if values[part_id] is not None else None
+                                 for part_id, part in enumerate(self.parts)
+                               ]
+
+            new_values = [ part.normalize(converted_values[part_id]) \
                             for part_id, part in enumerate(self.parts) ]
 
             value = self._convert_scalar(new_values)
@@ -626,10 +631,11 @@ class LOCRecord(DNSRecord):
             minvalue=0,
             maxvalue=59,
         ),
-        Float('lat_sec?',
+        Decimal('lat_sec?',
             label=_('Seconds Latitude'),
-            minvalue=0.0,
-            maxvalue=59.999,
+            minvalue='0.0',
+            maxvalue='59.999',
+            precision=3,
         ),
         StrEnum('lat_dir',
             label=_('Direction Latitude'),
@@ -645,34 +651,39 @@ class LOCRecord(DNSRecord):
             minvalue=0,
             maxvalue=59,
         ),
-        Float('lon_sec?',
+        Decimal('lon_sec?',
             label=_('Seconds Longtitude'),
-            minvalue=0.0,
-            maxvalue=59.999,
+            minvalue='0.0',
+            maxvalue='59.999',
+            precision=3,
         ),
         StrEnum('lon_dir',
             label=_('Direction Longtitude'),
             values=(u'E', u'W',),
         ),
-        Float('altitude',
+        Decimal('altitude',
             label=_('Altitude'),
-            minvalue=-100000.00,
-            maxvalue=42849672.95,
+            minvalue='-100000.00',
+            maxvalue='42849672.95',
+            precision=2,
         ),
-        Float('size?',
+        Decimal('size?',
             label=_('Size'),
-            minvalue=0.0,
-            maxvalue=90000000.00,
+            minvalue='0.0',
+            maxvalue='90000000.00',
+            precision=2,
         ),
-        Float('h_precision?',
+        Decimal('h_precision?',
             label=_('Horizontal Precision'),
-            minvalue=0.0,
-            maxvalue=90000000.00,
+            minvalue='0.0',
+            maxvalue='90000000.00',
+            precision=2,
         ),
-        Float('v_precision?',
+        Decimal('v_precision?',
             label=_('Vertical Precision'),
-            minvalue=0.0,
-            maxvalue=90000000.00,
+            minvalue='0.0',
+            maxvalue='90000000.00',
+            precision=2,
         ),
     )
 
-- 
cgit