From 84b2fbe7baeec683b4a523b1f1dad1dff3f07939 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Wed, 23 Nov 2011 16:52:40 -0500 Subject: Add plugin framework to LDAP updates. There are two reasons for the plugin framework: 1. To provide a way of doing manual/complex LDAP changes without having to keep extending ldapupdate.py (like we did with managed entries). 2. Allows for better control of restarts. There are two types of plugins, preop and postop. A preop plugin runs before any file-based updates are loaded. A postop plugin runs after all file-based updates are applied. A preop plugin may update LDAP directly or craft update entries to be applied with the file-based updates. Either a preop or postop plugin may attempt to restart the dirsrv instance. The instance is only restartable if ipa-ldap-updater is being executed as root. A warning is printed if a restart is requested for a non-root user. Plugins are not executed by default. This is so we can use ldapupdate to apply simple updates in commands like ipa-nis-manage. https://fedorahosted.org/freeipa/ticket/1789 https://fedorahosted.org/freeipa/ticket/1790 https://fedorahosted.org/freeipa/ticket/2032 --- ipalib/plugable.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) (limited to 'ipalib/plugable.py') diff --git a/ipalib/plugable.py b/ipalib/plugable.py index d8b07c1e..2da361e5 100644 --- a/ipalib/plugable.py +++ b/ipalib/plugable.py @@ -594,16 +594,29 @@ class API(DictProxy): self.import_plugins('ipalib') if self.env.in_server: self.import_plugins('ipaserver') + if self.env.context in ('installer', 'updates'): + self.import_plugins('ipaserver/install/plugins') # FIXME: This method has no unit test def import_plugins(self, package): """ Import modules in ``plugins`` sub-package of ``package``. """ + package = package.replace(os.path.sep, '.') subpackage = '%s.plugins' % package try: parent = __import__(package) - plugins = __import__(subpackage).plugins + parts = package.split('.')[1:] + if parts: + for part in parts: + if part == 'plugins': + plugins = subpackage.plugins + subpackage = plugins.__name__ + break + subpackage = parent.__getattribute__(part) + parent = subpackage + else: + plugins = __import__(subpackage).plugins except ImportError, e: self.log.error( 'cannot import plugins sub-package %s: %s', subpackage, e -- cgit