From b01ea25988f32a1ec3b5dae36231a1ae7c1aecdc Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Tue, 22 Jan 2008 11:57:59 +0000 Subject: Small refactor of dsinstance.config_dirname() If, in future, we change the server ID so that it's not derived from the realm name, there's a fair few places that need to be changed. Make that easier by having config_dirname() take the server ID rather than the realm name. That makes sense anyway so we don't have to realm_to_serverid() so much. Signed-off-by: Mark McLoughlin --- ipa-server/ipaserver/dsinstance.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'ipa-server/ipaserver/dsinstance.py') diff --git a/ipa-server/ipaserver/dsinstance.py b/ipa-server/ipaserver/dsinstance.py index 04100338..d9aa1076 100644 --- a/ipa-server/ipaserver/dsinstance.py +++ b/ipa-server/ipaserver/dsinstance.py @@ -48,11 +48,11 @@ def find_server_root(): def realm_to_serverid(realm_name): return "-".join(realm_name.split(".")) -def config_dirname(realm_name): - return "/etc/dirsrv/slapd-" + realm_to_serverid(realm_name) + "/" +def config_dirname(serverid): + return "/etc/dirsrv/slapd-" + serverid + "/" -def schema_dirname(realm_name): - return config_dirname(realm_name) + "/schema/" +def schema_dirname(serverid): + return config_dirname(serverid) + "/schema/" def erase_ds_instance_data(serverid): try: @@ -198,13 +198,13 @@ class DsInstance(service.Service): def __add_default_schemas(self): shutil.copyfile(ipautil.SHARE_DIR + "60kerberos.ldif", - schema_dirname(self.realm_name) + "60kerberos.ldif") + schema_dirname(self.serverid) + "60kerberos.ldif") shutil.copyfile(ipautil.SHARE_DIR + "60samba.ldif", - schema_dirname(self.realm_name) + "60samba.ldif") + schema_dirname(self.serverid) + "60samba.ldif") shutil.copyfile(ipautil.SHARE_DIR + "60radius.ldif", - schema_dirname(self.realm_name) + "60radius.ldif") + schema_dirname(self.serverid) + "60radius.ldif") shutil.copyfile(ipautil.SHARE_DIR + "60ipaconfig.ldif", - schema_dirname(self.realm_name) + "60ipaconfig.ldif") + schema_dirname(self.serverid) + "60ipaconfig.ldif") def __restart_instance(self): try: @@ -252,7 +252,7 @@ class DsInstance(service.Service): self.__ldap_mod("master-entry.ldif", self.sub_dict) def __enable_ssl(self): - dirname = config_dirname(self.realm_name) + dirname = config_dirname(self.serverid) ca = certs.CertDB(dirname) if self.pkcs12_info: ca.create_from_pkcs12(self.pkcs12_info[0], self.pkcs12_info[1]) @@ -296,11 +296,11 @@ class DsInstance(service.Service): def __certmap_conf(self): shutil.copyfile(ipautil.SHARE_DIR + "certmap.conf.template", - config_dirname(self.realm_name) + "certmap.conf") + config_dirname(self.serverid) + "certmap.conf") def change_admin_password(self, password): logging.debug("Changing admin password") - dirname = config_dirname(self.realm_name) + dirname = config_dirname(self.serverid) if ipautil.dir_exists("/usr/lib64/mozldap"): app = "/usr/lib64/mozldap/ldappasswd" else: -- cgit