From 1ffbec9942ad90e00e28b05296d3233f52ce2dad Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 5 Dec 2011 13:39:30 +0100 Subject: Removed usage of bitwise assignment operators in logical operations JavaScript &= and |= are bitwise operators. They are shortened version of: foo = foo & bar foo = foo | bar In some places they were used as shortened version of logical operation and assignment. foo = foo && bar It lead to type conversion to Number which is wrong (0 !== false). This patch replaces such occurances with full version of logical operation and asignment. https://fedorahosted.org/freeipa/ticket/2040 --- install/ui/widget.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'install/ui/widget.js') diff --git a/install/ui/widget.js b/install/ui/widget.js index 79b03519..5b50d8f1 100644 --- a/install/ui/widget.js +++ b/install/ui/widget.js @@ -515,7 +515,7 @@ IPA.multivalued_text_widget = function(spec) { var dirty = false; for(var i=0; i < that.rows.length; i++) { - dirty |= that.test_dirty_row(that.rows[i]); + dirty = dirty || that.test_dirty_row(that.rows[i]); } return dirty; -- cgit