From 8d07054e1b2ff8680c225e7cd847eb885e7246a4 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Wed, 15 May 2013 17:33:21 +0200 Subject: Do not display success message on failure in web UI https://fedorahosted.org/freeipa/ticket/3591 --- install/ui/src/freeipa/sudo.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'install/ui/src/freeipa/sudo.js') diff --git a/install/ui/src/freeipa/sudo.js b/install/ui/src/freeipa/sudo.js index 638b2380..cb620e41 100644 --- a/install/ui/src/freeipa/sudo.js +++ b/install/ui/src/freeipa/sudo.js @@ -881,18 +881,22 @@ IPA.sudo.options_section = function(spec) { on_success: function(data) { //last successful result of batch results contains valid data var result; - for(var i = data.result.results.length - 1; i > -1; i--) { - result = data.result.results[i].result; - if(result) break; + var succeeded = 0; + + for (var i = data.result.results.length - 1; i > -1; i--) { + var error = data.result.results[i].error; + if (!result) result = data.result.results[i].result; + if (!error) succeeded++; } - if(result) { + if (result) { that.table.load(result); } else { that.reload(); } - IPA.notify_success('@i18n:objects.sudorule.option_removed'); + var msg = text.get('@i18n:objects.sudorule.option_removed').replace('${count}', succeeded); + IPA.notify_success(msg); }, on_error: function(data) { that.reload(); -- cgit