From 1ffbec9942ad90e00e28b05296d3233f52ce2dad Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 5 Dec 2011 13:39:30 +0100 Subject: Removed usage of bitwise assignment operators in logical operations JavaScript &= and |= are bitwise operators. They are shortened version of: foo = foo & bar foo = foo | bar In some places they were used as shortened version of logical operation and assignment. foo = foo && bar It lead to type conversion to Number which is wrong (0 !== false). This patch replaces such occurances with full version of logical operation and asignment. https://fedorahosted.org/freeipa/ticket/2040 --- install/ui/ipa.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'install/ui/ipa.js') diff --git a/install/ui/ipa.js b/install/ui/ipa.js index 08d8722c..8a7b29f7 100644 --- a/install/ui/ipa.js +++ b/install/ui/ipa.js @@ -725,8 +725,8 @@ IPA.concurrent_command = function(spec) { for(var i=0; i < that.commands.length; i++) { var command_info = that.commands[i]; - all_completed &= command_info.completed; - all_success &= command_info.success; + all_completed = all_completed && command_info.completed; + all_success = all_success && command_info.success; } if(all_completed) { -- cgit