From cf60e7e71e800bbbe5eb42039a375782af17c379 Mon Sep 17 00:00:00 2001 From: Petr Voborník Date: Thu, 23 Feb 2012 11:26:05 +0100 Subject: Fixed DNS record add handling of 4304 error Fixed hanling of 4304 error in DNS record add. Code which handled this error in host-add was generalized and moved to IPA. DNS record add both in adder dialog and dns record table are using this generalized version. https://fedorahosted.org/freeipa/ticket/2349 --- install/ui/host.js | 33 ++------------------------------- 1 file changed, 2 insertions(+), 31 deletions(-) (limited to 'install/ui/host.js') diff --git a/install/ui/host.js b/install/ui/host.js index f2b84529..6f9e3577 100644 --- a/install/ui/host.js +++ b/install/ui/host.js @@ -347,7 +347,7 @@ IPA.widget_factories['host_fqdn'] = IPA.host_fqdn_widget; IPA.host_adder_dialog = function(spec) { spec = spec || {}; - spec.retry = typeof spec.retry !== 'undefined' ? spec.retry : false; + spec.retry = spec.retry !== undefined ? spec.retry : false; var that = IPA.entity_adder_dialog(spec); @@ -356,36 +356,7 @@ IPA.host_adder_dialog = function(spec) { that.container.addClass('host-adder-dialog'); }; - that.on_error = function(xhr, text_status, error_thrown) { - var ajax = this; - var command = that.command; - var data = error_thrown.data; - var dialog = null; - - if(data && data.error && data.error.code === 4304) { - dialog = IPA.message_dialog({ - message: data.error.message, - title: spec.title, - on_ok: function() { - data.result = { - result: { - fqdn: command.args[0] - } - }; - command.on_success.call(ajax, data, text_status, xhr); - } - }); - } else { - dialog = IPA.error_dialog({ - xhr: xhr, - text_status: text_status, - error_thrown: error_thrown, - command: command - }); - } - - dialog.open(that.container); - }; + that.on_error = IPA.create_4304_error_handler(that); return that; }; -- cgit