From c94d20cfd8cc1bd8cd8152b19d6807b654286197 Mon Sep 17 00:00:00 2001 From: Martin Kosek Date: Fri, 14 Jan 2011 10:24:04 +0100 Subject: Unchecked return values in SLAPI plugins Return values weren't checked in several cases which could have lead to unhandled errors. https://fedorahosted.org/freeipa/ticket/722 --- daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c') diff --git a/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c b/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c index 1293c4c7..a61cabb1 100644 --- a/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c +++ b/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c @@ -702,8 +702,8 @@ internal_find_entry_get_attr_val(const Slapi_DN *basedn, int scope, if (entries && entries[0]) { /* found one */ if (svs) { Slapi_Attr *attr = NULL; - slapi_entry_attr_find(entries[0], attrname, &attr); - if (attr) { + if (!slapi_entry_attr_find(entries[0], attrname, &attr) && + (NULL != attr)) { /* slapi_attr_get_valueset allocates svs - must be freed later */ slapi_attr_get_valueset(attr, svs); } -- cgit