From d10c043e92b86e50ece5f80e6a987013d5de6fb1 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Fri, 22 Feb 2013 13:56:06 +0100 Subject: ipa-pwd: Unchecked return value ipapwd_chpwop() Fixes https://fedorahosted.org/freeipa/ticket/3427 --- daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c index 7fcf647f..974eda31 100644 --- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c +++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c @@ -247,7 +247,11 @@ parse_req_done: slapi_sdn_free(&sdn); if (be) { chpwop_pb = slapi_pblock_new(); - slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be); + if (slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be)) { + LOG_FATAL("slapi_pblock_set failed!\n"); + rc = LDAP_OPERATIONS_ERROR; + goto free_and_return; + } rc = slapi_back_transaction_begin(chpwop_pb); if (rc) { LOG_FATAL("failed to start transaction\n"); -- cgit