summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Kosek <mkosek@redhat.com>2013-01-18 17:33:19 +0100
committerMartin Kosek <mkosek@redhat.com>2013-02-14 08:39:34 +0100
commit7a01ecb6adb6ed56462df32b7bc56952b25667c6 (patch)
tree8dc7aefa79bc3910183b3008440f6f1b8d7e1864
parent406d92950d1afb1213c3677cc4138ca4e8b4aff5 (diff)
downloadfreeipa.git-7a01ecb6adb6ed56462df32b7bc56952b25667c6.tar.gz
freeipa.git-7a01ecb6adb6ed56462df32b7bc56952b25667c6.tar.xz
freeipa.git-7a01ecb6adb6ed56462df32b7bc56952b25667c6.zip
Do not hide SID resolver error in group-add-member
When group-add-member does not receive any resolved trusted domain object SID, it raises an exception which hides any useful error message passed by underlying resolution methods. Remove the exception to reveal this error messages to user. https://fedorahosted.org/freeipa/ticket/2997
-rw-r--r--ipalib/plugins/group.py3
1 files changed, 0 insertions, 3 deletions
diff --git a/ipalib/plugins/group.py b/ipalib/plugins/group.py
index 347a7ee9..19404c6f 100644
--- a/ipalib/plugins/group.py
+++ b/ipalib/plugins/group.py
@@ -390,9 +390,6 @@ class group_add_member(LDAPAddMember):
failed_sids.append((sid, unicode(e)))
else:
sids.append(actual_sid)
- if len(sids) == 0:
- raise errors.ValidationError(name=_('external member'),
- error=_('values are not recognized as valid SIDs from trusted domain'))
restore = []
if 'member' in failed and 'group' in failed['member']:
restore = failed['member']['group']