summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2013-02-22 13:56:06 +0100
committerMartin Kosek <mkosek@redhat.com>2013-02-28 12:33:38 +0100
commitd8a9102b9cc5cf3093dd6498a76e58848ec0b9bd (patch)
tree8b9bc1b37b678e33d2300f7bf5798fd1fd1ac48c
parente96e29cdd2e275d026f684737041f576fda5238b (diff)
downloadfreeipa.git-d8a9102b9cc5cf3093dd6498a76e58848ec0b9bd.tar.gz
freeipa.git-d8a9102b9cc5cf3093dd6498a76e58848ec0b9bd.tar.xz
freeipa.git-d8a9102b9cc5cf3093dd6498a76e58848ec0b9bd.zip
ipa-pwd: Unchecked return value ipapwd_chpwop()
Fixes https://fedorahosted.org/freeipa/ticket/3427
-rw-r--r--daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
index 7fcf647f..974eda31 100644
--- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
+++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
@@ -247,7 +247,11 @@ parse_req_done:
slapi_sdn_free(&sdn);
if (be) {
chpwop_pb = slapi_pblock_new();
- slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be);
+ if (slapi_pblock_set(chpwop_pb, SLAPI_BACKEND, be)) {
+ LOG_FATAL("slapi_pblock_set failed!\n");
+ rc = LDAP_OPERATIONS_ERROR;
+ goto free_and_return;
+ }
rc = slapi_back_transaction_begin(chpwop_pb);
if (rc) {
LOG_FATAL("failed to start transaction\n");