summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2013-02-27 12:12:45 +0100
committerMartin Kosek <mkosek@redhat.com>2013-02-28 12:28:01 +0100
commit0f32755c97a54024c080ab9dbbcbc9deda580f26 (patch)
treea442ea8dbb04eb22ccbddddc323c2564ea58db7a
parent6d1fd7a84412debe07bf8006ab42566d662e93b1 (diff)
downloadfreeipa.git-0f32755c97a54024c080ab9dbbcbc9deda580f26.tar.gz
freeipa.git-0f32755c97a54024c080ab9dbbcbc9deda580f26.tar.xz
freeipa.git-0f32755c97a54024c080ab9dbbcbc9deda580f26.zip
ipa-sam: Array compared against 0 in ipasam_set_trusted_domain()
ipa_mspac_well_known_sids is a globally defined array so the check was always true. Fixes https://fedorahosted.org/freeipa/ticket/3423
-rw-r--r--daemons/ipa-sam/ipa_sam.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/daemons/ipa-sam/ipa_sam.c b/daemons/ipa-sam/ipa_sam.c
index 0d4a27cf..b9fc00c8 100644
--- a/daemons/ipa-sam/ipa_sam.c
+++ b/daemons/ipa-sam/ipa_sam.c
@@ -2293,7 +2293,7 @@ static NTSTATUS ipasam_set_trusted_domain(struct pdb_methods *methods,
&td->trust_forest_trust_info);
}
- for (i = 0; ipa_mspac_well_known_sids && ipa_mspac_well_known_sids[i]; i++) {
+ for (i = 0; ipa_mspac_well_known_sids[i]; i++) {
smbldap_make_mod(priv2ld(ldap_state), entry, &mods,
LDAP_ATTRIBUTE_SID_BLACKLIST_INCOMING,
ipa_mspac_well_known_sids[i]);