From cbb12c7cc56ba8d9ee48d261fc86ddef5e323c34 Mon Sep 17 00:00:00 2001 From: Martin Kosek Date: Wed, 2 Jan 2013 10:43:49 +0100 Subject: Do not crash when Kerberos SRV record is not found ipa-client-install crashed when IPA server realm TXT record was configured, but the referred domain (lower-case realm value) did not contain any Kerberos SRV record (_kerberos._udp..) https://fedorahosted.org/freeipa/ticket/3316 --- ipa-client/ipaclient/ipadiscovery.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'ipa-client/ipaclient') diff --git a/ipa-client/ipaclient/ipadiscovery.py b/ipa-client/ipaclient/ipadiscovery.py index 63acf6200..2214a81ba 100644 --- a/ipa-client/ipaclient/ipadiscovery.py +++ b/ipa-client/ipaclient/ipadiscovery.py @@ -436,9 +436,10 @@ class IPADiscovery(object): kdc = self.ipadns_search_srv(domain, '_kerberos._udp', 88, break_on_first=False) - if not kdc: + if kdc: + kdc = ','.join(kdc) + else: root_logger.debug("SRV record for KDC not found! Realm: %s, SRV record: %s" % (realm, qname)) kdc = None - kdc = ','.join(kdc) return realm, kdc -- cgit