summaryrefslogtreecommitdiffstats
path: root/ipaserver/plugins
Commit message (Collapse)AuthorAgeFilesLines
* Unify and simplify LDAP service discoveryChristian Heimes2018-11-212-81/+28
| | | | | | | | | Move LDAP service discovery and service definitions from ipaserver.install to ipaserver. Simplify and unify different implementations in favor of a single implementation. Signed-off-by: Christian Heimes <cheimes@redhat.com> Reviewed-By: Rob Crittenden <rcritten@redhat.com>
* radiusproxy: add permission for reading radius proxy serversFlorence Blanc-Renaud2018-11-131-0/+19
| | | | | | | | | | | | | | | | A non-admin user which has the "User Administrator" role cannot add a user with ipa user-add --radius=<proxy> because the call needs to read the radius proxy server entries. The fix adds a System permission for reading radius proxy server entries (all attributes except the ipatokenradiussecret). This permission is added to the already existing privileges "User Administrators" and "Stage User Administrators", so that the role "User Administrator" can call ipa [stage]user-add|mod --radius=<proxy> Fixes: https://pagure.io/freeipa/issue/7570 Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* ipa user-add: add optional objectclass for radius-usernameFlorence Blanc-Renaud2018-11-131-2/+16
| | | | | | | | | | | | | | | | | | The command "ipa user-add --radius-username" fails with ipa: ERROR: attribute "ipatokenRadiusUserName" not allowed because it does not add the objectclass ipatokenradiusproxyuser that is required by the attribute ipatokenradiususername. The issue happens with ipa user-add / stageuser-add / user-mod / stageuser-mod. The fix adds the objectclass when needed in the pre_common_callback method of baseuser_add and baseuser_mod (ensuring that user and stageuser commands are fixed). Fixes https://pagure.io/freeipa/issue/7569 Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* Copy-paste error in permssions plugin, CID 323649Christian Heimes2018-11-081-1/+1
| | | | | | | | | | | | | | | | Address a bug in the code block for attributeLevelRights for old clients. The backward compatibility code for deprecated options was not triggered, because the new name was checked against wrong dict. Coverity Scan issue 323649, Copy-paste error The copied code will not have its intended effect. In postprocess_result: A copied piece of code is inconsistent with the original (CWE-398) See: Fixes: https://pagure.io/freeipa/issue/7753 Signed-off-by: Christian Heimes <cheimes@redhat.com> Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
* Find orphan automember rulesThomas Woerner2018-10-101-0/+59
| | | | | | | | | | | | | | | | | | | | | | If groups or hostgroups have been removed after automember rules have been created using them, then automember-rebuild, automember-add, host-add and more commands could fail. A new command has been added to the ipa tool: ipa automember-find-orphans --type={hostgroup,group} [--remove] This command retuns the list of orphan automember rules in the same way as automember-find. With the --remove option the orphan rules are also removed. The IPA API version has been increased and a test case has been added. Using ideas from a patch by: Rob Crittenden <rcritten@redhat.com> See: https://pagure.io/freeipa/issue/6476 Signed-off-by: Thomas Woerner <twoerner@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com> Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
* Py3: Replace six.moves importsChristian Heimes2018-10-051-1/+1
| | | | | | | | | | | | Replace six.moves and six.StringIO/BytesIO imports with cannonical Python 3 packages. Note: six.moves.input behaves differently than builtin input function. Therefore I left six.moves.input for now. See: https://pagure.io/freeipa/issue/7715 Signed-off-by: Christian Heimes <cheimes@redhat.com> Reviewed-By: Fraser Tweedale <ftweedal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of Topology entityStanislav Levin2018-10-021-0/+3
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of Vaults entityStanislav Levin2018-10-021-0/+18
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of Certificates entityStanislav Levin2018-10-021-0/+22
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of SELinux User ↵Stanislav Levin2018-10-021-0/+12
| | | | | | | | | | | | Maps entity To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of Sudo entityStanislav Levin2018-10-021-0/+37
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of HBAC entityStanislav Levin2018-10-021-0/+19
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of Groups entityStanislav Levin2018-10-021-0/+12
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'association_table' widget of Hosts entityStanislav Levin2018-10-021-2/+24
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details table of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'RBAC' entityStanislav Levin2018-10-021-0/+27
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'OTP Tokens' entityStanislav Levin2018-10-021-0/+3
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'Sudo' entityStanislav Levin2018-10-021-0/+8
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'HBAC' entityStanislav Levin2018-10-021-0/+8
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'ID Views' entityStanislav Levin2018-10-021-4/+9
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'Groups' entityStanislav Levin2018-10-021-0/+48
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'Services' entityStanislav Levin2018-10-021-0/+9
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'Hosts' entityStanislav Levin2018-10-021-0/+21
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'Users' entityStanislav Levin2018-10-021-0/+15
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for details of 'Certificate' entityStanislav Levin2018-10-021-7/+7
| | | | | | | | | | To improve translation quality the title of 'Add' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Drop concatenated title of 'Add' dialog for details of entityStanislav Levin2018-10-021-9/+1
| | | | | | | | | | | | | | | | | | | | As for now the 'Add' dialog title, which is initialized within details of the entity, contains translated concatenated texts, like: 'Add ${other_entity} into ${entity} ${primary_key}', where 'other_entity' and 'entity' are also translatable texts. This construction is used via method 'show_add_dialog' of association_facet for the all 'Add' actions within details of entities. The concatenation leads to a bad quality translation and should be changed to an entire sentence. From now a mentioned title is taken from a spec and should be specified explicitly. Fixes: https://pagure.io/freeipa/issue/7712 Fixes: https://pagure.io/freeipa/issue/7714 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Topology' entityStanislav Levin2018-10-011-0/+2
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Trusts' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'ID Ranges' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'RBAC' entityStanislav Levin2018-10-011-0/+5
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Vault' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'DNS' entityStanislav Levin2018-10-011-2/+5
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Automount' entityStanislav Levin2018-10-011-0/+3
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Certificate Identity' entityStanislav Levin2018-10-011-2/+3
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'RADIUS' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Certificates' entityStanislav Levin2018-10-011-0/+2
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Password Policies' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'SELinux' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Sudo' entityStanislav Levin2018-10-011-0/+4
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'HBAC' entityStanislav Levin2018-10-011-0/+3
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Automember' entityStanislav Levin2018-10-011-2/+7
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'ID Views' entityStanislav Levin2018-10-011-0/+3
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Groups' entityStanislav Levin2018-10-011-0/+3
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Service' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Host' entityStanislav Levin2018-10-011-0/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'OTP' entityStanislav Levin2018-10-011-1/+1
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Add title to 'add' dialog for 'Users' entityStanislav Levin2018-10-011-0/+2
| | | | | | | | To improve translation quality the title of 'Add' dialog should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Drop concatenated title of 'add' dialogStanislav Levin2018-10-011-1/+1
| | | | | | | | | | | | | | | | As for now the default title of 'add' dialog is set to something like 'Add ${entity}', where 'entity' is also translatable text. Such construction is used via method 'adder_dialog' of Entity for the all 'Add' actions. This leads to a bad quality translation and should be changed to an entire sentence. From now a mentioned title is taken from a spec and should be specified explicitly. Fixes: https://pagure.io/freeipa/issue/7707 Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
* Py3: Replace six.text_type with strChristian Heimes2018-09-273-5/+5
| | | | | | | | On Python 3, six.text_type (singular) is an alias for str. See: https://pagure.io/freeipa/issue/7715 Signed-off-by: Christian Heimes <cheimes@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* Py3: Replace six.string_types with strChristian Heimes2018-09-275-7/+7
| | | | | | | | In Python 3, six.string_types is just an alias for str. See: https://pagure.io/freeipa/issue/7715 Signed-off-by: Christian Heimes <cheimes@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* Py3: Remove subclassing from objectChristian Heimes2018-09-271-1/+1
| | | | | | | | | Python 2 had old style and new style classes. Python 3 has only new style classes. There is no point to subclass from object any more. See: https://pagure.io/freeipa/issue/7715 Signed-off-by: Christian Heimes <cheimes@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>