diff options
| author | Jan Barta <55042barta@sstebrno.eu> | 2016-06-03 10:05:34 +0200 |
|---|---|---|
| committer | Martin Basti <mbasti@redhat.com> | 2016-09-22 16:52:57 +0200 |
| commit | 275e85d076607ce317b3aeca467167fac55bf396 (patch) | |
| tree | e19911efa0b3eb7d131dba979836b6ae610f829f /ipaserver/plugins | |
| parent | 36484e8672f5ee1fdc2bd57622e330ab8dbb7671 (diff) | |
| download | freeipa-275e85d076607ce317b3aeca467167fac55bf396.tar.gz freeipa-275e85d076607ce317b3aeca467167fac55bf396.tar.xz freeipa-275e85d076607ce317b3aeca467167fac55bf396.zip | |
pylint: fix unneeded-not
Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Diffstat (limited to 'ipaserver/plugins')
| -rw-r--r-- | ipaserver/plugins/baseldap.py | 2 | ||||
| -rw-r--r-- | ipaserver/plugins/delegation.py | 2 | ||||
| -rw-r--r-- | ipaserver/plugins/group.py | 4 | ||||
| -rw-r--r-- | ipaserver/plugins/host.py | 2 | ||||
| -rw-r--r-- | ipaserver/plugins/selfservice.py | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/ipaserver/plugins/baseldap.py b/ipaserver/plugins/baseldap.py index f7844e3e7..1df8da455 100644 --- a/ipaserver/plugins/baseldap.py +++ b/ipaserver/plugins/baseldap.py @@ -909,7 +909,7 @@ last, after all sets and adds."""), newdict = {} if attrs is None: attrs = [] - elif not type(attrs) in (list, tuple): + elif type(attrs) not in (list, tuple): attrs = [attrs] for a in attrs: m = re.match("\s*(.*?)\s*=\s*(.*?)\s*$", a) diff --git a/ipaserver/plugins/delegation.py b/ipaserver/plugins/delegation.py index 6340d1aba..28a8f3019 100644 --- a/ipaserver/plugins/delegation.py +++ b/ipaserver/plugins/delegation.py @@ -132,7 +132,7 @@ class delegation_add(crud.Create): msg_summary = _('Added delegation "%(value)s"') def execute(self, aciname, **kw): - if not 'permissions' in kw: + if 'permissions' not in kw: kw['permissions'] = (u'write',) kw['aciprefix'] = ACI_PREFIX result = api.Command['aci_add'](aciname, **kw)['result'] diff --git a/ipaserver/plugins/group.py b/ipaserver/plugins/group.py index 6677634f3..115db9d16 100644 --- a/ipaserver/plugins/group.py +++ b/ipaserver/plugins/group.py @@ -314,7 +314,7 @@ class group_add(LDAPCreate): raise errors.MutuallyExclusiveError(reason=_('gid cannot be set for external group')) elif not options['nonposix']: entry_attrs['objectclass'].append('posixgroup') - if not 'gidnumber' in options: + if 'gidnumber' not in options: entry_attrs['gidnumber'] = baseldap.DNA_MAGIC return dn @@ -395,7 +395,7 @@ class group_mod(LDAPUpdate): else: old_entry_attrs['objectclass'].append('posixgroup') entry_attrs['objectclass'] = old_entry_attrs['objectclass'] - if not 'gidnumber' in options: + if 'gidnumber' not in options: entry_attrs['gidnumber'] = baseldap.DNA_MAGIC if options['external']: diff --git a/ipaserver/plugins/host.py b/ipaserver/plugins/host.py index 2362b6247..d3e3c2788 100644 --- a/ipaserver/plugins/host.py +++ b/ipaserver/plugins/host.py @@ -666,7 +666,7 @@ class host_add(LDAPCreate): options['ip_address'], check_forward=True, check_reverse=check_reverse) - if not options.get('force', False) and not 'ip_address' in options: + if not options.get('force', False) and 'ip_address' not in options: util.verify_host_resolvable(keys[-1]) if 'locality' in entry_attrs: entry_attrs['l'] = entry_attrs['locality'] diff --git a/ipaserver/plugins/selfservice.py b/ipaserver/plugins/selfservice.py index 9697493b9..9009b7a64 100644 --- a/ipaserver/plugins/selfservice.py +++ b/ipaserver/plugins/selfservice.py @@ -124,7 +124,7 @@ class selfservice_add(crud.Create): msg_summary = _('Added selfservice "%(value)s"') def execute(self, aciname, **kw): - if not 'permissions' in kw: + if 'permissions' not in kw: kw['permissions'] = (u'write',) kw['selfaci'] = True kw['aciprefix'] = ACI_PREFIX |