diff options
| author | Tomas Babej <tbabej@redhat.com> | 2014-09-24 14:23:25 +0200 |
|---|---|---|
| committer | Martin Kosek <mkosek@redhat.com> | 2014-09-30 10:42:06 +0200 |
| commit | dbf8d97ecf5d82c1e0e1a11cdf64dd670309c2a5 (patch) | |
| tree | 966f948aa32b32367f1267de395f3564bf0957d1 | |
| parent | 13089eae527ae87cad69148be3d60077511dc517 (diff) | |
| download | freeipa-dbf8d97ecf5d82c1e0e1a11cdf64dd670309c2a5.tar.gz freeipa-dbf8d97ecf5d82c1e0e1a11cdf64dd670309c2a5.tar.xz freeipa-dbf8d97ecf5d82c1e0e1a11cdf64dd670309c2a5.zip | |
idviews: Make sure the dict.get method is not abused for MUST attributes
Part of: https://fedorahosted.org/freeipa/ticket/3979
Reviewed-By: Petr Viktorin <pviktori@redhat.com>
Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
| -rw-r--r-- | ipalib/plugins/idviews.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ipalib/plugins/idviews.py b/ipalib/plugins/idviews.py index d6263307d..ad1193f69 100644 --- a/ipalib/plugins/idviews.py +++ b/ipalib/plugins/idviews.py @@ -409,7 +409,7 @@ def resolve_object_to_anchor(ldap, obj_type, obj): # The domain prefix, this will need to be reworked once we # introduce IPA-IPA trusts domain = api.env.domain - uuid = entry.single_value.get('ipaUniqueID') + uuid = entry.single_value['ipaUniqueID'] return "%s%s:%s" % (IPA_ANCHOR_PREFIX, domain, uuid) except errors.NotFound: @@ -463,7 +463,7 @@ def resolve_anchor_to_object_name(ldap, obj_type, anchor): # Return the name of the object, which is either cn for # groups or uid for users - return entry.single_value.get(name_attr) + return entry.single_value[name_attr] elif anchor.startswith(SID_ANCHOR_PREFIX): @@ -527,7 +527,7 @@ class baseidoverride(LDAPObject): def convert_anchor_to_human_readable_form(self, entry_attrs, **options): if not options.get('raw'): - anchor = entry_attrs.single_value.get('ipaanchoruuid') + anchor = entry_attrs.single_value['ipaanchoruuid'] if anchor: object_name = resolve_anchor_to_object_name( @@ -659,7 +659,7 @@ class idoverrideuser(baseidoverride): override_object = 'user' def update_original_uid_reference(self, entry_attrs): - anchor = entry_attrs.single_value.get('ipaanchoruuid') + anchor = entry_attrs.single_value['ipaanchoruuid'] original_uid = resolve_anchor_to_object_name(self.backend, self.override_object, anchor) |