From 69a7e3cfdc8dbba9c8dcfdfae82d2894c7247e15 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Mon, 22 Sep 2014 16:08:26 -0700 Subject: s4: libcli: ldap message - Ensure all asn1_XX returns are checked. Signed-off-by: Jeremy Allison Reviewed-by: Ronnie Sahlberg Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Fri Sep 26 03:15:00 CEST 2014 on sn-devel-104 --- source4/libcli/ldap/ldap_controls.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'source4/libcli/ldap') diff --git a/source4/libcli/ldap/ldap_controls.c b/source4/libcli/ldap/ldap_controls.c index 1e67a0124a..f910acba38 100644 --- a/source4/libcli/ldap/ldap_controls.c +++ b/source4/libcli/ldap/ldap_controls.c @@ -1197,10 +1197,10 @@ static bool decode_openldap_dereference(void *mem_ctx, DATA_BLOB in, void *_out) if (!asn1_start_tag(data, ASN1_CONTEXT(0))) { return false; } - - ldap_decode_attribs_bare(r, data, &r[i]->attributes, - &r[i]->num_attributes); - + if (!ldap_decode_attribs_bare(r, data, &r[i]->attributes, + &r[i]->num_attributes)) { + return false; + } if (!asn1_end_tag(data)) { return false; } -- cgit