From ba370ae630e1f35cd20d6419100b5e0987382cfc Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 9 Nov 2013 18:40:08 +0100 Subject: registry: Fix Coverity ID 1034917 Wrong sizeof argument sizeof(data_val) is the size of the pointer. This might well be 8 bytes where the string is only 4 bytes long Signed-off-by: Volker Lendecke Reviewed-by: Ira Cooper --- source4/lib/registry/tests/registry.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'source4/lib/registry/tests/registry.c') diff --git a/source4/lib/registry/tests/registry.c b/source4/lib/registry/tests/registry.c index ddf402c948..0c3c395e65 100644 --- a/source4/lib/registry/tests/registry.c +++ b/source4/lib/registry/tests/registry.c @@ -449,14 +449,15 @@ static bool test_get_value(struct torture_context *tctx, void *_data) torture_assert_int_equal(tctx, REG_DWORD, type, "value type"); error = reg_val_set(subkey, "", REG_SZ, - data_blob_talloc(tctx, data_val, sizeof(data_val))); + data_blob_talloc(tctx, data_val, + strlen(data_val))); torture_assert_werr_ok(tctx, error, "set default value"); error = reg_key_get_value_by_name(tctx, subkey, "", &type, &data); torture_assert_werr_ok(tctx, error, "getting default value"); torture_assert_int_equal(tctx, REG_SZ, type, "value type ok"); - torture_assert_int_equal(tctx, sizeof(data_val), data.length, "value length ok"); + torture_assert_int_equal(tctx, strlen(data_val), data.length, "value length ok"); torture_assert_str_equal(tctx, data_val, (char *)data.data, "value ok"); return true; -- cgit