From d6486cf0d2bb206dd20b4e5ee2e17f1e770eeea7 Mon Sep 17 00:00:00 2001 From: Garming Sam Date: Thu, 8 May 2014 11:43:53 +1200 Subject: param: ensure CMD_LIST is freed when freeing a parameter As well as correctly deallocating the memory, this prevents a potential bug where s3 globals struct may be freed, but it can be referred to elsewhere. Change-Id: I92fc9baa26aee5b4a35b767bed901928cbb7c74f Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett Reviewed-by: Nadezhda Ivanova --- source3/param/loadparm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c index 6e64482ee3..c4dd803354 100644 --- a/source3/param/loadparm.c +++ b/source3/param/loadparm.c @@ -487,7 +487,7 @@ static void free_one_parameter_common(void *parm_ptr, (parm.type == P_USTRING)) { string_free((char**)parm_ptr); - } else if (parm.type == P_LIST) { + } else if (parm.type == P_LIST || parm.type == P_CMDLIST) { TALLOC_FREE(*((char***)parm_ptr)); } } -- cgit