From a48b533ea5c9faae3429b0fb680b52b14676cd22 Mon Sep 17 00:00:00 2001 From: Kamen Mazdrashki Date: Sun, 9 Nov 2014 04:28:47 +0100 Subject: lib-pyldb: Avoid SEGFAULT in case we can't convert passed value to py_String Signed-off-by: Kamen Mazdrashki Reviewed-by: Andrew Bartlett --- lib/ldb/pyldb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c index 78b801218f..c541b7249e 100644 --- a/lib/ldb/pyldb.c +++ b/lib/ldb/pyldb.c @@ -1629,6 +1629,11 @@ static PyObject *py_ldb_schema_format_value(PyLdbObject *self, PyObject *args) old_val.data = (uint8_t *)PyString_AsString(val); old_val.length = PyString_Size(val); + if (old_val.data == NULL) { + PyErr_SetString(PyExc_RuntimeError, "Failed to convert passed value to String"); + return NULL; + } + a = ldb_schema_attribute_by_name(pyldb_Ldb_AsLdbContext(self), element_name); if (a == NULL) { -- cgit