From 4dba8fd59982e5459c4275aaf434f6d564fcf79d Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Fri, 19 Sep 2014 12:41:22 -0700 Subject: auth: gensec: asn1 fixes - check all returns. Signed-off-by: Jeremy Allison Reviewed-by: Ronnie Sahlberg --- auth/gensec/gensec_util.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/auth/gensec/gensec_util.c b/auth/gensec/gensec_util.c index 568128add1..b8e38b7f7c 100644 --- a/auth/gensec/gensec_util.c +++ b/auth/gensec/gensec_util.c @@ -188,19 +188,20 @@ NTSTATUS gensec_packet_full_request(struct gensec_security *gensec_security, */ static bool gensec_gssapi_check_oid(const DATA_BLOB *blob, const char *oid) { - bool ret; + bool ret = false; struct asn1_data *data = asn1_init(NULL); if (!data) return false; - asn1_load(data, *blob); - asn1_start_tag(data, ASN1_APPLICATION(0)); - asn1_check_OID(data, oid); + if (!asn1_load(data, *blob)) goto err; + if (!asn1_start_tag(data, ASN1_APPLICATION(0))) goto err; + if (!asn1_check_OID(data, oid)) goto err; ret = !data->has_error; - asn1_free(data); + err: + asn1_free(data); return ret; } -- cgit