summaryrefslogtreecommitdiffstats
path: root/source4
Commit message (Collapse)AuthorAgeFilesLines
* samba_upgradeprovision: Do not reset every DN when changing an SDAndrew Bartlett2013-03-041-22/+8
| | | | | | | | | | | | | | | | | SD propogation is handled by an LDB module, we do not need to touch each and every DN to make it happen. Now that we do not need to put this via a hash, the dnToRecalculate list is changed to be a list of Dn objects, not strings so that: if dn in listWellknown is handled using a schema comparison (avoiding different case forms tripping it up). Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* samba_upgradeprovision: do not maintain dnNotToRecalculate as a listAndrew Bartlett2013-03-041-5/+3
| | | | | | | | We only need a boolean indication, not the actual values. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* samba_upgradeprovision: only run rebuild_sd in --full modeAndrew Bartlett2013-03-041-20/+17
| | | | | | | | This is a potentially destructive routine, and should not be run by default. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* samba_upgradeprovision: Remove alwaysRecalculate, this is too dangerousAndrew Bartlett2013-03-041-4/+1
| | | | | | | | | I am unclear on why this was added, but the idea that we ever always reset data in the directory is not reasonable to me, so I am removing it. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* samba_upgradeprovision: Remove unused checkKeepAttributeOldMtdAndrew Bartlett2013-03-041-73/+6
| | | | | | | | | lastProvisionUSNs is never None, instead the code requries the administrator to populate this attribute in the directory. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* scripting: Rework samba.upgradehelpers.get_diff_sddls to be get_diff_sdsAndrew Bartlett2013-03-041-11/+10
| | | | | | | | | This moves the SDDL conversion inside the get_diff_sds function and prepares for removing inherited ACEs from the SD before comparison. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* samba_upgradeprovision: Remove auto-detection of pre-alpha9 databasesAndrew Bartlett2013-03-041-5/+6
| | | | | | | | | These are incredibly rare, and administrators running such databases not only ask the Samba Team for help personally, they can read --help. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* selftest: Rename samba4.blackbox.upgradeprovision.py to ↵Andrew Bartlett2013-03-041-1/+1
| | | | | | | | | | samba4.blackbox.upgradeprovision.current This name matches the other upgradeprovision tests for older saved provisions. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* selftest: Add ldapcmp to ensure upgradeprovision of a fresh DB is a no-opAndrew Bartlett2013-03-041-1/+33
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* selftest: Add in a provision from 4.0.0 to run tests againstAndrew Bartlett2013-03-0421-0/+80210
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* Handle EMSGSIZE on UNIX domain sockets.Landon Fuller2013-03-021-9/+26
| | | | | | | | | | | | | | | | | | | | | | On some systems (eg, FreeBSD) the default SO_SNDBUF for UNIX domain sockets is to small, and EMSGSIZE is returned. Other systems provide a larger default send buffer, but there is still no guarantee that the buffer will be sized appropriately. This patch modifies the sendto() path to attempt to resize the SO_SNDBUF dynamically upon an EMSGSIZE failure, and then retry the send. This fixes local DCE/RPC errors on FreeBSD, eg: https://lists.samba.org/archive/samba-technical/2013-January/089881.html Signed-Off-By: Landon Fuller <landonf@bikemonkey.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Mar 2 23:34:03 CET 2013 on sn-devel-104
* Remove incomplete check for IPv6 link-local addresses.Landon Fuller2013-03-021-3/+1
| | | | | | | | | | | | | This has been superceded by a check for link-local addresses in get_interfaces() Signed-Off-By: Landon Fuller <landonf@bikemonkey.org> Reviewed-By: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Mar 2 08:38:54 CET 2013 on sn-devel-104
* Move python modules from source4/scripting/python/ to python/.Jelmer Vernooij2013-03-02118-31388/+5
| | | | | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Mar 2 03:57:34 CET 2013 on sn-devel-104
* build: Rename samba_python waf node to avoid duplicate nameAndrew Bartlett2013-03-021-1/+1
| | | | | | This makes it clearer when debuging build issues. Andrew Bartlett
* s4:lib/events: make use of samba_tevent_set_debug()Stefan Metzmacher2013-02-281-35/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4:pyregistry: make use of samba_tevent_context_init()Stefan Metzmacher2013-02-281-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4:pygensec: make use of samba_tevent_context_init()Stefan Metzmacher2013-02-281-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4:winbindd: fix spacing and line length in cmd_getpwnam_recv_domain()Michael Adam2013-02-281-1/+2
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Feb 28 03:54:41 CET 2013 on sn-devel-104
* s4:winbindd: do not drop the workgroup name in the getgrgid callMichael Adam2013-02-271-1/+11
| | | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Feb 27 05:44:39 CET 2013 on sn-devel-104
* s4:winbindd: do not drop the workgroup name in the getgrnam and getgrent calls.Michael Adam2013-02-271-1/+11
| | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4-lib: Don't leak plugin handle on error.Andreas Schneider2013-02-221-0/+1
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-policy: Fix memory leaks in push_recursive().Andreas Schneider2013-02-221-14/+26
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-cifsdd: Don't leak memory.Andreas Schneider2013-02-221-0/+6
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-registry: Don't leak file descriptor.Andreas Schneider2013-02-221-2/+1
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-registry: Don't leak memory on error.Andreas Schneider2013-02-221-0/+7
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-client: Don't leak memory.Andreas Schneider2013-02-221-0/+2
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* torture: Don't leak file resource handle in spoolss test.Andreas Schneider2013-02-221-0/+1
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-client: Don't leak file descriptor.Andreas Schneider2013-02-221-0/+7
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-client: Don't leak resource handle.Andreas Schneider2013-02-221-0/+2
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* torture: Make sure we don't overrun the buffer.Andreas Schneider2013-02-221-1/+1
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* torture: Fix memcmp of short buffer.Andreas Schneider2013-02-221-2/+2
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* torture: Fix array access in spoolss test.Andreas Schneider2013-02-221-2/+2
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-libcli: Check return value of smbcli_request_setup().Andreas Schneider2013-02-223-0/+15
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* pyauth: Check return value of lpcfg_from_py_object().Andreas Schneider2013-02-221-0/+4
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-libcli: Check return code of smbcli_request_setup().Andreas Schneider2013-02-221-0/+3
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* s4-libcli: Add null check for ndr functions in rap.Andreas Schneider2013-02-221-0/+8
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* torture: Fix samsync domain_name checks.Andreas Schneider2013-02-221-4/+45
| | | | Reviewed-by: Alexander Bokovoy <ab@samba.org>
* dsdb-descriptor: Avoid segfault copying an SD without an owner or groupAndrew Bartlett2013-02-221-4/+12
| | | | | | | | | | | This is an unusual SD, but it does exist is some very old upgraded databases. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Feb 22 11:06:17 CET 2013 on sn-devel-104
* dsdb-descriptor: Spell out security descriptor flags as constantsAndrew Bartlett2013-02-222-2/+2
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* torture-drs: Fix comment in replica_sync testAndrew Bartlett2013-02-221-1/+1
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* torture-drs: Make the samba4.drs.repl_schema.python emit failures, not ↵Andrew Bartlett2013-02-221-1/+5
| | | | | | | | | | errors on add failure This then allows this particular failure to be masked with a knownfail. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* ntdb: switch between secrets.tdb and secrets.ntdb depending on 'use ntdb'Rusty Russell2013-02-204-8/+18
| | | | | | | | | | | Since we open with dbwrap, it auto-converts old tdbs (which it will rename to secrets.tdb.bak once it's done). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date(master): Wed Feb 20 07:09:19 CET 2013 on sn-devel-104
* s4:lib/com: make use of samba_tevent_context_init()Stefan Metzmacher2013-02-191-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4:auth/kerberos: make use of samba_tevent_context_init()Stefan Metzmacher2013-02-191-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* samba_upgradeprovision: Use tdb_util.tdb_copy not shutil.copy2Andrew Bartlett2013-02-191-13/+17
| | | | | | | | | | | | | | | This is really important, because copying a file will both ignore locks held by another process and break any locks we hold (due to POSIX brain-damage regarding multiple fds on one file in a process). By leaving this to tdbbackup in a child, both of these issues are avoided. Andrew Bartlett Reviewed-by: Matthieu Patou <mat@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Feb 19 07:48:18 CET 2013 on sn-devel-104
* samba_upgradeprovision: Do not update privileges.ldb any more (unchanged ↵Andrew Bartlett2013-02-191-16/+4
| | | | | | | | | | | | since 2009) This update was only a total oblitoration of the existing database and not a merge, and the shutil.copy would both disregard and break locks on the database that are held at this point. Andrew Bartlett Reviewed-by: Matthieu Patou <mat@samba.org>
* scripting: Make tdb_copy a common util function in samba.tdb_utilAndrew Bartlett2013-02-193-20/+43
| | | | | | | | This will allow samba_upgradeprovision to also call it. Andrew Bartlett Reviewed-by: Matthieu Patou <mat@samba.org>
* scripting: Make tdb_copy use the python subprocess moduleAndrew Bartlett2013-02-191-7/+9
| | | | | | | | This makes the code more robust to spaces in the file names (etc). Andrew Bartlett Reviewed-by: Matthieu Patou <mat@samba.org>
* samba_upgradeprovision: Remove options to fix FS ACLsAndrew Bartlett2013-02-192-271/+205
| | | | | | | | | | | | samba-tool ntacl sysvolreset handles this better, and makes this tool much less confusing internally. Andrew Bartlett Reviewed-by: Matthieu Patou <mat@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Feb 19 06:06:41 CET 2013 on sn-devel-104
* s4:torture: fix segfault in test_durable_open_open2_oplock()Stefan Metzmacher2013-02-181-2/+4
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>