summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* profiling: Only compile profile/profile.c if profiling is enabledVolker Lendecke2014-10-033-19/+40
| | | | | | | | This conditional compile avoids some #ifdef WITH_PROFILE, which makes the code more readable Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Only compile utils/status_profile.c if profiling is enabledVolker Lendecke2014-10-033-24/+41
| | | | | | | | This conditional compile avoids some #ifdef WITH_PROFILE, which makes the code more readable Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Fix a typoVolker Lendecke2014-10-031-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Move some #defines to profile.cVolker Lendecke2014-10-032-4/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Fix a typoVolker Lendecke2014-10-031-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Make "struct profile_header" staticVolker Lendecke2014-10-032-8/+7
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbind3: Fix pwent variable substitutionJustin Maggard2014-10-031-1/+1
| | | | | | | | | Commit 0ce46318 (winbind3: Simplify fillup_pw_field) broke variable substitution by copying from the wrong (unsubstituted) buffer. Fix it. Signed-off-by: Justin Maggard <jmaggard10@gmail.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <rsharpe@samba.org>
* idmap_rfc2307: Remove unsed parameter and variableChristof Schmitt2014-10-011-8/+5
| | | | | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Christof Schmitt <cs@samba.org> Autobuild-Date(master): Wed Oct 1 19:20:50 CEST 2014 on sn-devel-104
* idmap_rfc2307: Fix a crash after connection problem to DCChristof Schmitt2014-10-011-0/+1
| | | | | | | | | | | | | | When the connection to the DC has a problem, the code behind ads_do_search_retry closes the current connection and opens a new one. The new connection has a new struct LDAP to represent the connection. In this case, the LDAP pointer in the idmap_rfc2307_context becomes invalid. Fix this problem by updating the local pointer after calling ads_do_search_retry. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* regedit: remove an old commentMichael Adam2014-10-011-2/+0
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Oct 1 16:55:05 CEST 2014 on sn-devel-104
* regedit: print error msg if opening registry failsChris Davis2014-10-011-0/+2
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: handle pgup/pgdn/home/end keys on listsChris Davis2014-10-013-4/+97
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: handle del and backspace in hexeditorChris Davis2014-10-013-11/+71
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: grow hexedit buffer as the user typesChris Davis2014-10-012-24/+46
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add a button to resize hexedit bufferChris Davis2014-10-012-2/+48
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add a number input boxChris Davis2014-10-012-12/+116
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: don't expand single line text field buffer with cursor movementChris Davis2014-10-011-1/+24
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: handle DEL key in text fieldsChris Davis2014-10-011-0/+3
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: adjust some variable names to make them more distinctChris Davis2014-10-011-19/+19
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: find previous itemsChris Davis2014-10-013-8/+62
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: search values and repeat search from cursor positionsChris Davis2014-10-016-83/+265
| | | | | | | | | | Recovering the search position from the cursors is safer than retaining a pointer to the last node, as the pointer will become invalid if the user deletes the item or refreshes the cache. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: flesh out search dialog and simplify search optsChris Davis2014-10-013-19/+87
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: don't use subwindows in hexeditChris Davis2014-10-013-38/+15
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: use pad as a canvas for dialogsChris Davis2014-10-012-23/+57
| | | | | | | | | | | Drawing in a pad allows the dialog to maintain the same size even when the terminal window is shrunk to some awkwardly small size. It also helps avoid hacks needed to update positions of subwindows when the panel is moved. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: clear value list after creating new keyChris Davis2014-10-011-0/+1
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: use the right function to reopen a hiveChris Davis2014-10-013-9/+26
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: move cursor to edited value in list and report edit errorsChris Davis2014-10-015-23/+77
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Introduce a new API to build the dialogs.Chris Davis2014-10-012-854/+1800
| | | | | | | | | | | | | | | This helps make new dialogs easier to create, because it provides some common building blocks and a consistent way to deal with user input. Dialogs are divided into sections that stack vertically, and common sections for typical UI things like text boxes, option lists, and buttons are provided. The old dialogs are rewritten to use this API. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: improvements for hexeditChris Davis2014-10-012-38/+74
| | | | | | | | | This mainly enables setting the hexedit buffer after the editor is allocated. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add padding to fit REG_MULTI_SZ to the text fieldChris Davis2014-10-011-8/+21
| | | | | | | | | This fixes a bug loading REG_MULTI_SZ values into the editor dialog, since ncurses fields don't handle newline characters. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: simplify cleanup after loading childrenChris Davis2014-10-011-8/+3
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add a panic handler to restore terminalChris Davis2014-10-011-0/+8
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: make all hives descend from a root nodeChris Davis2014-10-013-77/+79
| | | | | | | | | | | | | This helps simplify cleanup, since each node's talloc context is the parent node, and freeing the root node will destroy the entire tree without any extra utility functions. It also wouldn't be hard to extend this later on to support browsing multiple registries at the same time. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add a refresh command to clear cache and reload current pathChris Davis2014-10-013-15/+104
| | | | | | | This is needed to view changes made externally Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org>
* regedit: reopen key after editing or removing valuesChris Davis2014-10-011-0/+3
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: reopen parent keys when adding or removing subkeysChris Davis2014-10-013-0/+15
| | | | | | | | | This clears any cache associated with the parent key, and ensures the changes will be noticed by the UI. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: set cursor after creating a new keyChris Davis2014-10-011-0/+4
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: set cursor to the parent node when ascendingChris Davis2014-10-011-2/+3
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: don't fail loading keys if just a few are unavailableChris Davis2014-10-011-12/+15
| | | | | | | | | Sometimes a key might fail to open due to access restrictions. Only report failure if all keys failed to be opened. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: include error description in popupsChris Davis2014-10-011-3/+6
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: notify user if there's a failure loading subkeysChris Davis2014-10-011-4/+11
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: handle awkward window sizes betterChris Davis2014-10-013-12/+25
| | | | | | | | | | This fixes some assertion failures and an infinte loop that occurs when the terminal window is shrunk down far enough to the point regedit can't fit everything on screen. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: use talloc typesafety featuresChris Davis2014-10-012-18/+33
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: restore list cursor when window is resizedChris Davis2014-10-011-18/+25
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: make value list display data in multiple columnsChris Davis2014-10-014-128/+171
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add multicolumn list widgetChris Davis2014-10-017-131/+703
| | | | | | | | | | | | | Widget works for lists with one or more column(s). Column headers are optional. As a test, the patch also modifies regedit to use the new widget for viewing registry keys. Valuelist still needs to be upgraded to use this. Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add search feature.Chris Davis2014-10-016-39/+280
| | | | | | | | | | | | | | | | | | Open up a search input with '/'. 'x' key gets the next result. This patch also ensures that keys are always sorted, so that the search order matches the order the keys appear on screen. TODO: + flesh out search interface + find previous + search values Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: add a color scheme for path and context help sectionsChris Davis2014-10-011-3/+11
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: sort keysChris Davis2014-10-011-0/+12
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: free value list subwindowChris Davis2014-10-011-0/+3
| | | | | | Signed-off-by: Chris Davis <cd.rattan@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>