summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* Re-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"Jeremy Allison2010-01-081-0/+3
| | | | | | | | | | | | | | | This bug re-occurred for 3.3.x and above. The reason is that to change a NT ACL we now have to open the file requesting WRITE_DAC and WRITE_OWNER access. The mapping from POSIX "w" to NT permissions in posix_acls doesn't add these bits when "dos filemode = yes", so even though the permission or owner change would be allowed by the POSIX ACL code, the NTCreateX call fails with ACCESS_DENIED now we always check NT permissions first. Added in the mapping from "w" to WRITE_DAC and WRITE_OWNER access. Jeremy.
* s3-time: fix build warnings after we moved to shared time functions.Günther Deschner2010-01-081-6/+6
| | | | | | Bjoern, please check. Guenther
* s3 torture: Prevent smbcli segfault when running smbtorture3 against an smbd ↵Tim Prouty2010-01-071-0/+5
| | | | with security=share
* s3:auth: don't update the bad pw count if pw is among last 2 history entriesMichael Adam2010-01-071-1/+73
| | | | | | | | | This conforms to the behaviour of Windows 2003: http://www.microsoft.com/technet/prodtechnol/windowsserver2003/technologies/security/bpactlck.mspx This is supposed to fixes Bug #4347 . Michael
* s3:auth:check_sam_security: introduce a bool var to control pad_pw_count ↵Michael Adam2010-01-071-1/+7
| | | | | | | | incrementation This is a preparatory patch for the last part in fixing bug #4347 . Michael
* s3:passdb: store the plain nt passwords hashes in history, not salted md5Michael Adam2010-01-071-5/+10
| | | | | | | | | | | | | | This is in order to be able to do challenge response with the history, so that this can be checked when an invalid password was entered: If the given password is wrong but in the history, then the bad password count should not be updated... The "lucky" bit here is that the md5 has and the nt hash (md4) both are 16 bytes long. This is part of the fix for bug #4347 . Michael
* s3:smbd:password_in_history: treat entry with 0 salt as 0 + plain nt hashMichael Adam2010-01-071-6/+24
| | | | | | | | | | | | | This is to introduce a new format of the password history, maintaining backwards compatibility: The old format was 16 byte hash + 16 byte md5(salt + nt hash). The new format is 16 zero bytes and 16 bytes nt hash. This will allow us to respect the last X entries of the nt password history when deciding whether to increment the bad password count. This is part of the fix for bug #4347 . Michael
* s3: Remove some code that has become unnecessaryVolker Lendecke2010-01-071-8/+0
| | | | | | | | | | | | | | | | | | | The code I just removed was checked in with e5466fffc286a99f as a bug fix for https://bugzilla.samba.org/show_bug.cgi?id=3319. With the changes to is_visible_file made with 9e8b8f8c16612 these lines have become unnecessary, even with "hide unreadable = yes" dead msdfs symlinks show. This is because we can not stat(2) them and default to showing them. Why this change? I have a user who wants to use "hide unreadable" on msdfs links. Because you can't edit acls on symlinks themselves, the user created the targets as bogus, empty files that just exist as acl placeholders. With the code in place that this patch removes, we never allow this to work. Jeremy, please check! :-) Thanks, Volker
* s3: Lock down some srvsvc calls according to what w2k3 seems to doVolker Lendecke2010-01-071-0/+21
|
* s3:auth:check_sam_security: improve calling and logging of ↵Michael Adam2010-01-071-4/+16
| | | | | | | | | pdb_update_sam_account Log what went wrongl, and also call pdb_update_sam_account inside become_root/unbecome_root: do the logging outside. Michael
* s3:auth:check_sam_security: fix a leading tab/ws mixupMichael Adam2010-01-071-1/+1
| | | | Michael
* s3:auth:check_sam_security: create (and use) a common exit pointMichael Adam2010-01-071-11/+7
| | | | | | for use after sam_password_ok() has been called. Michael
* s3:auth:check_sam_security: null out sampass after it has been stolen.Michael Adam2010-01-071-0/+1
| | | | | | | | So that a later talloc_free would not harm. I could have used talloc_move instead of talloc steal in make_server_info_sam(), but this would have required a change of the signature. Michael
* s3:auth:sam_password_ok: take username, acct_ctrl and nt/lm hashes, not sampassMichael Adam2010-01-071-14/+20
| | | | | | | | This is in preparation to extending check_sam_security to also check against the password history before updating the bad password count. This way, sam_password_ok can more easily be reused for that purpose. Michael
* s3:auth: use data_blob_null instead of data_blob(NULL, 0) in sam_password_ok()Michael Adam2010-01-071-2/+2
| | | | | | | This way it is more explicit that there is no allocated data here that may leak. Michael
* s3:auth:sam_password_ok: fix allocation of a data blob.Michael Adam2010-01-071-1/+1
| | | | | | | | | | | | data_blob(mem_ctx, 16) does not use mem_ctx as a talloc ctx but copies 16 bytes from mem_ctx into the newly allocated data blob. This can not have been intentional. A blank uint8_t array of length 16 is allocated by passing NULL instead of mem_ctx. And using data_blob_talloc(mem_ctx, NULL, 16) adds the allocated blank 16 byte array to mem_ctx - so this is what must have been intended. Michael
* s3:auth:sam_password_ok: enhance readability (imho) by adding some pointersMichael Adam2010-01-071-17/+24
| | | | | | and removing bool variables and several checks. Michael
* s3:check_sam_security: untangle assignment from statementMichael Adam2010-01-071-1/+2
| | | | Michael
* s3: Factor password_in_history() out of check_passwd_history()Volker Lendecke2010-01-072-25/+44
|
* s3: Simplify pdb_set_plaintext_passwd: pwhistory==NULL can not happen anymoreVolker Lendecke2010-01-071-24/+19
|
* s3: Simplify pdb_set_plaintext_passwd: pwHistLen==0 was checked aboveVolker Lendecke2010-01-071-2/+4
|
* s3: Add a paranoia check to pdb_set_plaintext_passwd()Volker Lendecke2010-01-071-0/+5
|
* s3: Simplify pdb_set_plaintext_passwd() by removing a redundant conditionVolker Lendecke2010-01-071-22/+11
| | | | | | | | | if (current_history_len != pwHistLen) { if (current_history_len < pwHistLen) { } } The second "if" is a bit pointless here
* s3: Simplify pdb_set_plaintext_passwd: memcpy deals fine with 0 bytesVolker Lendecke2010-01-071-5/+2
|
* s3: Simplify pdb_set_plaintext_passwd by using talloc_zero_arrayVolker Lendecke2010-01-071-5/+2
|
* s3: Make use of talloc_array in pdb_set_plaintext_passwd()Volker Lendecke2010-01-071-2/+3
|
* s3: Simplify pdb_set_plaintext_passwd() a bitVolker Lendecke2010-01-071-66/+63
| | | | | | | | | | Remove an indentation by the early return in + if (pwHistLen == 0) { + /* Set the history length to zero. */ + pdb_set_pw_history(sampass, NULL, 0, PDB_CHANGED); + return true; + }
* s3: Simplify pdb_set_plaintext_passwd() slightlyVolker Lendecke2010-01-071-56/+83
| | | | | | | | | | | | | | No functional change, this just removes an indentation level by the early "return True;" in + if ((pdb_get_acct_ctrl(sampass) & ACB_NORMAL) == 0) { + /* + * No password history for non-user accounts + */ + return true; + } Volker
* s3: Fix a typoVolker Lendecke2010-01-071-1/+1
|
* s3: Avoid a memset(, 0, ) callVolker Lendecke2010-01-071-2/+1
|
* s3:pdb_set_pw_history: free the old history before setting the new.Michael Adam2010-01-071-0/+1
| | | | | | | | This is not strictly necessary, since this only leaks into the struct samu, and this is not so long-lived in the code path that changes the password, but it definitely correct and does not harm. Michael
* s3:pdb_ldap:init_sam_from_ldap: untangle an assignment from the checkMichael Adam2010-01-071-3/+3
| | | | | | to enhance readability and denbuggability. Michael
* s3:lib/time: remove TIME_T_MIN/MAX definesBjörn Jacke2010-01-071-8/+0
| | | | we already get them from lib/util/time.h
* ѕ3:lib/time: replace make_dos_ and put_dos_ functions with those from lib/util/Björn Jacke2010-01-071-89/+6
|
* s3:lib/time: remoce null_mtime() - use null_time()Björn Jacke2010-01-072-14/+2
|
* s3:lib/time: remove unused nt_time_equalsBjörn Jacke2010-01-072-9/+0
| | | | we have nt_time_equal doing the same in lib/util/
* Second part of the fix for bug #7020 - smbd using 2G memory.Jeremy Allison2010-01-061-0/+7
| | | | | | | | There was a second leak in the processing of the out_data.frag prs_struct. It needs freeing once the current pdu has been returned asynchronously. Jeremy.
* ѕ3:configure: use gettimeofday check from lib/util/Björn Jacke2010-01-061-9/+1
|
* vfs_commit: print warning when no fsync support is thereBjörn Jacke2010-01-061-0/+2
| | | | this one was part of an old patch from jpeach.
* Fix bug #7020 - smbd using 2G memory.Jeremy Allison2010-01-051-0/+10
| | | | | | | | When deferring an async pipe writeX and readX transfer the outstanding request struct onto the conn struct. This needs freeing after the packet is finally processed. Jeremy.
* s3: List trusted domains from wcache when domain is offline.Bo Yang2010-01-061-24/+139
| | | | Signed-off-by: Bo Yang <boyang@samba.org>
* s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary ↵Bo Yang2010-01-062-4/+265
| | | | | | backend query. Signed-off-by: Bo Yang <boyang@samba.org>
* s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume ↵Bo Yang2010-01-068-13/+121
| | | | | | lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. Signed-off-by: Bo Yang <boyang@samba.org>
* s3 net: Fix up a share type translation and translate some more stringsKai Blin2010-01-051-5/+5
|
* s3 net: Add a few missing gettext calls.Kai Blin2010-01-053-1311/+1089
| | | | | Many many thanks to Adi Roiban from #ubuntu-translators for helping me find and fix my problems with the translations.
* s3: Happy New Year 2010Stefan Metzmacher2010-01-041-1/+1
| | | | metze
* s3: Trim down smbcontrol a bitVolker Lendecke2010-01-031-4/+2
|
* s3: Fix a shadowed variable warningVolker Lendecke2010-01-031-3/+3
|
* s3: Fix an uninitialized variable warningVolker Lendecke2010-01-031-1/+2
|
* s3: Convert cli_ulogoff to the async APIVolker Lendecke2010-01-033-19/+89
|
generated by cgit (git 2.34.1) at 2025-09-25 19:09:23 +0000