summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* vfs: Fix compile of vfs_gpfs.c.Alexander Werth2013-05-091-18/+33
| | | | | | | | | | Since the smb4acl is now correctly allocated on mem_ctx and not the talloc stack frame we can free the stack frame correctly. And the chmod emulation code now needs the vfs handle since that is now required by the callback function to set the smb4acl. Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* vfs: Allocate SMB4ACL_T on an explict memory contextAndrew Bartlett2013-05-095-33/+78
| | | | | | | | | | | | This ensures the caller knows exactly what the memory lifetime of this returned object is. This makes the NFSv4 ACL code consistent with the POSIX and NT ACL code, to avoid supprising developers who have worked on those other parts of the ACL code. Most of this patch is adding a memory context to the callers and passing it in. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
* vfs: Add vfs_handle_struct argument to smb_set_nt_acl_nfs4 and the callbackAndrew Bartlett2013-05-095-15/+16
| | | | | | | | This allows the callback to call xattr based storage functions that need this argument. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
* Remove the compound_related_in_progress state from the smb2 global state.Jeremy Allison2013-05-072-12/+0
| | | | | | | | And also remove the restriction that we can't read a new request whilst we're in this state. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@samba.org>
* The core of the fix to allow opens to go async inside a compound request.Jeremy Allison2013-05-071-43/+53
| | | | | | | | This is only allowed for opens that cause an oplock break, otherwise it is not allowed. See [MS-SMB2].pdf note <194> on Section 3.3.5.2.7. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
* Move a variable into the area of code where it's used.Jeremy Allison2013-05-071-2/+2
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
* Ensure we don't try and cancel anything that is in a compound-related request.Jeremy Allison2013-05-071-0/+8
| | | | | | | Too hard to deal with splitting off the replies. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
* Only do the 1 second delay for sharing violations for SMB1, not SMB2.Jeremy Allison2013-05-071-1/+2
| | | | | | | Match Windows behavior. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
* Makefile: Fix bug 9868 - Don't know how to make LIBNDR_PREG_OBJ.Volker Lendecke2013-05-071-1/+1
| | | | | | | | | | Thanks to Lucs for finding the issue Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue May 7 17:57:57 CEST 2013 on sn-devel-104
* winbind: Fix bug 9854 -- NULL pointer dereferenceVolker Lendecke2013-05-071-3/+3
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue May 7 14:49:07 CEST 2013 on sn-devel-104
* Allow "store dos attributes" to override the other "map XXX" parameters.Jeremy Allison2013-05-061-5/+8
| | | | | | | | Makes us consistent with what is described in the man pages. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: default --with-regedit to "auto" instead of "yes"Michael Adam2013-05-061-1/+1
| | | | | | | | | | | This means we don't build regedit when there is no ncurses and this is not an error for the overall build. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Kai Blin <kai@samba.org> Autobuild-User(master): Kai Blin <kai@samba.org> Autobuild-Date(master): Mon May 6 20:11:09 CEST 2013 on sn-devel-104
* build: fix --with-regedit to properly honour the yes/no/auto schemeMichael Adam2013-05-062-2/+24
| | | | | | | | I.e. fail configure when ncurses support is not found but regedit build was requested. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Kai Blin <kai@samba.org>
* build: simplify ncurses checks: --with-regedit does not take a path listMichael Adam2013-05-061-7/+2
| | | | | | | | | --with-regedit is defined using SAMBA3_ADD_OPTION(), and can hence take the values "yes", "no", and "auto". So it is not possible to hand in paths to look for ncurses-config via this option. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Kai Blin <kai@samba.org>
* s3:idmap:autorid: add a comment block explaining the calculationsMichael Adam2013-05-061-0/+51
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:idmap:autorid: simplify the id->sid calculationMichael Adam2013-05-061-7/+13
| | | | | | | | | | | | | To make it more intutive. rid = reduced_rid + domain_range_index * range_size where reduced_rid = (id - id_low) % range_size Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:idmap:autorid: calculate the range's low_id in ↵Michael Adam2013-05-061-8/+9
| | | | | | | | | | idmap_autorid_get_domainrange() This way, the calculation needs to be don only in one central place and the formulas get simpler. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:idmap:autorid: make calculation in idmap_autorid_sid_to_id much more obviousMichael Adam2013-05-061-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is my attempt to make the sid->unix-id calculation much more obvious. Especially with the introduction of the multi-range support an the originally named "multiplier", the calculation id = low_id + range_size * domain_number + rid - range_size * multiplier was rather opaque to me. What really happens here is this: The rid is split into a reduced_rid part that is < rangesize and a multiple of rangesize. This is given by the formula rid = rid % range_size + (rid / range_size) * range_size We define reduced_rid := rid % range_size and domain_range_index := rid / range_size ( == the original multiplier) and the original formula is equivalent to: id = reduced_rid + low_id + range_number * range_size; and reads id = reduced_rid + range_minvalue if we set range_minvalue := low_id + range_number * range_size. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:idmap:autorid: rename range.multiplier to domain_range_indexMichael Adam2013-05-061-15/+17
| | | | | | | | | The name multiplier is very confusing (at least for me). This is an index that is used to reference the various per-domain ranges. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:idmap:autorid: rename autorid_range_config.sid to domsid, along with ↵Michael Adam2013-05-061-12/+12
| | | | | | | instances Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:idmap:autorid: rename autorid_domain_config --> autorid_range_config and ↵Michael Adam2013-05-061-37/+37
| | | | | | | | | instances to "range" This describes it better with the new support for multiple ranges for domains. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:idmap:autorid: rename domainnum to rangenumMichael Adam2013-05-061-12/+13
| | | | | | | | | Now ranges don't correspond to domains any more, but multiple ranges are associated to a domain. So the name is misleading. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* s3:winbindd/autorid multiple range supportAbhidnya Joshi2013-05-061-19/+36
| | | | | | | | | | | | | | | | | when a mapping request for a RID comes in that is larger than the rangesize, allocate an extension range to be able to map this one This is especially important for large installations which might have large RIDs being used in a trusted domain that the administrator was not aware of when planning for autorid usage and so those objects could not be mapped up to now. As it is not possible to change the rangesize after the first start of autorid, this would lead to big trouble. Signed-off-by: Abhidnya Joshi <achirmul@in.ibm.com> Reviewed-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:utils fix wrong usage of PRIu64 in sscanfChristian Ambach2013-05-061-1/+3
| | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:lib fix wrong usage of PRIu64 in sscanfChristian Ambach2013-05-061-1/+1
| | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* libsmb: call directly tevent_req_simple_finish_ntstatusMatthieu Patou2013-05-061-2/+2
| | | | | | | | | | | | | The CC compiler on openindiana is not pleased with a void function doing a return of another void function. It should help the build of openindiana on the buildfarm Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon May 6 08:35:10 CEST 2013 on sn-devel-104
* Fix warnings and one compile error caused by newer gcc 4.7.Jeremy Allison2013-05-051-3/+5
| | | | | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Sun May 5 19:01:38 CEST 2013 on sn-devel-104
* idmap: Store negative cache entries if the backend failsVolker Lendecke2013-05-031-2/+2
| | | | | | | | | | | | | | | | | | This changes the behaviour for out-of-range queries: The tdb backend (probably all backends) returns NT_STATUS_NONE_MAPPED and does not set the map.status value to ID_UNMAPPED. This means that we did an early error exit, not setting a negative cache value. This makes smbd ask winbind over and over again for out-of-range gids, which can be a performance problem in certain scenarios. The new code makes us fall through to the code setting the negative cache entry in all cases. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri May 3 14:48:35 CEST 2013 on sn-devel-104
* idmap: Print error from idmap_backends_unixid_to_sidVolker Lendecke2013-05-031-2/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* check_parent_exists() can change errno. Ensure we preserve it across calls.Anand Avati2013-04-301-1/+8
| | | | | | | | Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Apr 30 11:00:11 CEST 2013 on sn-devel-104
* regedit: Use color only when available.Andreas Schneider2013-04-291-1/+8
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Apr 29 15:02:19 CEST 2013 on sn-devel-104
* regedit: Improve the while loop.Andreas Schneider2013-04-291-8/+7
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Remove talloc leak report.Andreas Schneider2013-04-291-4/+0
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Mark string values if they contain unprintable chars.C. Davis2013-04-293-3/+31
| | | | | | | Also, edit the values in bin mode to avoid screen glitches. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Add an edit binary command.C. Davis2013-04-293-12/+27
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Handle zero-length buffers better with hexedit.C. Davis2013-04-292-2/+19
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Load values on startup.C. Davis2013-04-291-4/+12
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Simplify the editor dialog input loop.C. Davis2013-04-291-47/+56
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Fix white space and wrap long lines.C. Davis2013-04-294-16/+25
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Add missing copyright headers to hexedit code.C. Davis2013-04-292-0/+38
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Enable using tab to cycle thru dialog buttons.C. Davis2013-04-291-13/+65
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Restore cursor position when user tabs to a field.C. Davis2013-04-291-0/+5
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Add a general help section.C. Davis2013-04-291-7/+16
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Print help on left side of screen instead of the right.C. Davis2013-04-291-6/+5
| | | | | | | This is little bit easier to read to my eye. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Reduce magic numbers in edit dialog, clean up edit dialog creation.C. Davis2013-04-291-79/+183
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Add help msgs for key and value sections at bottom of screen.C. Davis2013-04-291-2/+33
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Prefer copywin() over prefresh() for displaying path.C. Davis2013-04-291-4/+5
| | | | | | | copywin() works better with panels, dialogs, etc. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Cut off the front of the path when screen width is too small.C. Davis2013-04-293-9/+24
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Uese a pad for path label.C. Davis2013-04-292-16/+28
| | | | | | | This makes it easier scale the label on resize. Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* regedit: Improve padding for value summary.C. Davis2013-04-291-1/+1
| | | | | Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>