summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* smbd: Split create_conn_struct into a fn that does not change the working dirAndrew Bartlett2013-01-074-21/+58
| | | | | | | | | | | The python bindings do not want the current working directory changed during operations, so we provide two functions, one providing the original behaviour, and other providing the python bindings with just the memory allocation and initilisation stuff. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
* spoolss: add stubs for new JobNamedProperty dcerpc calls.Günther Deschner2013-01-071-0/+44
| | | | | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Jan 7 19:06:25 CET 2013 on sn-devel-104
* s3-net: Fix rpc_service_list_internal() null pointer passing.Andreas Schneider2013-01-021-2/+13
| | | | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Found by Coverity. Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Wed Jan 2 14:19:50 CET 2013 on sn-devel-104
* s3-rpcclient: Fix cmd_eventlog_loginfo() null pointer passing.Andreas Schneider2013-01-021-2/+8
| | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Found by Coverity.
* s3-rpcclient: Fix cmd_eventlog_readlog() null pointer passing.Andreas Schneider2013-01-021-7/+8
| | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Found by Coverity.
* s3-idmap: Check return value of string_to_sid().Andreas Schneider2013-01-021-1/+6
| | | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* Happy New Year 2013Stefan Metzmacher2013-01-011-1/+1
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3-prefork: Directly fail if tevent_req_is_unix_error() fails.Andreas Schneider2012-12-211-1/+3
| | | | | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Dec 21 15:38:19 CET 2012 on sn-devel-104
* s3-libsmb: Remove check if array is NULL.Andreas Schneider2012-12-211-1/+2
| | | | | | | | | | rdata is an array with data. rdlength defines how big rdata is. So if rdlength is not set we have a big problem. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix username and remote check.Andreas Schneider2012-12-211-2/+2
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Cleanup transfer_file_internal() a bit.Andreas Schneider2012-12-211-2/+6
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Make it clear we want to fall trough here.Andreas Schneider2012-12-211-0/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Make it clear that we want to fall trough here.Andreas Schneider2012-12-211-0/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-netapi: Add missing break in NetUserSetInfo_r().Andreas Schneider2012-12-211-0/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-libsmb: Fix a possible null pointer dereference.Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix null pointer derefs in rpc_pipe_open_interface().Andreas Schneider2012-12-211-5/+7
| | | | | | | Found by Coverity and asn ;) Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-winbind: Fix null pointer dereference in store_memory_creds().Andreas Schneider2012-12-211-4/+4
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-vfs: Fix a null pointer deferference in vfs_media_harmony.Andreas Schneider2012-12-211-1/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix a possible null pointer dereference.Andreas Schneider2012-12-211-1/+2
| | | | | | | | | This variable can be set to NULL in an earlier function call. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-vfs: Fix typo in readonly_connect().Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix useless check if we still have a valid string.Andreas Schneider2012-12-211-3/+3
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-libads: Fix copy&paste error in ads_keytab_add_entry().Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Fix push_ucs2() for-loop.Andreas Schneider2012-12-211-2/+2
| | | | | | | | | | | | ret is a bool and size is what we are looking for here, else the statement can never be true. Jeremy please check! Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-tldap: Fix dead code in tldap_sasl_bind_send().Andreas Schneider2012-12-211-1/+1
| | | | | | | | | dn can't be NULL cause it is set to "" in that case. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-utils: Check return value of secrets_init().Andreas Schneider2012-12-211-1/+6
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-net: Check return values of push_reg_sz().Andreas Schneider2012-12-211-4/+22
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-nmbd: Check if we created the directories correctly.Andreas Schneider2012-12-211-4/+11
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-eventlog: Make sure the eventlog directory exists.Andreas Schneider2012-12-211-2/+5
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-winbind: Check if we created the directories correctly.Andreas Schneider2012-12-211-4/+11
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-smbd: Check return code of SMB_VFS_{L}STAT.Andreas Schneider2012-12-211-2/+7
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* Fix bug #9196 - defer_open is triggered multiple times on the same request.Jeremy Allison2012-12-181-3/+3
| | | | | | | | | | | | | | | | | | get_deferred_open_message_state_smb2() is buggy in that it is checking the wrong things to determine if an open is in the deferred state. It checks if (smb2req->async_te == NULL) which is incorrect, as we're not always async in a deferred open - remove this. It should check instead state->open_was_deferred as this is explicity set to 'true' when an open is going deferred, so add this check. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Dec 18 14:19:13 CET 2012 on sn-devel-104
* s3-rpc_server: use netlogon_creds_encrypt_samlogon().Günther Deschner2012-12-151-20/+3
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli/auth: rename netlogon_creds_decrypt_samlogon() to ↵Günther Deschner2012-12-151-2/+4
| | | | | | | | | netlogon_creds_decrypt_samlogon_validation(). Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3-lib: Don't close the listener twice if we goto failed.Andreas Schneider2012-12-121-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3: Fix a typo in a debug messageVolker Lendecke2012-12-121-1/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Wed Dec 12 16:40:23 CET 2012 on sn-devel-104
* s3-printing: Correctly create the printing cache path.Andreas Schneider2012-12-121-1/+6
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-registry: Fix counters_directory() dir creation.Andreas Schneider2012-12-121-2/+2
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-ctdb: Make sure addr.sun_path is null terminated.Andreas Schneider2012-12-121-1/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-libsmb: Fix possible comparsion problems.Andreas Schneider2012-12-121-7/+21
| | | | | | | | | This makes the code also easier to understand. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-utils: Correctly handle getenv() for the later system() call.Andreas Schneider2012-12-121-7/+10
| | | | | | | | | | | The returned string of getenv() has an unknown size. You need to store the result always in a char array with a certain size to make sure we don't feed tainted data to the next function call. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-utils: Cleanup code in wait_replies().Andreas Schneider2012-12-121-3/+4
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-nmbd: Cleanup code to make it more readable.Andreas Schneider2012-12-121-3/+7
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Remove unsused variable from sys_get_nfs_quota().Andreas Schneider2012-12-121-2/+1
| | | | | | | | | testpath is the same a few lines later. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* winbind: Use talloc in resolve_username_to_alias().Andreas Schneider2012-12-121-3/+5
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* winbind: Use talloc in resolve_alias_to_username().Andreas Schneider2012-12-121-3/+5
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-selftest: make sure to test rpc.samr.passwords.validate over ncacn_ip_tcp.Günther Deschner2012-12-121-1/+4
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-rpc_server: limit allowed transports for samr_ValidatePassword().Günther Deschner2012-12-121-0/+5
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-netapi: Initialize group_handle of NetGroupSetUsers_r().Andreas Schneider2012-12-121-0/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4-netapi: Initialize group_handle of NetGroupGetUsers_r().Andreas Schneider2012-12-121-0/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3-auth: Make sure we work on valid data_blobs.Andreas Schneider2012-12-121-2/+2
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
generated by cgit (git 2.34.1) at 2025-09-26 17:11:49 +0000