summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* s3:winbindd: convert some spaces to tabs in winbindd_sids_to_xids_send()Michael Adam2012-12-031-4/+4
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd: add explaining comment winbindd_sids_to_xids_send()Michael Adam2012-12-031-0/+5
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd: factor lsa_SidType_to_id_type() out of ↵Michael Adam2012-12-031-14/+25
| | | | | | | | | winbindd_sids_to_xids_lookupsids_done() for readability Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd: simplify winbindd_sids_to_xids_recv() a bit.Michael Adam2012-12-031-40/+25
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:winbindd:util: add a comment explaining the function parse_sidlist()Michael Adam2012-12-031-0/+9
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:smbcacls: add --query-security-info and --set-security-info optionsStefan Metzmacher2012-12-021-10/+55
| | | | | | | This allows the caller to specify the security_information flags. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:libsmb: add cli_{query,set}_security_descriptor() which take sec_info flagsStefan Metzmacher2012-12-022-16/+49
| | | | | | | | In order to set and get security_descriptors it's important to specify the sec_info flags. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:smbd/open: fall back to Builtin_Administrators if SYSTEM doesn't map to a ↵Stefan Metzmacher2012-12-021-0/+54
| | | | | | | group Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:smbd/open: try the primary sid (user) as group_sid if the token has just ↵Stefan Metzmacher2012-12-021-1/+5
| | | | | | | one sid Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:smbd/open: use Builtin_Administrators as owner of files (if possible)Stefan Metzmacher2012-12-021-4/+41
| | | | | | | | | We do this if the idmap layer resolves Builtin_Administrators as ID_TYPE_BOTH and if the current token has the Builtin_Administrators SID or it's SYSTEM. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3-reg: Fix copy and paste error in debug message.Andreas Schneider2012-11-301-2/+2
| | | | Found by coverity.
* s3:popt_common: Fix password processing.Stefan Metzmacher2012-11-301-11/+2
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Nov 30 14:01:08 CET 2012 on sn-devel-104
* s3:util: fix usage of popt_burn_cmdline_password()Stefan Metzmacher2012-11-302-2/+0
| | | | | | | | We should only call popt_burn_cmdline_password() after poptFreeContext(), otherwise we remove the password to early. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-winbind: use new reconnect logic in rpc_lookup_sids() also.Günther Deschner2012-11-301-16/+7
| | | | | | | | | Volker, please check. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-winbindd: rework reconnect logic in winbindd_lookup_names().Günther Deschner2012-11-301-12/+13
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-winbindd: rework reconnect logic in winbindd_lookup_sids().Günther Deschner2012-11-301-12/+14
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-winbindd: remove lookup_sids_fn_t.Günther Deschner2012-11-301-21/+12
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-winbindd: remove lookup_names_fn_t.Günther Deschner2012-11-301-23/+13
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_client: make dcerpc_lsa_lookup_names_generic() public.Günther Deschner2012-11-302-11/+22
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: make dcerpc_lsa_lookup_sids_generic() public.Günther Deschner2012-11-302-11/+20
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-winbindd: add cm_connect_lsat().Günther Deschner2012-11-302-0/+35
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-rpc_cli: Remove some unused wrapping code.Günther Deschner2012-11-302-76/+0
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Fix Bug 9422 - large read requests cause server to issue malformed replyVolker Lendecke2012-11-301-1/+1
| | | | | | | Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Nov 30 03:27:07 CET 2012 on sn-devel-104
* dbwrap: Do not rely on dbwrap_record_get_value to return a talloc objectVolker Lendecke2012-11-291-2/+3
| | | | | | | | | | | db_tdb_fetch_locked returns the value as part of a larger talloc object that also contains the key. This means we can not realloc, but have to freshly alloc. Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Nov 29 20:21:51 CET 2012 on sn-devel-104
* s3: Remove db_ctdb_fetchVolker Lendecke2012-11-291-55/+11
| | | | | | | Note that this also makes the request for read only copies much more explicity visible in the code. Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Directly parse local existing records in db_ctdb_parse_recordVolker Lendecke2012-11-291-0/+22
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Factor out db_ctdb_can_use_local_hdr from db_ctdb_can_use_local_copyVolker Lendecke2012-11-291-11/+14
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Remove unused code for fetching persistent ctdb recordsVolker Lendecke2012-11-291-129/+0
| | | | | | | The only entry point here is parse_record, and this catches the persistent case with a direct parse now Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Avoid db_ctdb_fetch for persistent databasesVolker Lendecke2012-11-291-0/+44
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Factor out parse_newest_in_marshall_buffer from ↵Volker Lendecke2012-11-291-15/+51
| | | | | | pull_newest_from_marshall_buffer Reviewed-by: Michael Adam <obnox@samba.org>
* s3: reduce db_ctdb_marshall_loop_next to specialized db_ctdb_marshall_buf_parseVolker Lendecke2012-11-291-48/+21
| | | | | | now that the db_ctdb_marshall_loop_next_key has been factored out. Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Factor out db_ctdb_marshall_loop_next_key from db_ctdb_marshall_loop_nextVolker Lendecke2012-11-291-9/+24
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Slightly simplify db_ctdb_marshall_loop_nextVolker Lendecke2012-11-291-4/+3
| | | | | | Both callers give a key argument Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Use db_ctdb_ltdb_parse in db_ctdb_fetch_db_seqnum_from_dbVolker Lendecke2012-11-291-20/+21
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Use db_ctdb_ltdb_parse in db_ctdb_ltdb_fetchVolker Lendecke2012-11-291-30/+46
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Add db_ctdb_ltdb_parseVolker Lendecke2012-11-291-0/+42
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Slightly simplify db_ctdb_transaction_commitVolker Lendecke2012-11-291-1/+2
| | | | | | Avoid an unnecessary "else". Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Remove header==NULL code from db_ctdb_marshall_recordVolker Lendecke2012-11-291-12/+5
| | | | | | The only call chain (via db_ctdb_marshall_add) has header != NULL Reviewed-by: Michael Adam <obnox@samba.org>
* s3: test dbwrap_ctdbVolker Lendecke2012-11-295-0/+153
| | | | Reviewed-by: Michael Adam <obnox@samba.org>
* s3-printing: add missing carriage return to debug strDavid Disseldorp2012-11-291-1/+1
| | | | Reviewed-by: Andreas Schneider <asn@samba.org>
* rpcclient: fix usage docs for rpcclient adddriverDavid Disseldorp2012-11-291-2/+2
| | | | | | The printer driver name is incorrectly referred to as the printer name. Reviewed-by: Andreas Schneider <asn@samba.org>
* spoolss: fix segfault when "default devmode" is disabledDavid Disseldorp2012-11-291-18/+34
| | | | | | | | | | | | | | | | | | | Currently when "default devmode" is explicitly disabled, and a printer is added with a null device mode, spoolssd crashes in copy_devicemode(). Both construct_printer_info2() and construct_printer_info8() code paths currently unconditionally attempt to copy a printers device mode, without checking whether one is present. This change fixes this regression such that construct_printer_info*() functions check for a null device mode before copying. https://bugzilla.samba.org/show_bug.cgi?id=9433 Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Nov 29 13:03:05 CET 2012 on sn-devel-104
* s3: Use dbwrap_parse_record in fetch_share_mode_unlockedVolker Lendecke2012-11-281-13/+14
| | | | Reviewed-by: Andreas Schneider <asn@samba.org>
* BUG 9436: Fix leaking sockets of SMB connections to a DC.Andreas Schneider2012-11-281-0/+4
| | | | | | | | | | | | As this is a burst of 3 unbound sockets with each try to reach a DC we're running out of file descriptors pretty fast. So winbind is then mostly spinning in an accept loop failing with EMFILE. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org> Autobuild-User(master): Jim McDonough <jmcd@samba.org> Autobuild-Date(master): Wed Nov 28 17:17:21 CET 2012 on sn-devel-104
* s3:vfs_gpfs: add no memory check in gpfs2smb_acl()Stefan Metzmacher2012-11-281-0/+5
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Nov 28 14:06:27 CET 2012 on sn-devel-104
* s3:vfs_gpfs: make sure we return the correct errno in gpfs2smb_acl()Stefan Metzmacher2012-11-281-1/+1
| | | | | | | TALLOC_FREE() could overwrite errno. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4:smbd/open: add missing TALLOC_FREE(frame) to inherit_new_acl()Stefan Metzmacher2012-11-281-0/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:vfs_aixacl2: make use of vfs_aixacl_util.hStefan Metzmacher2012-11-281-3/+1
| | | | | | | This should fix the build. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3: Open gencache_notrans with TDB_NOSYNCVolker Lendecke2012-11-281-1/+4
| | | | | | | | | | | | | | | | | | | We are doing CLEAR_IF_FIRST here, and we are doing the transactions only to protect gencache_stabilize against concurrent writers. tdb's transaction.c says: - if TDB_NOSYNC is passed to flags in tdb_open then transactions are still available, but no fsync/msync calls are made. This means we are still proof against a process dying during transaction commit, but not against machine reboot. For gencache_notrans.tdb this is exactly what we want and avoids some expensive disk syncs. Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 28 03:13:56 CET 2012 on sn-devel-104
* s3: Avoid some transaction_commit on gencache.tdbVolker Lendecke2012-11-271-0/+110
| | | | | | | Commits are expensive, and in some scenarios we are overwriting existing values again and again. Reviewed by: Jeremy Allison <jra@samba.org>