summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* Move handle checking code to copychunk_check_handles().Jeremy Allison2013-01-181-21/+37
| | | | | | | | Planning to add extra checks to ensure we don't attempt copychunk on printer or IPC$ handles. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* printing: Create default architecture directories on init.Andreas Schneider2013-01-171-0/+59
| | | | | | | Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Jan 17 20:36:17 CET 2013 on sn-devel-104
* s3-spoolss: use configurable spoolss architecture in ↵Günther Deschner2013-01-171-1/+5
| | | | | | | | | | | | compose_spoolss_server_path(). Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Thu Jan 17 18:53:47 CET 2013 on sn-devel-104
* spoolss: make spoolss deal with ndr64 SetForm by using proper container object.Günther Deschner2013-01-172-5/+14
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* spoolss: make spoolss deal with ndr64 AddForm by using proper container object.Günther Deschner2013-01-173-12/+20
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* spoolss: make spoolss deal with ndr64 ULONG_PTR of devmode_ptr and secdesc_ptr.Günther Deschner2013-01-173-6/+4
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* smb2_ioctl: copychunk request max output validationDavid Disseldorp2013-01-171-0/+12
| | | | | | | | | | Check that the copychunk ioctl request maximum output specified by the client is large enough to hold copychunk response data. Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Jan 17 00:59:44 CET 2013 on sn-devel-104
* smb2_ioctl: track copychunk response output stateDavid Disseldorp2013-01-161-16/+38
| | | | | | Treat the response data independent to the status. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: copychunk CHECK_READ and CHECK_WRITEDavid Disseldorp2013-01-161-0/+25
| | | | | | | | | | | [MS-SMB2] 3.3.5.15.6 Handling a Server-Side Data Copy Request, specifies that the copychunk destination file handle be granted FILE_WRITE_DATA and FILE_READ_DATA access. FILE_READ_DATA access must also be granted on the copychunk source file, which may be done implicitly with execute permission. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: only pass through to VFS on a valid fspDavid Disseldorp2013-01-161-13/+17
| | | | | | A null fsp is dereferenced on VFS call. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: perform locking around copychunk requestsDavid Disseldorp2013-01-161-17/+137
| | | | | | | | | | For each chunk in a copychunk request, take a read and write lock on the source and destination files respectively. Also change the resume key format to use a combination of the persistent and volatile handles. Thanks to Metze for his help on this. Reviewed by: Jeremy Allison <jra@samba.org>
* smbd: split out file_fsp_get from file_fsp_smb2David Disseldorp2013-01-162-10/+27
| | | | | | | Obtain the files_struct from smb2req, persistent_id and volatile_id. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: remove ioctl error response assumptionsDavid Disseldorp2013-01-161-17/+57
| | | | | | | | | | | | MS-SMB2 3.3.4.4 documents cases where a ntstatus indicating an error should not be considered a failure. In such a case the output data buffer should be sent to the client rather than an error response packet. Add a new fsctl copy_chunk test to confirm field limits are sent back in response to an oversize chunk request. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: add support for FSCTL_SRV_COPYCHUNKDavid Disseldorp2013-01-161-4/+231
| | | | | | | | | | | | | SMB2 clients can issue FSCTL_SRV_COPYCHUNK requests in order to copy data between files on the server side only, rather than reading data then writing back from the client. FSCTL_SRV_COPYCHUNK is used by default for Explorer SMB2 file copies on Windows Server 2012. 2.2.32.1 SRV_COPYCHUNK_RESPONSE in [MS-SMB2] describes the requirement for the server to provide maximum copychunk request size limits in ioctl responses carrying STATUS_INVALID_PARAMETER. Reviewed by: Jeremy Allison <jra@samba.org>
* s3-vfs: add copy_chunk vfs hooksDavid Disseldorp2013-01-166-3/+292
| | | | | | | | | | | | | | | | | | copy_chunk copies n bytes from a source file at a specific offset to a destination file at a given offset. This interface will be used in handling smb2 FSCTL_SRV_COPYCHUNK ioctl requests. Use a pread/pwrite loop in vfs_default, so that requests referring to the same src and dest file are possible. Provide send and receive hooks for copy chunk VFS interface, allowing asynchronous behaviour. Check whether the request source offset + length exceeds the current size. Return STATUS_INVALID_VIEW_SIZE under such a condition, matching Windows server behaviour. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: add FSCTL_SRV_REQUEST_RESUME_KEY supportDavid Disseldorp2013-01-163-2/+49
| | | | | | | | | Use existing ioctl IDL infrastructure for marshalling. Support for this ioctl is a prerequisite for FSCTL_SRV_COPYCHUNK handling. The client-opaque resume key is constructed using the server side dev/inode file identifier. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: split ioctl handler code on device typeDavid Disseldorp2013-01-168-355/+684
| | | | | | | Add per device type ioctl handler source files for FSCTL_DFS, FSCTL_FILESYSTEM, FSCTL_NAMED_PIPE and FSCTL_NETWORK_FILESYSTEM. Reviewed by: Jeremy Allison <jra@samba.org>
* smb2_ioctl: split ioctl handlers into separate funtionsDavid Disseldorp2013-01-161-154/+173
| | | | Reviewed by: Jeremy Allison <jra@samba.org>
* build(waf): fix the abi_match for the pdb libraryMichael Adam2013-01-161-1/+1
| | | | | | | | | | | | | | | | | The global wildcard match is automatically added by the parsing code if the global match list is empty. Specifying an explicit '*' as the only global match lets the parsing code add a second '*' to the local list, which is an error tolerated on my linux by ld (the GNU linker), but not by the stricter GNU ELF linker "gold". Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Gregor Beck <gbeck@sernet.de> Signed-off-by: Michael Adam <obnox@samba.org> Signed-off-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Alexander Bokovoy <ab@samba.org> Autobuild-Date(master): Wed Jan 16 21:31:00 CET 2013 on sn-devel-104
* spoolss: Make OpenPrinterEx work with NDR64 by using UserInfo Container.Günther Deschner2013-01-162-10/+12
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* test: dbwrap_tool requires --persistent for the registry nowVolker Lendecke2013-01-152-2/+2
| | | | | | | Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Jan 15 16:31:35 CET 2013 on sn-devel-104
* s3:dbwrap_tool: add --persistent switch and mode for non-persistent DBsMichael Adam2013-01-151-12/+45
| | | | | | | This changes the default for dbwrap_tool to open a DB as non-persistent. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* smbd: Fix bug 9544, part 2Volker Lendecke2013-01-151-0/+80
| | | | | | | | | Plug in async pwrite Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Jan 15 00:55:51 CET 2013 on sn-devel-104
* smbd: Fix bug 9544, part 1Volker Lendecke2013-01-141-3/+3
| | | | | | Adapt the sync function names Reviewed by: Jeremy Allison <jra@samba.org>
* smbd: Always compile vfs_commitVolker Lendecke2013-01-142-0/+2
| | | | | | There's no reason not to Reviewed by: Jeremy Allison <jra@samba.org>
* configure: Fix bug 9546, aio_suspend detection on FreeBSDVolker Lendecke2013-01-142-2/+2
| | | | | | NULL is not defined without some includes Reviewed by: Jeremy Allison <jra@samba.org>
* samr: Make use of posix_openptVolker Lendecke2013-01-143-2/+6
| | | | Reviewed by: Jeremy Allison <jra@samba.org>
* samr: Split up an assignment from an if conditionVolker Lendecke2013-01-141-1/+2
| | | | Reviewed by: Jeremy Allison <jra@samba.org>
* winbind: Fix some missing NULL checksVolker Lendecke2013-01-111-24/+29
| | | | | | | Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Jan 11 18:55:41 CET 2013 on sn-devel-104
* winbind: Fix error check in unpack_tdc_domainsVolker Lendecke2013-01-111-2/+5
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* dbwrap: Use INCOMPATIBLE_HASH for dbwrap_watchers.tdbVolker Lendecke2013-01-111-3/+4
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* swat: move russian swat files alongside ja and trAndrew Bartlett2013-01-1011-85/+0
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* passdb: Add discard_const_p() to pdb_samba_dsdbAndrew Bartlett2013-01-101-2/+2
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* vfs: Fix compilation of solaris ACL moduleAndrew Bartlett2013-01-101-1/+1
| | | | | | Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-lib: Use new strict directory create function in create_pipe_sock().Andreas Schneider2013-01-091-44/+6
| | | | | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Jan 9 10:55:23 CET 2013 on sn-devel-104
* Use the new directory_create_or_exist_strict() function.Andreas Schneider2013-01-092-2/+2
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3:smb2_negprot: set the 'remote_proto' valueStefan Metzmacher2013-01-091-0/+8
| | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3: Fix vfs_zfsacl to compile.Ira Cooper2013-01-091-3/+3
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest: show that Samba honours "write list" and valid usersAndrew Bartlett2013-01-093-2/+15
| | | | | Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* Fixup the change_to_user_by_session() case as called from ↵Jeremy Allison2013-01-091-0/+22
| | | | | | | | | | | | | become_user_by_session() Use inside source3/printing/nt_printing.c:get_correct_cversion(). Allow check_user_ok() to be called with vuid==UID_FIELD_INVALID. All this should do is throw away one entry in the vuid cache. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* smbd: Remove some ()Volker Lendecke2013-01-091-3/+3
| | | | | | Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* smbd: Simplify an if-expressionVolker Lendecke2013-01-091-10/+7
| | | | | | Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* smbd: Fix a typoVolker Lendecke2013-01-091-1/+1
| | | | | | Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Move create_share_access_mask() from smbd/service.c to smbd/uid.c.Jeremy Allison2013-01-093-41/+38
| | | | | | | | Make it static. Only called from uid.c now. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Fix bug #9518 - conn->share_access appears not be be reset between users.Jeremy Allison2013-01-091-20/+8
| | | | | | | | | Ensure make_connection_snum() uses the same logic as check_user_ok() to decide if a user can access a share. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Factor code out of check_user_ok() into a call to check_user_share_access().Jeremy Allison2013-01-091-34/+7
| | | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Initialize stack variables. Prelude to factoring out calls to ↵Jeremy Allison2013-01-091-2/+2
| | | | | | | | check_user_share_access(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Add check_user_share_access() which factors out the share security and ↵Jeremy Allison2013-01-092-0/+60
| | | | | | | | | | | read_only flag setting code. Allows this to be called from both make_connection_snum() as well as check_user_ok(). Gives a consistent share security check function. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Correctly setup the conn->share_access based on the current user token.Jeremy Allison2013-01-091-12/+22
| | | | | | | | | | Also use this to set conn->read_only. Cache the share_access in the struct vuid_cache_entry struct so we only evaluate this once per new user access on this share. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Change API for create_share_access_mask() - remove conn struct.Jeremy Allison2013-01-092-7/+7
| | | | | | | | | Eventually this will be indepentent of conn, just pass in the readonly flag. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>