summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* s3: Fix Coverity ID 703870 Uninitialized scalar variableVolker Lendecke2012-06-111-0/+1
| | | | | | | According to man 2 recvmsg this might be unnecessary, but it does not hurt either Signed-off-by: Jeremy Allison <jra@samba.org>
* s3: Save errno around a TALLOC_FREEVolker Lendecke2012-06-111-0/+3
| | | | Signed-off-by: Jeremy Allison <jra@samba.org>
* s3: Fix Coverity ID 703871 Unused pointer valueVolker Lendecke2012-06-111-0/+4
| | | | Signed-off-by: Jeremy Allison <jra@samba.org>
* s3-winbindd: add comments about dump_core_setupMatthieu Patou2012-06-111-0/+11
| | | | | | | | This patch is related to change 0ea7152ff479e32e25817e4ddb1c2a1569bad81d Comments are added to explain why we call dump_core_setup 3 times. Autobuild-User(master): Matthieu Patou <mat@samba.org> Autobuild-Date(master): Mon Jun 11 21:21:11 CEST 2012 on sn-devel-104
* s3:smbd: explain parameters to filename_convert call in smbd_smb2_create_send()Michael Adam2012-06-111-2/+2
| | | | | Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Jun 11 19:21:51 CEST 2012 on sn-devel-104
* s3: Fix Coverity ID 703869 Logically dead codeVolker Lendecke2012-06-111-10/+6
| | | | | | | | | | | | We "TALLOC_FREE(curr)" and assign prev=curr in the for-loop header. This will lead to "prev"==NULL always. In this loop, we do not need to correctly re-shuffle the linked list, we delete all from the beginning anyway. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 11 17:26:53 CEST 2012 on sn-devel-104
* s3: Fix Coverity ID 709049 Dereference before null checkVolker Lendecke2012-06-111-1/+1
| | | | | | | | | | We have dereferenced fsp before. Because smb2 is only handle based, this is a bogus check. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 11 15:30:54 CEST 2012 on sn-devel-104
* s3-smbd: Remove unused branches in negprot since security=share was removedAndrew Bartlett2012-06-111-21/+8
|
* s3/test: make dd call more portableBjörn Jacke2012-06-101-1/+1
| | | | | | | using multiplicative suffixes like K, M etc. in dd isn't portable Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Sun Jun 10 23:29:42 CEST 2012 on sn-devel-104
* s3: fix build on systems without O_NOFOLLOWBjörn Jacke2012-06-101-1/+1
|
* Revert "s3:smbd: set req->smb2req->compat_chain_fsp in file_fsp()"Stefan Metzmacher2012-06-101-3/+0
| | | | | | | | | | | This reverts commit c2716a7d5ccf78f9716b703c22e6cf4d4f179656. This is not needed anymore, as we have file_fsp_smb2() now. metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sun Jun 10 18:04:21 CEST 2012 on sn-devel-104
* s3: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW ↵Björn Jacke2012-06-101-1/+20
| | | | | | | | | | | | | symlink open calls or should we leave the NetBSD and FreeBSD platforms just broken? Actually these two *want* to have broken platforms as they use different errno's than POSIX demands *interntionally*. The POSIX errno ELOOP for O_NOFOLLOW open calls on symlinks is clear and unambiguous. See http://gnats.netbsd.org/43154 for the interesting NetBSD discussion on that. Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Sun Jun 10 16:10:02 CEST 2012 on sn-devel-104
* s3:smb2_ioctl: make use of file_fsp_smb2()Stefan Metzmacher2012-06-101-30/+12
| | | | | | | metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sun Jun 10 01:10:15 CEST 2012 on sn-devel-104
* s3:smb2_lock: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-30/+12
| | | | metze
* s3:smb2_write: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smb2_read: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-29/+11
| | | | metze
* s3:smb2_notify: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smb2_setinfo: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-29/+12
| | | | metze
* s3:smb2_getinfo: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-29/+12
| | | | metze
* s3:smb2_find: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smb2_break: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-32/+13
| | | | metze
* s3:smb2_close: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-30/+15
| | | | metze
* s3:smb2_flush: make use of file_fsp_smb2()Stefan Metzmacher2012-06-091-26/+9
| | | | metze
* s3:smbd: add file_fsp_smb2()Stefan Metzmacher2012-06-092-0/+46
| | | | metze
* s3:smb2_write: pass fsp->fnum to init_strict_lock_struct()Stefan Metzmacher2012-06-091-1/+1
| | | | | | | | | | | | fsp->fnum is the same as in_file_id_volatile. When we start to support durable handles we should pass in_file_id_persistent. metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat Jun 9 18:50:32 CEST 2012 on sn-devel-104
* s3:smb2_read: pass fsp->fnum to init_strict_lock_struct()Stefan Metzmacher2012-06-091-2/+2
| | | | | | | | | fsp->fnum is the same as in_file_id_volatile. When we start to support durable handles we should pass in_file_id_persistent. metze
* s3:smb2_lock: use fsp->fnum as locking contextStefan Metzmacher2012-06-091-1/+1
| | | | | | | | | fsp->fnum is the same as in_file_id_volatile. When we start to support durable handles we should pass in_file_id_persistent. metze
* s3:smb2_lock: use smb2req->compat_chain_fsp instead of looking it up againStefan Metzmacher2012-06-091-6/+1
| | | | metze
* s3:smbd: set req->smb2req->compat_chain_fsp in file_fsp()Stefan Metzmacher2012-06-091-0/+3
| | | | metze
* s3:smb2_close: add missing TALLOC_FREE(subreq) in smbd_smb2_request_close_done()Stefan Metzmacher2012-06-091-0/+1
| | | | | | | metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat Jun 9 13:57:31 CEST 2012 on sn-devel-104
* s3:smbd: readd START_PROFILE(smbd_idle)/END_PROFILE(smbd_idle)Stefan Metzmacher2012-06-091-0/+15
| | | | metze
* s3:smbd: change set_file_oplock() to return NTSTATUSMichael Adam2012-06-083-7/+9
| | | | | | | | Pair-Programmed-With: Volker Lendecke <vl@samba.org> Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Jun 8 23:20:20 CEST 2012 on sn-devel-104
* s3: Replace an if with a boolean short circuitVolker Lendecke2012-06-081-5/+3
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Assigning ?True:False to a bool is a bit pointlessVolker Lendecke2012-06-081-3/+2
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Remove unnecessary ()Volker Lendecke2012-06-081-1/+1
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Replace an if with a boolean short circuitVolker Lendecke2012-06-081-5/+3
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Assigning ?True:False to a bool is a bit pointlessVolker Lendecke2012-06-081-2/+2
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Remove unnecessary ()Volker Lendecke2012-06-081-1/+1
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3:smbd: remove unnecessary variable readret from read_file()Michael Adam2012-06-081-7/+3
| | | | | | | Pair-Programmed-With: Volker Lendecke <vl@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Jun 8 18:08:09 CEST 2012 on sn-devel-104
* s3:smbd: remove ancient DMF_FIX from read_file().Michael Adam2012-06-081-15/+0
| | | | Pair-Programmed-With: Volker Lendecke <vl@samba.org>
* s3-rpcclient: add fsrvp commandsDavid Disseldorp2012-06-085-3/+670
| | | | | | | | | | | | | | | | | | | | | | | | | fss_create_expose connects to an FSRVP server and negotiates the creation and exposure of a share shadow-copy. shadow-copies of multiple shares can be requested with a single fss_create_expose request. ddiss@plati:~> bin/rpcclient -k -U 'LURCH\administrator%password' \ ncacn_np:lutze[sign] rpcclient $> fss_create_expose backup ro hyper 381884f2-b578-45ea-b8d2-cf82491f4011: shadow-copy set created ... share hyper@{B6137E21-9CBB-4547-A21D-E7AD40D0874B} exposed as a snapshot of \\lutze\hyper fss_delete removes the shadow-copy share: rpcclient $> fss_delete hyper 381884f2-b578-45ea-b8d2-cf82491f4011 \ b6137e21-9cbb-4547-a21d-e7ad40d0874 Shadow-copies can be created read-write or read-only. Experimenting with Windows Server "8" beta, a recovery complete call is required after creating a read-write (ATTR_AUTO_RECOVERY) shadow copy. Otherwise subsequent creation requests fail with FSRVP_E_SHADOW_COPY_SET_IN_PROGRESS.
* s3-winbindd: call dump_core_setup after command line option has been parsedMatthieu Patou2012-06-081-0/+2
| | | | | | | | | | | | | | | | | | Without this fix in some situations winbindd can't coredump. Such cases append when samba is compiled in a custom prefix (ie. /home/build/mat/prod/1/) in this case get_dyn_LOGFILEBASE or basename(lp_logfile) before the configuration file and the command line is parsed will be something like /home/build/mat/prod/1/var which might not exists on the host where you run it (where it's most probably more "normal" directories). Specifying --log-basename didn't help as dump_core_setup is called before the command line and the config file is read so it didn't help getting a correct value in dump_core_setup. We fix this issue by calling dump_core_setup() also after the command line has been read and also after the configfile has been parsed so that the final location for the coredump is coherent with the final logile location. Autobuild-User(master): Matthieu Patou <mat@samba.org> Autobuild-Date(master): Fri Jun 8 06:33:33 CEST 2012 on sn-devel-104
* s3-waf: Fix the winbindd active directory idmap support build.Ira Cooper2012-06-081-1/+1
| | | | | | | This fixes the SAMBA3_MODULE for idmap_ad so it will actually attempt to build. Autobuild-User(master): Ira Cooper <ira@samba.org> Autobuild-Date(master): Fri Jun 8 04:38:04 CEST 2012 on sn-devel-104
* build: fix typo that breaks the HP-UX buildBjörn Jacke2012-06-071-1/+1
| | | | | Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Thu Jun 7 12:49:17 CEST 2012 on sn-devel-104
* build: Tidy up broken posix_fallocate testsAndrew Bartlett2012-06-072-3/+3
| | | | | | | | | This makes the code and output for in waf and autoconf identical. Andrew Bartlett Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Jun 7 08:35:33 CEST 2012 on sn-devel-104
* s3: enable winbind also for upcoming FreeBSD/NetBSD releases >=10Björn Jacke2012-06-071-2/+2
|
* s3:include: change lock_struct->fnum to uint64_tMichael Adam2012-06-064-6/+7
| | | | | | | | | Note: this changes the format of brlock.tdb! Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Wed Jun 6 23:22:00 CEST 2012 on sn-devel-104
* s3:include: change lock_context->tid to uint32_tMichael Adam2012-06-061-1/+1
| | | | | | Note: this changes for format of brlock.tdb! Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
* s3:include: change connection_struct->cnum to uint32_tMichael Adam2012-06-064-4/+4
| | | | Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
* s3:include: change smb_request->tid to uint32_tMichael Adam2012-06-061-1/+1
| | | | Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>