summaryrefslogtreecommitdiffstats
path: root/source3
Commit message (Collapse)AuthorAgeFilesLines
...
* libsmb: Fix a bunch of Coverity IDsVolker Lendecke2013-08-201-20/+20
| | | | | | | | | | | | | | (fnum != -1) is always true, even if fnum=-1 was initialized. fnum is a uint16, and the comparison first casts this to 65535, which is always != -1. Also change the initialization to make it clearer what is happening here. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Aug 20 00:52:36 CEST 2013 on sn-devel-104
* Fix bug #10097 - MacOSX 10.9 will not follow path-based DFS referrals handed ↵Richard Sharpe2013-08-193-6/+19
| | | | | | | | | | | | | | | | out by Samba. Windows overloads the EA Length field in the DIRECTORY INFO leves of FIND FIRST/FIND NEXT. This field indicates either the REPARSE_TAG if the file/folder has a reparse proint or the EA Length if it has EAs, and is the fundamental reason you cannot have both on a file or folder. Signed-off-by: Richard Sharpe <rsharpe@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Aug 19 22:21:34 CEST 2013 on sn-devel-104
* rpc_server: Fix CID 1063255 Resource leakVolker Lendecke2013-08-191-1/+1
| | | | | | | | | | | We would leak a socket 0 here Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Aug 19 03:10:51 CEST 2013 on sn-devel-104
* smbd: Fix CID 1063259 Uninitialized scalar variableVolker Lendecke2013-08-191-0/+1
| | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* log2pcaphex: Fix nonempty line endingsVolker Lendecke2013-08-191-16/+15
| | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* vfs_glusterfs: Implement proper mashalling/unmarshalling of ACLsAnand Avati2013-08-161-42/+111
| | | | | | | | | | | | | | | Use the primitives available in Samba byteorder.h for implementing proper (un)marshalling of ACL xattrs. - Incorporated Raghavendra Talur's comments on v3 Signed-off-by: Anand Avati <avati@redhat.com> Signed-off-by: Raghavendra Talur <rtalur@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Christopher R. Hertel <crh@samba.org> Tested-by: Jose A. Rivera <jarrpa@redhat.com> Autobuild-User(master): Simo Sorce <idra@samba.org> Autobuild-Date(master): Fri Aug 16 20:34:51 CEST 2013 on sn-devel-104
* smbd: Do not wait unnecessarilyVolker Lendecke2013-08-161-1/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Aug 16 18:46:36 CEST 2013 on sn-devel-104
* smbd: Make break_level2_to_none_async staticVolker Lendecke2013-08-162-2/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* libctdb: Avoid an explicit memsetVolker Lendecke2013-08-161-2/+1
| | | | | | | | | | Give the compiler a chance to use better code. Saves a few bytes of text. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Aug 16 01:51:55 CEST 2013 on sn-devel-104
* s3:libsmb: call smb2cli_logoff() from cli_ulogoff()Stefan Metzmacher2013-08-151-0/+12
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Aug 15 10:53:21 CEST 2013 on sn-devel-104
* s3:libsmb: make cli_ulogoff_send/recv staticStefan Metzmacher2013-08-152-6/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: call smb2cli_tdis() from cli_tdis()Stefan Metzmacher2013-08-151-0/+4
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: only set tcon to invalid in smb2cli_tdis*Stefan Metzmacher2013-08-151-1/+2
| | | | | | | This matches the behavior of cli_tdis*. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: make cli_tdis_send/recv staticStefan Metzmacher2013-08-152-6/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: add support for SMB2 in cli_writeall()Stefan Metzmacher2013-08-151-2/+12
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: add SMB2 support to cli_pull*Stefan Metzmacher2013-08-151-14/+46
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: add SMB2 support to cli_push*Stefan Metzmacher2013-08-151-16/+50
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: Plumb cli_smb2_set_security_descriptor() inside ↵Jeremy Allison2013-08-151-0/+7
| | | | | | | cli_set_security_descriptor(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_query_security_descriptor() inside ↵Jeremy Allison2013-08-151-0/+9
| | | | | | | cli_query_security_descriptor(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_qpathinfo_alt_name() inside cli_qpathinfo_alt_name().Jeremy Allison2013-08-151-0/+6
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_qpathinfo_basic() inside cli_qpathinfo_basic().Jeremy Allison2013-08-151-1/+10
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_qfileinfo_basic() inside cli_qfileinfo_basic().Jeremy Allison2013-08-151-0/+12
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_qpathinfo_streams() inside cli_qpathinfo_streams().Jeremy Allison2013-08-151-1/+11
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_qpathinfo2() inside cli_qpathinfo2().Jeremy Allison2013-08-151-1/+15
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_list() inside cli_list().Jeremy Allison2013-08-151-1/+7
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_get_ea_list_path() inside cli_get_ea_list_path().Jeremy Allison2013-08-151-1/+11
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_set_ea_fnum() inside cli_set_ea_fnum().Jeremy Allison2013-08-151-0/+8
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_set_ea_path() inside cli_set_ea_path().Jeremy Allison2013-08-151-1/+11
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Fix cli_set_ea_path() to use frame instead of talloc_tos().Jeremy Allison2013-08-151-3/+7
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_dskattr() inside cli_dskattr().Jeremy Allison2013-08-151-1/+7
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_getatr() inside cli_getatr().Jeremy Allison2013-08-151-1/+11
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_setatr() inside cli_setatr().Jeremy Allison2013-08-151-1/+10
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_setattrE() inside cli_setattrE().Jeremy Allison2013-08-151-1/+11
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_getattrE() inside cli_getattrE().Jeremy Allison2013-08-151-1/+13
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_close_fnum() inside cli_close().Jeremy Allison2013-08-151-1/+7
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_create_fnum() inside cli_ntcreate().Jeremy Allison2013-08-151-1/+16
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_rmdir() inside cli_rmdir().Jeremy Allison2013-08-151-1/+7
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_mkdir() inside cli_mkdir().Jeremy Allison2013-08-151-1/+7
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_unlink() inside cli_unlink().Jeremy Allison2013-08-151-1/+7
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Plumb cli_smb2_rename() inside cli_rename().Jeremy Allison2013-08-151-1/+9
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:libsmb: Add in the core of the libsmb client SMB2 functions.Jeremy Allison2013-08-157-7/+2543
| | | | | | | | | | These create a synchronous cli_smb2_XXX() style interface designed to plug directly into the libsmb/cliXXXX.c code. https://bugzilla.samba.org/show_bug.cgi?id=9974 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:lib: Factor read_ea_list_entry() and read_nttrans_ea_list() out so they ↵Jeremy Allison2013-08-155-105/+166
| | | | | | | can be used by the SMB2 client code. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:client: fix compiler warningStefan Metzmacher2013-08-151-1/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:client: use the default io sizeStefan Metzmacher2013-08-151-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: remove unused cli_readall*Stefan Metzmacher2013-08-151-119/+0
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: rewrite cli_pull* to use smb1cli_conn_req_possible()Stefan Metzmacher2013-08-151-171/+246
| | | | | | | | | | | | This works out if it's possible to ship the next request dynamically instead of relying on fixed values. The default window size is 16 MByte. We limit the number of outstanding chunks/requests to 256. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:libsmb: rewrite cli_push* to use smb1cli_conn_req_possible()Stefan Metzmacher2013-08-151-101/+187
| | | | | | | | | | | | This works out if it's possible to ship the next request dynamically instead of relying on fixed values. The default window size is 16 MByte. We limit the number of outstanding chunks/requests to 256. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libcli/smb: pass max_dyn_len to smb2cli_req_send()Stefan Metzmacher2013-08-151-2/+4
| | | | | | | | This way we can calculate the correct credit charge for requests with large output buffers. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* libcli/smb: Change smb2cli_create() and smb2cli_create_recv() to return a ↵Jeremy Allison2013-08-152-17/+34
| | | | | | | | | parameter blob of the newly opened/created file. Will use in the smb2 client code. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* libcli/smb: Fix smb2cli_write_recv() and smb2cli_write() to return the bytes ↵Jeremy Allison2013-08-152-9/+12
| | | | | | | written. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>