Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | s3: Remove the unused "file_existed" parameter from smbd_calculate_access_mask | Volker Lendecke | 2012-01-03 | 1 | -3/+2 |
| | | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Jan 3 15:16:50 CET 2012 on sn-devel-104 | ||||
* | s3: Avoid "file_existed" in smbd_calculate_maximum_allowed_access | Volker Lendecke | 2012-01-03 | 1 | -36/+35 |
| | | | | | We access the file by name anyway, so we can just try to access it. The file system will for sure tell us if the file does not exist. | ||||
* | s3: Remove some else{} branches in smbd_calculate_maximum_allowed_access | Volker Lendecke | 2012-01-03 | 1 | -3/+7 |
| | |||||
* | s3: Directly use *p_access_mask in smbd_calculate_maximum_allowed_access | Volker Lendecke | 2012-01-03 | 1 | -6/+4 |
| | |||||
* | s3: Factor out smbd_calculate_maximum_allowed_access | Volker Lendecke | 2012-01-03 | 1 | -40/+59 |
| | |||||
* | Allow an object to be deleted from a directory if the caller has ↵ | Jeremy Allison | 2011-12-20 | 1 | -1/+9 |
| | | | | | | | | | | DELETE_CHILD access even if we don't have access to read the ACL on the object. Fixes bug #8673 - NT ACL issue. Different fix needed for 3.6.x. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Dec 20 22:13:51 CET 2011 on sn-devel-104 | ||||
* | check_name() not needed in mkdir. | Jeremy Allison | 2011-12-17 | 1 | -5/+0 |
| | | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Dec 17 02:44:55 CET 2011 on sn-devel-104 | ||||
* | Ensure VALID_STAT before accessing fields. | Jeremy Allison | 2011-12-17 | 1 | -1/+3 |
| | |||||
* | s3:smbd: avoid using sconn_server_id() | Stefan Metzmacher | 2011-12-16 | 1 | -3/+3 |
| | | | | metze | ||||
* | s3: Add some const to find_oplock_types | Volker Lendecke | 2011-12-16 | 1 | -1/+1 |
| | | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Dec 16 09:10:07 CET 2011 on sn-devel-104 | ||||
* | s3: Make open_file_ntcreate a bit easier to read | Volker Lendecke | 2011-12-16 | 1 | -3/+2 |
| | | | | Move the declaration of "id" closer to its use | ||||
* | s3: Make open_file_ntcreate a bit easier to read | Volker Lendecke | 2011-12-16 | 1 | -4/+6 |
| | | | | Move the calculation of "new_file_created" closer to its use | ||||
* | s3: Make open_file_ntcreate a bit easier to read | Volker Lendecke | 2011-12-16 | 1 | -3/+3 |
| | | | | Remove a negation where it's not necessary | ||||
* | s3: Slightly simplify delay_for_exclusive_oplocks | Volker Lendecke | 2011-12-16 | 1 | -9/+15 |
| | |||||
* | s3: Slightly simplify delay_for_batch_oplocks | Volker Lendecke | 2011-12-16 | 1 | -6/+6 |
| | |||||
* | Third part of fix for bug #8663 - deleting a symlink fails if the symlink ↵ | Jeremy Allison | 2011-12-16 | 1 | -0/+8 |
| | | | | | | | | | target is outside of the share. smbd_check_access_rights() - we can always delete a symlink. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Dec 16 03:32:15 CET 2011 on sn-devel-104 | ||||
* | First part of fix for bug #8663 - deleting a symlink fails if the symlink ↵ | Jeremy Allison | 2011-12-15 | 1 | -12/+0 |
| | | | | | | | target is outside of the share. Remove two unneeded check_name() calls. They have already been done in order to get here. | ||||
* | s3: Slightly simplify the logic in defer_open | Volker Lendecke | 2011-12-14 | 1 | -5/+3 |
| | | | | | Doing 3 &&ed conditions in a single if-statement is easier to understand to me than continuing out separately. | ||||
* | s3: Remove UNUSED_SHARE_MODE_ENTRY | Volker Lendecke | 2011-12-14 | 1 | -2/+1 |
| | |||||
* | s3:smbd/open: use talloc_get_type_abort() as private_data can't be NULL | Stefan Metzmacher | 2011-12-14 | 1 | -5/+1 |
| | | | | metze | ||||
* | s3: Remove an else{} in remove_deferred_open_entry | Volker Lendecke | 2011-12-13 | 1 | -3/+3 |
| | |||||
* | s3:smbd/open: pass smbd_server_connection as private_data to ↵ | Stefan Metzmacher | 2011-12-13 | 1 | -3/+3 |
| | | | | | | msg_file_was_renamed() metze | ||||
* | s3: Use autogenerated open_files.idl | Volker Lendecke | 2011-12-02 | 1 | -0/+1 |
| | |||||
* | Move setting the inherited ACL into the main open code path. Next will | Jeremy Allison | 2011-11-22 | 1 | -1/+110 |
| | | | | remove it from the ACL modules. | ||||
* | Move the "set SD" code into provided SD and "inherit acls" branches. | Jeremy Allison | 2011-11-22 | 1 | -29/+32 |
| | |||||
* | Only add the SD if it's not a new stream file. | Jeremy Allison | 2011-11-22 | 1 | -1/+1 |
| | |||||
* | Move the add security descriptor code to *after* all the other meta-data is | Jeremy Allison | 2011-11-22 | 1 | -35/+35 |
| | | | | updated. We may be adding an SD that restricts our own access. | ||||
* | No longer do the pre-check on DELETE_ACCESS - we're correctly checking the ↵ | Jeremy Allison | 2011-11-04 | 1 | -22/+0 |
| | | | | ACL every time now. | ||||
* | Remove can_access_file_acl(). We no longer need this duplicate code (hurrah!). | Jeremy Allison | 2011-11-04 | 1 | -1/+3 |
| | |||||
* | Remove can_access_file_data() - make it use the standard ↵ | Jeremy Allison | 2011-11-04 | 1 | -2/+2 |
| | | | | smbd_check_access_rights() instead. | ||||
* | Add const to the smb_filename argument of smbd_check_access_rights(). | Jeremy Allison | 2011-11-04 | 1 | -2/+2 |
| | |||||
* | Expose smbd_check_access_rights() to other modules. | Jeremy Allison | 2011-11-04 | 1 | -1/+1 |
| | |||||
* | Rename smbd_check_open_rights() to smbd_check_access_rights() as we're going ↵ | Jeremy Allison | 2011-11-04 | 1 | -15/+15 |
| | | | | to remove the static from this. | ||||
* | Replace smb1_file_se_access_check() with just se_access_check(). | Jeremy Allison | 2011-11-04 | 1 | -30/+21 |
| | |||||
* | Move root check out of smb1_file_se_access_check() in preparation for ↵ | Jeremy Allison | 2011-11-04 | 1 | -13/+25 |
| | | | | deleting this function. | ||||
* | smb1_file_se_access_check() is now static to smbd/open.c | Jeremy Allison | 2011-11-04 | 1 | -1/+1 |
| | |||||
* | Revert "Change function signature of check_parent_access() to take char * ↵ | Jeremy Allison | 2011-11-04 | 1 | -6/+6 |
| | | | | | | | | instead of struct smb_filename." This reverts commit a11c0a41a35aa2b1c14333552045a65e3e50df1e. Not needed. | ||||
* | Change function signature of check_parent_access() to take char * instead of ↵ | Jeremy Allison | 2011-11-01 | 1 | -6/+6 |
| | | | | | | struct smb_filename. Expose it so it can be called from directory code. | ||||
* | Remove the order dependency in parent_override_delete(), just check for & ↵ | Jeremy Allison | 2011-10-28 | 1 | -2/+2 |
| | | | | not ==. | ||||
* | Remove unused "struct security_descriptor" parameter from check_parent_access() | Jeremy Allison | 2011-10-28 | 1 | -8/+2 |
| | |||||
* | Finally do all the open checks inside open_file(). Checks inside | Jeremy Allison | 2011-10-28 | 1 | -0/+30 |
| | | | | vfs_acl_common can now be removed. | ||||
* | Simplify smbd_check_open_rights() and move all the special casing inside it. | Jeremy Allison | 2011-10-28 | 1 | -101/+72 |
| | |||||
* | Move parent_override_delete() to before I need to use it. | Jeremy Allison | 2011-10-28 | 1 | -19/+19 |
| | |||||
* | Make smbd_check_open_rights() static. | Jeremy Allison | 2011-10-28 | 1 | -1/+1 |
| | |||||
* | Factor out the code checking if a parent should override DELETE_ACCESS into ↵ | Jeremy Allison | 2011-10-26 | 1 | -9/+31 |
| | | | | | | | a function. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Oct 26 23:15:05 CEST 2011 on sn-devel-104 | ||||
* | Remove another level of indentation - deal with !NT_STATUS_OK individually. | Jeremy Allison | 2011-10-26 | 1 | -65/+63 |
| | |||||
* | Add early return on stat open without O_CREAT if file doesn't exist. | Jeremy Allison | 2011-10-26 | 1 | -71/+74 |
| | | | | Reduces one level of indentation. | ||||
* | Refactor to create check_parent_access() which can be called for file ↵ | Jeremy Allison | 2011-10-20 | 1 | -23/+64 |
| | | | | | | | creation too. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Oct 20 20:29:22 CEST 2011 on sn-devel-104 | ||||
* | Make mkdir_internal() check the parent ACL for SEC_DIR_ADD_SUBDIR rights. | Jeremy Allison | 2011-10-20 | 1 | -2/+33 |
| | |||||
* | Fix error return to be NT_STATUS_NOT_A_DIRECTORY. | Jeremy Allison | 2011-10-20 | 1 | -2/+2 |
| |