summaryrefslogtreecommitdiffstats
path: root/source3/smbd/open.c
Commit message (Collapse)AuthorAgeFilesLines
* s3:smbd: change open.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam2012-06-151-4/+4
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: fix build on systems without O_NOFOLLOWBjörn Jacke2012-06-101-1/+1
|
* s3: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW ↵Björn Jacke2012-06-101-1/+20
| | | | | | | | | | | | | symlink open calls or should we leave the NetBSD and FreeBSD platforms just broken? Actually these two *want* to have broken platforms as they use different errno's than POSIX demands *interntionally*. The POSIX errno ELOOP for O_NOFOLLOW open calls on symlinks is clear and unambiguous. See http://gnats.netbsd.org/43154 for the interesting NetBSD discussion on that. Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Sun Jun 10 16:10:02 CEST 2012 on sn-devel-104
* s3:smbd: change set_file_oplock() to return NTSTATUSMichael Adam2012-06-081-1/+2
| | | | | | | | Pair-Programmed-With: Volker Lendecke <vl@samba.org> Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Jun 8 23:20:20 CEST 2012 on sn-devel-104
* s3: Replace an if with a boolean short circuitVolker Lendecke2012-06-081-5/+3
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Assigning ?True:False to a bool is a bit pointlessVolker Lendecke2012-06-081-3/+2
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3: Remove unnecessary ()Volker Lendecke2012-06-081-1/+1
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* s3:smbd: let fcb_or_dos_open() take a uint64_t vuidStefan Metzmacher2012-06-061-1/+1
| | | | metze
* s3:include: change files_struct->vuid to uint64_tStefan Metzmacher2012-06-061-2/+2
| | | | metze
* s3:smbd: fcb_or_dos_open() can be staticStefan Metzmacher2012-06-061-10/+10
| | | | metze
* Fix bug #8972 - Directory group write permission bit is set if unix ↵Jeremy Allison2012-06-051-2/+4
| | | | | | | | | | extensions are enabled We can't manipulate file_attributes if it's a posix call. I'll look at adding a test for this asap. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Jun 5 04:26:11 CEST 2012 on sn-devel-104
* s3:smbd/open: avoid procid_is_me()Stefan Metzmacher2012-06-031-4/+5
| | | | metze
* Ensure we only return NT_STATUS_DELETE_PENDING if the share modes are valid.Jeremy Allison2012-05-251-3/+20
| | | | | | Ensure we only return *file_existed = true if there were valid share modes. Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: Check for serverid_exists in find_oplock_typesVolker Lendecke2012-05-251-0/+18
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: Check for serverid_exists in open_mode_checkVolker Lendecke2012-05-251-0/+5
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3: Revert the serverid changes, they need more workVolker Lendecke2012-05-181-25/+0
| | | | | Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Fri May 18 13:12:14 CEST 2012 on sn-devel-104
* s3: Check for serverid_exists in find_oplock_typesVolker Lendecke2012-05-171-0/+20
| | | | Signed-off-by: Jeremy Allison <jra@samba.org>
* s3: Check for serverid_exists in open_mode_checkVolker Lendecke2012-05-171-0/+5
| | | | Signed-off-by: Jeremy Allison <jra@samba.org>
* s3: Remove an unused parameter from check_parent_access()Volker Lendecke2012-05-041-10/+3
|
* s3: In mkdir_internal, don't retrieve parent_dir from check_parent_accessVolker Lendecke2012-05-041-1/+1
| | | | We have already created that ourselves a few lines above
* s3: Fix a typoVolker Lendecke2012-05-041-1/+1
|
* s3: Remove a pointless else branchVolker Lendecke2012-02-191-2/+1
| | | | | Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Sun Feb 19 23:14:15 CET 2012 on sn-devel-104
* s3: get_share_mode_lock_fresh->get_share_mode_lockVolker Lendecke2012-02-191-9/+9
| | | | | | | get_share_mode_lock_fresh is just a confusing name Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Sun Feb 19 19:16:41 CET 2012 on sn-devel-104
* s3: get_share_mode_lock->get_existing_share_mode_lockVolker Lendecke2012-02-191-1/+2
|
* s3: files_struct->mode is only written, remove itVolker Lendecke2012-02-141-2/+0
| | | | | Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Tue Feb 14 19:14:29 CET 2012 on sn-devel-104
* s3: Simplify an if-statementVolker Lendecke2012-01-311-1/+1
| | | | | is_ntfs_default_stream_smb_fname already contains all checks that the variable "stream_name" gives us here.
* s3: Unify stream testing in open_directoryVolker Lendecke2012-01-311-9/+5
| | | | | | | | | | The second if-statement could never have kicked in, assuming the SMB_ASSERT above was right. Jeremy, please check! Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Jan 31 20:15:36 CET 2012 on sn-devel-104
* s3: Re-indent an && sequence for better understandingVolker Lendecke2012-01-311-2/+2
|
* Another fix for bug #8556 - ACL permissions ignored when SMBsetatr is requested.Richard Sharpe2012-01-231-0/+1
| | | | | Prevent systems with "store dos attributes = yes" from overriding FILE_WRITE_ATTRIBUITES.
* Revert "Fix bug #8175 - smbd deadlock."Volker Lendecke2012-01-181-68/+26
| | | | This reverts commit 5a2b5b6cfed74e0e9c2965525995f64cdad7b7c9.
* s3: Put an indirection layer into share_mode_lockVolker Lendecke2012-01-121-19/+19
| | | | Signed-off-by: Jeremy Allison <jra@samba.org>
* s3: Introduce get_share_mode_lock_fresh()Volker Lendecke2012-01-121-9/+6
| | | | | | | | This slightly simplifies the code path for all callers which assume that a share mode exists already. Only the callers in open_file_ntcreate and open_directory will ever create new share modes. Signed-off-by: Jeremy Allison <jra@samba.org>
* s3: Remove the unused "file_existed" parameter from smbd_calculate_access_maskVolker Lendecke2012-01-031-3/+2
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Jan 3 15:16:50 CET 2012 on sn-devel-104
* s3: Avoid "file_existed" in smbd_calculate_maximum_allowed_accessVolker Lendecke2012-01-031-36/+35
| | | | | We access the file by name anyway, so we can just try to access it. The file system will for sure tell us if the file does not exist.
* s3: Remove some else{} branches in smbd_calculate_maximum_allowed_accessVolker Lendecke2012-01-031-3/+7
|
* s3: Directly use *p_access_mask in smbd_calculate_maximum_allowed_accessVolker Lendecke2012-01-031-6/+4
|
* s3: Factor out smbd_calculate_maximum_allowed_accessVolker Lendecke2012-01-031-40/+59
|
* Allow an object to be deleted from a directory if the caller has ↵Jeremy Allison2011-12-201-1/+9
| | | | | | | | | | DELETE_CHILD access even if we don't have access to read the ACL on the object. Fixes bug #8673 - NT ACL issue. Different fix needed for 3.6.x. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Dec 20 22:13:51 CET 2011 on sn-devel-104
* check_name() not needed in mkdir.Jeremy Allison2011-12-171-5/+0
| | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Dec 17 02:44:55 CET 2011 on sn-devel-104
* Ensure VALID_STAT before accessing fields.Jeremy Allison2011-12-171-1/+3
|
* s3:smbd: avoid using sconn_server_id()Stefan Metzmacher2011-12-161-3/+3
| | | | metze
* s3: Add some const to find_oplock_typesVolker Lendecke2011-12-161-1/+1
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Dec 16 09:10:07 CET 2011 on sn-devel-104
* s3: Make open_file_ntcreate a bit easier to readVolker Lendecke2011-12-161-3/+2
| | | | Move the declaration of "id" closer to its use
* s3: Make open_file_ntcreate a bit easier to readVolker Lendecke2011-12-161-4/+6
| | | | Move the calculation of "new_file_created" closer to its use
* s3: Make open_file_ntcreate a bit easier to readVolker Lendecke2011-12-161-3/+3
| | | | Remove a negation where it's not necessary
* s3: Slightly simplify delay_for_exclusive_oplocksVolker Lendecke2011-12-161-9/+15
|
* s3: Slightly simplify delay_for_batch_oplocksVolker Lendecke2011-12-161-6/+6
|
* Third part of fix for bug #8663 - deleting a symlink fails if the symlink ↵Jeremy Allison2011-12-161-0/+8
| | | | | | | | | target is outside of the share. smbd_check_access_rights() - we can always delete a symlink. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Dec 16 03:32:15 CET 2011 on sn-devel-104
* First part of fix for bug #8663 - deleting a symlink fails if the symlink ↵Jeremy Allison2011-12-151-12/+0
| | | | | | | target is outside of the share. Remove two unneeded check_name() calls. They have already been done in order to get here.
* s3: Slightly simplify the logic in defer_openVolker Lendecke2011-12-141-5/+3
| | | | | Doing 3 &&ed conditions in a single if-statement is easier to understand to me than continuing out separately.