summaryrefslogtreecommitdiffstats
path: root/source3/lib
Commit message (Collapse)AuthorAgeFilesLines
* s3:sharesec: return an error if get_share_security() returns NULLStefan Metzmacher2011-07-061-1/+1
| | | | | | | | | | | | This indicates an error, as it uses get_share_security_default() if no security descriptor is configured. Jeremy, please check. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Jul 6 15:40:23 CEST 2011 on sn-devel-104
* s3:sharesec: also initialize pgranted if get_share_security() returns NULLStefan Metzmacher2011-07-061-0/+3
| | | | | | | metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Jul 6 12:54:30 CEST 2011 on sn-devel-104
* s3: Follow the TALLOC_FREE convention in source3Volker Lendecke2011-07-061-1/+1
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Jul 6 11:01:05 CEST 2011 on sn-devel-104
* s3: Fix Coverity ID 2586 -- NO_EFFECTVolker Lendecke2011-07-061-1/+1
| | | | | | | tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is unsigned. So (len < 0) could never have turned true. Volker
* s3:lib fix non-empty blank linesChristian Ambach2011-07-051-3/+3
|
* s3: Return "granted" from share_access_checkVolker Lendecke2011-07-051-2/+8
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3-lib Move event_add_idle() to source3/lib/events.cAndrew Bartlett2011-07-041-1/+81
| | | | | | This allows libauth not to depend on smbd_base. Andrew Bartlett
* s3-util: Add a get_remote_hostname() function.Andreas Schneider2011-07-041-0/+108
| | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* s3: Make cli_cm_open return NTSTATUSVolker Lendecke2011-07-031-7/+10
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Jul 3 23:57:53 CEST 2011 on sn-devel-104
* param: Finish conversion from lp_wins_support() -> lp_we_are_a_wins_server()Andrew Bartlett2011-07-021-4/+4
| | | | | | | | | Jermey started this in 1997 with 0aa493cc0303aa4177f289b9e4c797c8fa180672 (avoiding the duplicate function makes it easier to generate the struct loadparm_globals). Andrew Bartlett
* s3:smbldap: make smbldap_connect_system self containedGregor Beck2011-07-011-6/+11
| | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Jul 1 12:37:50 CEST 2011 on sn-devel-104
* s3:smbldap: add a destructor to smbldap_state, just in caseGregor Beck2011-07-011-0/+7
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:smbldap: let smbldap_free_struct do what it claims toGregor Beck2011-07-011-2/+1
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:smbldap: free the idle event scheduled in smbldap_open in smbldap_closeGregor Beck2011-07-011-1/+2
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:smbldap: use smbldap_state as memory context for idle eventGregor Beck2011-07-011-2/+2
| | | | | | | ensure the event is canceled if the smbldap_state gets freed this fixes a panic of winbindd if verify_idpool fails Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s3:g_lock: g_lock.tdb should not be executableChristian Ambach2011-06-271-1/+2
| | | | | | | | TDBs are not executable, so do not create the file with the execution bit set Autobuild-User: Christian Ambach <ambi@samba.org> Autobuild-Date: Mon Jun 27 17:09:12 CEST 2011 on sn-devel-104
* s3-param Remove %(DomainSID) supportAndrew Bartlett2011-06-241-102/+0
| | | | | | | | | | | | | | | This also removes the now unused longvar support. This experiment never took off. Fixing this allows me to resolve the the library loop between libsmbconf and SECRETS3/passdb. Andreas correctly points out that this loop originally comes from my patch to obtain the domain sid from passdb (25cfa29e29bdbb6c84bd85ea02ec542228ae585f), but as I would prefer to keep that feature, I'm hoping to break the loop here instead. Andrew Bartlett
* s3-param Remove 'announce version' parameterAndrew Bartlett2011-06-231-2/+2
| | | | | | | | The only users I can find of this on the internet involve confused users, and our own documentation recommends never setting this. Don't confuse our users any longer. Andrew Bartlett
* s3-smbd: longer explanation of smbd_shim codeAndrew Tridgell2011-06-211-2/+7
| | | | | | | Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Tue Jun 21 09:05:37 CEST 2011 on sn-devel-104
* s3-build: Provide a run-time shim to work around duplicate symbolsAndrew Bartlett2011-06-213-35/+97
| | | | | | | | | | | | | | | | The become_root() and similar 'smbd' functions that are used widely in Samba libraries had 'dummy' copies in dummysmbd.c and dummyroot.c. These have been replaced by a runtime plugin mechanim, which ensures that standlone binaries still do nothing, while in smbd the correct function is used. This avoids having these as duplicate symbols in the smbd binary, which can cause unpredictable behaviour. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util: Use common d_printf() in the whole codebaseAndrew Bartlett2011-06-211-128/+0
| | | | | | | | | This removes the lang_tdb based varient, the only user of the lang_tdb code is SWAT, which calls that directly. 'net' and 'pam_winbind' are internationalised using gettext. Andrew Bartlett
* lib/util Make unused d_vfprintf() staticAndrew Bartlett2011-06-211-1/+1
|
* Use tevent_req_oomVolker Lendecke2011-06-202-3/+3
| | | | This fixes a few Coverity errors
* source3/lib/util_tdb.c: operation timeout support for TDB2.Rusty Russell2011-06-201-0/+96
| | | | | | | | | | | TDB2 doesn't have (the racy) signal pointer; the new method is to override the locking callbacks and do the timeout internally. The technique here is to invalidate the struct flock when the timeout occurs, so it works even if it happens before we enter the fcntl() call. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_compat: Higher level API fixes.Rusty Russell2011-06-208-11/+11
| | | | | | | | | | | | My previous patches fixed up all direct TDB callers, but there are a few utility functions and the db_context functions which are still using the old -1 / 0 return codes. It's clearer to fix up all the callers of these too, so everywhere is consistent: non-zero means an error. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_compat: use tdb_open_compat.Rusty Russell2011-06-201-6/+11
| | | | | | | | | This is a helper for the common case of opening a tdb with a logging function, but it doesn't do all the work, since TDB1 and TDB2's log functions are different types. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb2: tdb_parse_record() returns negative errors, not -1.Rusty Russell2011-06-202-3/+3
| | | | | | | Fixup callers to tdb_parse_record() to be compatible with tdb2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_validate: TDB2 support for tdb_validate_child and tdb_backup.Rusty Russell2011-06-201-2/+10
| | | | | | | We don't expose freelist or hash size for TDB2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb2: #ifdef out TDB_ERR_NOLOCK and TDB_ERR_LOCK_TIMEOUT.Rusty Russell2011-06-202-1/+10
| | | | | | | | These don't exist in tdb2. The former is used in one weird place in tdb1, and the latter not at all. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_compat: use tdb_errorstr_compat()Rusty Russell2011-06-201-6/+6
| | | | | | | | Since TDB2 functions return the error directly, tdb_errorstr() taken an error code, not the tdb as it does in TDB1. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_traverse/tdb_traverse_read: check returns for negative, not -1.Rusty Russell2011-06-203-4/+4
| | | | | | | | | | | TDB2 returns a negative error number on failure. This is compatible if we always check for < 0 instead of == -1. Also, there's no tdb_traverse_read in TDB2: we don't try to make traverse reliable any more, so there are no write locks anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_chainunlock: ignore return value.Rusty Russell2011-06-202-8/+2
| | | | | | | | | TDB2 returns void here. tdb_chainunlock will *always* return with the chain unlocked, but it will complain via the log function if it wasn't locked. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_chainlock: check returns for 0, not -1.Rusty Russell2011-06-202-3/+3
| | | | | | | | TDB2 returns a negative error number on failure. This is compatible if we always check for != 0 instead of == -1. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_transaction_cancel: ignore return value.Rusty Russell2011-06-203-18/+9
| | | | | | | | | TDB2 returns void here. tdb_transaction_cancel will *always* return with the transaction cancelled, but it will complain via the log function if a transaction wasn't in progress. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_transaction_commit: check returns for 0, not -1.Rusty Russell2011-06-202-5/+5
| | | | | | | | TDB2 returns a negative error number on failure. This is compatible if we always check for != 0 instead of == -1. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_store: check returns for 0, not -1.Rusty Russell2011-06-201-2/+2
| | | | | | | | TDB2 returns a negative error number on failure. This is compatible if we always check for != 0 instead of == -1. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_delete: check returns for 0, not -1.Rusty Russell2011-06-201-3/+3
| | | | | | | | TDB2 returns a negative error number on failure. This is compatible if we always check for != 0 instead of == -1. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_fetch_compat: use instead of tdb_fetch.Rusty Russell2011-06-204-9/+9
| | | | | | | This is a noop for tdb1. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb_compat.h: divert every tdb build and includes to tdb_compatRusty Russell2011-06-202-2/+2
| | | | | | | | We change all the headers and wscript files to use tdb_compat; this means we have one place to decide whether to use TDB1 or TDB2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* source3/lib/util.c: str_checksum to use Jenkins hash from CCAN.Rusty Russell2011-06-201-2/+4
| | | | | Rather than tdb's internal one.
* errors: reorder error codes for easier s3/s4 comparisonAndrew Bartlett2011-06-171-11/+11
|
* s3: Add wins_server_tag_ips()Volker Lendecke2011-06-121-0/+42
| | | | For a given tag, return the list of all wins servers
* source3/lib/privileges.h: fix licence/copyrightGünther Deschner2011-06-101-0/+27
| | | | Guenther
* source3/lib/netapi/libnetapi.h: fix licence/copyrightGünther Deschner2011-06-101-0/+19
| | | | Guenther
* Export init_stat_ex_from_stat for use in VFS modules.Richard Sharpe2011-06-101-6/+6
| | | | | | | Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Jun 10 13:23:37 CEST 2011 on sn-devel-104
* s3:lib/util: use %llu consitently (instead of %d) in interpret_pid() to ↵Stefan Metzmacher2011-06-091-1/+1
| | | | | | parse the pid metze
* s3-param Remove special case for global_myname(), rename to lp_netbios_name()Andrew Bartlett2011-06-096-46/+12
| | | | | | | | There is no reason this can't be a normal constant string in the loadparm system, now that we have lp_set_cmdline() to handle overrides correctly. Andrew Bartlett
* s3-lib Add myhostname_upper()Andrew Bartlett2011-06-091-0/+16
| | | | | | | This varient always upper cases the hostname, which is needed for the netbios name. Andrew Bartlett
* server_id: Change format to vnn:pid.task_id, pid.task_id or pidAndrew Bartlett2011-06-091-4/+14
| | | | | | | | | | | This helps ensure the string cannot be ambiguous, while also ensuring that it remains simple in the non-cluster case. The asymmetry of reading get_my_vnn() but writing based on NONCLUSTER_VNN is acceptable because in the non-clustered case, they are equal, and in the clustered case we will print the full string. Andrew Bartlett
* s3-param Remove special case for global_scope()Andrew Bartlett2011-06-092-28/+1
| | | | | | | There is no reason this can't be a normal constant string in the loadparm system. (Past reasons were that we didn't have lp_set_cmdline()) Andrew Bartlett