summaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* tdb: Slightly simplify transaction_writeVolker Lendecke2013-02-191-8/+2
| | | | | | | | | | | | realloc(NULL, ...) is equivalent to malloc. We are already using this realloc property for tdb->lockrecs. It should not make any difference in speed, it just makes for a little simpler code. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Feb 19 17:30:13 CET 2013 on sn-devel-104
* tdb: Make tdb_release_transaction_locks use tdb_allrecord_unlockVolker Lendecke2013-02-191-1/+1
| | | | | | | | The transaction code uses tdb_alrecord_lock/upgrade, so it should also use the tdb_allrecord_unlock function just for symmetry reasons Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tdb: Don't segfault if tdb_open_ex for check failedVolker Lendecke2013-02-191-0/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tdb: Factor out the retry loop from tdb_allrecord_upgradeVolker Lendecke2013-02-191-20/+39
| | | | | | | | | For the mutex code we will have to lock the hashchain and the record lock area independently. So we will have to call the loop twice. And, it's a small refactoring for the better anyway I think. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tdb: Simplify fcntl_lock() a bitVolker Lendecke2013-02-191-4/+4
| | | | | | | | All arguments but the cmd are the same. To me this looks a bit better and saves some bytes in the object code. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tdb: Use tdb_null in freelistcheckVolker Lendecke2013-02-191-3/+2
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tdb: Enhance lock tracking a bitVolker Lendecke2013-02-191-0/+11
| | | | | | | | | | | | | | | lock-tracking.c mirrors the in-kernel fcntl structures to detect unexpected use of fcntl calls. During my mutex work I changed our fcntl use so that we unlock the allrecord_lock in two pieces: The range covering the hash locks and the range covering the data area for the individual traverse record locks. Splitting locks is not covered by lock-tracking.c. This patch extends lock-tracking.c with this little piece. It's still far from complete to track the full range of fcntl semantics. It is not strictly needed right now, but it does not hurt either. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* lib/util/time: strip a potential trailing newline in the asctime case.Michael Adam2013-02-191-0/+9
| | | | | | | | | If strftime() is not available, asctime() is used, and this usually appends a newline character to the result. This is not desired for timestamp(). Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* lib/util_tdb: factor out tdb_data_talloc_copy()Gregor Beck2013-02-192-0/+16
| | | | | | Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* fault.c: Fix typo in comment.Karolin Seeger2013-02-181-1/+1
| | | | | | redundent -> redundant Signed-off-by: Karolin Seeger <kseeger@samba.org>
* tdb: Fix a typoVolker Lendecke2013-02-161-1/+1
| | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Simo Sorce <idra@samba.org> Autobuild-Date(master): Sat Feb 16 17:13:32 CET 2013 on sn-devel-104
* tevent: Remove the previous "standard" tevent backend implementation.Jeremy Allison2013-02-141-556/+1
| | | | | | | | | | | This was a horrible hybrid of duplicated epoll and select() code. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Feb 14 22:40:30 CET 2013 on sn-devel-104
* tevent: Add in the new implementation of "standard" tevent backend.Jeremy Allison2013-02-141-6/+180
| | | | | | | | | Falls back cleanly from epoll -> poll, or uses poll if epoll not available. Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: Add a private function tevent_poll_event_add_fd_internal().Jeremy Allison2013-02-142-0/+19
| | | | | | | | Not yet used, but will be called by the "standard" fallback from epoll -> poll backends. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: make use of tevent_find_ops_byname() in tevent_context_init_byname()Stefan Metzmacher2013-02-141-14/+5
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* tevent: make sure tevent_backend_init() only runs onceStefan Metzmacher2013-02-141-0/+8
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* tevent: Add a utility function tevent_find_ops_byname().Jeremy Allison2013-02-142-0/+23
| | | | | | | | | Returns an event ops struct given a string name. Not yet used, but will be part of the new "standard" fallback code. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: Add in the same tevent_re_initialise() fix Metze put in the ↵Jeremy Allison2013-02-143-0/+18
| | | | | | | | | | tevent_poll backend. We might be called during tevent_re_initialise() which means we need to free our old additional_data. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: Add in some test code to allow the panic fallback path to be tested.Jeremy Allison2013-02-141-0/+18
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: Plumb in the panic fallback code into the epoll_panic() runtime call.Jeremy Allison2013-02-141-3/+20
| | | | | Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: Add an internal function tevent_epoll_set_panic_fallback().Jeremy Allison2013-02-142-0/+27
| | | | | | | | Can be set externally, allows us to fallback if epoll fails at runtime. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: pass 'bool replay' to epoll_panic()Stefan Metzmacher2013-02-141-5/+6
| | | | | | | | | A fallback panic handler will need to know if there was an error while waiting for events (replay=true) or if the error happened on modify (replay=false). Signed-off-by: Stefan Metzmacher <metze@samba.org>
* tevent: Ensure we return after every call to epoll_panic().Jeremy Allison2013-02-141-0/+2
| | | | | | | | Currently we can't return from this, but the new fallback code will change this. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tevent: Preparing to fix "standard" backend fallback. Initialize standard ↵Jeremy Allison2013-02-141-1/+1
| | | | | | | after epoll. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* dbwrap: Prevent transactions on non-persistent dbsVolker Lendecke2013-02-081-0/+5
| | | | | | | | | dbwrap_ctdb does not allow this anyway. This patch will avoid suprises when going non-clustered to clustered. Not everybody is developing against a clustered environment :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* ldb: Add more data test data for one level test casesMatthieu Patou2013-02-081-0/+14
| | | | | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Feb 8 06:46:40 CET 2013 on sn-devel-104
* ldb: Add tests for the python apiMatthieu Patou2013-02-081-0/+8
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb: Add more tests related to onelevel searchMatthieu Patou2013-02-082-0/+14
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb: use strncmp instead of strcmp when comparing the val partMatthieu Patou2013-02-081-2/+2
| | | | | | | val part of a DN's component is DATA_BLOB and nothing insure that it will be finished by a '\0' Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb: make test output more readableMatthieu Patou2013-02-081-4/+2
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb-tdb: Document ltdb_index_add1 for more clarityMatthieu Patou2013-02-081-3/+20
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb-tdb: Fix a wrong parameter in ltdb_storeMatthieu Patou2013-02-081-1/+2
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldb_tdb: raise level of full index scan message so that it starts to be ↵Matthieu Patou2013-02-081-1/+1
| | | | | | | | | really visible We don't want to have to set log level to 4 or 5 AND set the environment variable to be able to see those log messages Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3:param: remove unused function lp_idmap_backend()Michael Adam2013-02-052-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
* tdb: Remove "header" from tdb_contextVolker Lendecke2013-02-0513-59/+64
| | | | | | | | | | | | header.hash_size was the only thing we ever referenced outside of tdb_open_ex and its direct callees. So this shrinks the tdb_context by 164 bytes. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Feb 5 13:18:28 CET 2013 on sn-devel-104
* tdb: Pass argument "header" to check_header_hashVolker Lendecke2013-02-051-4/+6
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tdb: Pass argument "header" to tdb_new_databaseVolker Lendecke2013-02-051-6/+8
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* lib/dbwrap: talloc_strdup() name in db_open_file()Stefan Metzmacher2013-02-041-1/+6
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* lib/util: improve check_password_quality() to handle utf8Stefan Metzmacher2013-02-042-19/+120
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* tevent_poll: add poll_event_loop_wait()Stefan Metzmacher2013-02-031-2/+31
| | | | | | | | | | | | | We can't use tevent_common_loop_wait() because new fd events will be added to the poll_ev->fresh list instead of ev->fd_events. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sun Feb 3 06:40:09 CET 2013 on sn-devel-104
* tevent_poll: fix the usage of tevent_re_initialise()Stefan Metzmacher2013-02-021-0/+8
| | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent_poll: call tevent_common_fd_destructor() from poll_fresh_fde_destructor()Stefan Metzmacher2013-02-021-2/+3
| | | | | | | | We need to trigger the fde->close_fn(). Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent_poll: Avoid a crash in poll_event_set_fd_flagsVolker Lendecke2013-02-021-2/+8
| | | | | | | | The event context might have been freed before the fde Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent_poll: Avoid a crash in poll_fresh_fde_destructorVolker Lendecke2013-02-021-2/+9
| | | | | | | | The event context might have been freed before the fde Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent_poll: NULL out fde->event_ctx for "fresh" poll fdesVolker Lendecke2013-02-021-0/+8
| | | | | | | | | This is done in tevent_common_context_destructor for the non-fresh fdes already Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent_poll: Use the poll_event_context_destructor alwaysVolker Lendecke2013-02-021-5/+12
| | | | | | | | | This is in preparation for the next patch to NULL out the event_ctx pointers in the poll_ev->fresh list Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent_poll: Re-order routinesVolker Lendecke2013-02-021-16/+16
| | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent_poll: Fix a crash in the poll backendVolker Lendecke2013-02-021-4/+15
| | | | | | | | | | If tevent_add_fd is immediately followed by tevent_fd_set_flags, the poll backend crashes. This was introduced when the poll backend was prepared for the multi-threaded python extension. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tevent: Fix a comment typoVolker Lendecke2013-01-311-1/+1
| | | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Autobuild-User(master): Richard Sharpe <sharpe@samba.org> Autobuild-Date(master): Thu Jan 31 17:52:39 CET 2013 on sn-devel-104
* ldb: Ensure to decrement the transaction_active whenever we delete a transactionAndrew Bartlett2013-01-264-1/+266
| | | | | | | | | | | | | | | | | This is in the error path for prepare_commit, which rarely fails, but when it does we need to ensure that when a new transaction is opened, that it really starts a new transaction. We bump the version to recognise critical fix for the AD DC Without this fix, a single invalid inbound replicated link disables all subsequent replication as we operate without a transaction (which is refused by ldb_tdb). Andrew Bartlett Reviewed-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
generated by cgit (git 2.34.1) at 2025-10-04 14:48:46 +0000