summaryrefslogtreecommitdiffstats
path: root/ctdb/server/eventscript.c
Commit message (Collapse)AuthorAgeFilesLines
...
| | * Merge commit 'martins-svart/status-test-2' into status-testMartin Schwenke2009-11-271-0/+1
| | |\ | | | | | | | | | | | | (This used to be ctdb commit 0e6c06ac38fd82adf124d111717502055501974a)
| | | * Event script infrastructure: add reload event to check_options().Martin Schwenke2009-11-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> (This used to be ctdb commit c278c798d41a35f58ca81f8f0e08e4dab51eba9b)
| * | | Merge commit 'martins/status-test' into status-test-2Ronnie Sahlberg2009-11-261-14/+23
| |\| | | | | | | | | | | | | | (This used to be ctdb commit 28d0648725e7de4e4d0e8569e3fbfb0fa1d7f934)
| | * | Merge commit 'martins-svart/status-test-2' into status-testMartin Schwenke2009-11-261-14/+23
| | |\| | | | | | | | | | | | | (This used to be ctdb commit 143f1fa3cc4588505e3992c601153ea08be8432d)
| | | * Add flag to ctdb_event_script_callback indicating when called by client.Martin Schwenke2009-11-261-14/+23
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> (This used to be ctdb commit a1d654a982ca56fade82552f4e6b5586236d3233)
| * | | resolve some conflicts from merging from martins branchRonnie Sahlberg2009-11-261-26/+0
| |/ / | | | | | | | | | (This used to be ctdb commit d3e7407dc9854ec358d081777c5450ec68b17862)
| * | Merge commit 'martins-svart/status-test-2' into status-testMartin Schwenke2009-11-261-0/+22
| |\| | | | | | | | | | | | | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> (This used to be ctdb commit a2830594ebeb54eb51ff90999cb12370aeec6e8b)
| | * eventscript: check that ctdb forced script events correctRusty Russell2009-11-251-5/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we're doing checking, we might as well make sure the commands from "ctdb eventscripts" are valid. This gets rid of the "UNKNOWN" event type. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 1d24a3869fe89fc9a109fd9e9b69df5fc665a5f6)
| | * eventscript: check that internal script events are being invoked correctlyRusty Russell2009-11-241-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not as good as a compile-time check, but at least we count the number of arguments are correct. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 83b7b233cb4707e826f6ba260bd630c8bc8f1e76)
| | * eventscript: remove call name from state->optionsRusty Russell2009-11-241-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Finally, we remove the call name (eg. "monitor" or "start") from the options field of the struct: it now contains only extra options. This is clearer, and mainly involves adding some %s to debug statements. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 33fb0e7ba047ca73969b59bccf70a04a17c25a0a)
| | * eventscript: put call type into state struct.Rusty Russell2009-11-241-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This means we can get rid of more strcmp; they can simply use the state->call value instead. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 6c79fa33e26cc4f0873577f8e122b1495b4c427e)
| | * eventscript: introduce enum for different event script calls.Rusty Russell2009-11-241-9/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than doing strcmp everywhere, pass an explicit enum around. This also subtly documents what options are available. The "options" arg is now used for extra arguments only. Unfortunately, gcc complains on empty format strings, so we make ctdb_event_script() take no varargs, and add ctdb_event_script_args(). We leave ctdb_event_script_callback() taking varargs, which means callers have to do "%s", "". For the moment, we have CTDB_EVENT_UNKNOWN for handling forced scripts from the ctdb tool. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 8001488be4f2beb25e943fe01b2afc2e8779930d)
| | * eventscript: put timeout inside ctdb_event_script_callback_vRusty Russell2009-11-241-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Everyone uses the same timeout value, so just remove it from the API. If we ever need variable timeouts, that might as well be central too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 533c3e053293941d2a9484b495e78d45f478bb08)
| | * eventscript: cleanup ctdb_event_script_vRusty Russell2009-11-241-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ctdb_event_script_v doesn't take varargs. ctdb_run_event_script is a better name, and fix comment. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 466beafadb37011fe273de8810ab0012e92a1fd8)
| | * eventscript: fix bug in timeouts on forced eventscripts. Again.Rusty Russell2009-11-241-40/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 15bc66ae801b0c69, Ronnie fixed a double-free race. The problem was that ctdb_run_eventscripts() hands a context to ctdb_event_script_callback() to hang its data off, which gets freed in the callback. This particularly hurt in ctdb_event_script_timeout. There's nothing wrong with this, but obviously we should make the callback call last of all. At the time, ctdb_event_script_timeout() carefully extracted everything from the struct ctdb_event_script_state before calling ->callback. This was cleaned up in 64da4402c6ad485f (Ronnie again), and now state was referred to after the callback again. But the same change introduced a direct use-after-free bug which caused an occasional oops. So in our last episode (eda052101728cf92) Volker fixed this, and Michael committed it. But we still have the double free bug which 15bc66ae801b0c69 was supposed to fix! Let's try to fix this in a more permanent way, but always doing the callback from the destructor. This means we need to hold the status, and don't send the KILL signal if ->child is set to 0. Finally, add a comment about freeing ourselves in run_eventscripts_callback and the structure definition. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit b90bdb07c1f6913ddbf11bde9684bdc8af61c549)
| | * eventscript: clean up forked handler event codeRusty Russell2009-11-241-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Write the whole int through the pipe, rather than quietly cutting it off. Also, use -2 as the result if the read fails; -1 comes from many paths if the child fails before running the script. Add a comment about why we don't need to check the write. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 6804f880436645b52c09a78fa300377fa8058d0e)
| | * rework and simplify the eventscript handlingRonnie Sahlberg2009-11-251-149/+101
| | | | | | | | | | | | | | | | | | | | | This version has no trailing whitespace, and fixed (This used to be ctdb commit defbe318152fc479e8076ad70433cdb4971951af)
| * | eventscript: check that ctdb forced script events correctRusty Russell2009-11-241-5/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we're doing checking, we might as well make sure the commands from "ctdb eventscripts" are valid. This gets rid of the "UNKNOWN" event type. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 66b22980b14601f29fe8cc64bd8f29883c7ca1c0)
| * | eventscript: check that internal script events are being invoked correctlyRusty Russell2009-11-241-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not as good as a compile-time check, but at least we count the number of arguments are correct. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit a6d353519932eee48f9241ad8887b692882906c9)
| * | eventscript: remove call name from state->optionsRusty Russell2009-11-241-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Finally, we remove the call name (eg. "monitor" or "start") from the options field of the struct: it now contains only extra options. This is clearer, and mainly involves adding some %s to debug statements. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit b0648c7f08eba87ec3c9714e2525c9b621bfb4ef)
| * | eventscript: put call type into state struct.Rusty Russell2009-11-241-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This means we can get rid of more strcmp; they can simply use the state->call value instead. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 834c93b3e1b8f4151b8a2cd82c2dd8bacc17f66c)
| * | eventscript: introduce enum for different event script calls.Rusty Russell2009-11-241-9/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than doing strcmp everywhere, pass an explicit enum around. This also subtly documents what options are available. The "options" arg is now used for extra arguments only. Unfortunately, gcc complains on empty format strings, so we make ctdb_event_script() take no varargs, and add ctdb_event_script_args(). We leave ctdb_event_script_callback() taking varargs, which means callers have to do "%s", "". For the moment, we have CTDB_EVENT_UNKNOWN for handling forced scripts from the ctdb tool. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 470822b329f9d3ca9bef518b56e9ce28d5fedda2)
| * | eventscript: put timeout inside ctdb_event_script_callback_vRusty Russell2009-11-241-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Everyone uses the same timeout value, so just remove it from the API. If we ever need variable timeouts, that might as well be central too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit fe8027309c1f7b987cd368fa98f9b28741baa786)
| * | eventscript: typo cleanupsRusty Russell2009-11-241-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1) ctdb_event_script_v doesn't take varargs. ctdb_run_event_script is a better name, and fix comment. 2) Fix indentation on allowed_scripts. 3) Comment on run_eventscripts_callback is wrong; it's the callback for any ctdb forced event. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit e7d57d7ae678b24dab3364a348838c6a3398942c)
| * | eventscript: fix bug in timeouts on forced eventscripts. Again.Rusty Russell2009-11-241-40/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 15bc66ae801b0c69, Ronnie fixed a double-free race. The problem was that ctdb_run_eventscripts() hands a context to ctdb_event_script_callback() to hang its data off, which gets freed in the callback. This particularly hurt in ctdb_event_script_timeout. There's nothing wrong with this, but obviously we should make the callback call last of all. At the time, ctdb_event_script_timeout() carefully extracted everything from the struct ctdb_event_script_state before calling ->callback. This was cleaned up in 64da4402c6ad485f (Ronnie again), and now state was referred to after the callback again. But the same change introduced a direct use-after-free bug which caused an occasional oops. So in our last episode (eda052101728cf92) Volker fixed this, and Michael committed it. But we still have the double free bug which 15bc66ae801b0c69 was supposed to fix! Let's try to fix this in a more permanent way, but always doing the callback from the destructor. This means we need to hold the status, and don't send the KILL signal if ->child is set to 0. Finally, add a comment about freeing ourselves in run_eventscripts_callback and the structure definition. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 20b15de068d042b292725945927ceda1b01d07c0)
| * | eventscript: clean up forked handler event codeRusty Russell2009-11-241-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Write the whole int through the pipe, rather than quietly cutting it off. Also, use -2 as the result if the read fails; -1 comes from many paths if the child fails before running the script. Add a comment about why we don't need to check the write. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit c715746c2f40eb9b21dbf011d16f1f1b0b53fdf9)
| * | rework and simplify the eventscript handlingRonnie Sahlberg2009-11-241-149/+102
| |/ | | | | | | (This used to be ctdb commit c5f798116bf3b7954e23c7267b056ee1f5560f45)
| * test of a change to make ctdbd use "status" event instead of the "monitor" ↵Ronnie Sahlberg2009-11-131-4/+15
| | | | | | | | | | | | | | | | | | event. This allows running the actual monitoring asynchronously from ctdbd and only using "status" to pick up the actual results. (This used to be ctdb commit 1908bac812650ca25151051f5d86815e0b8ed319)
* | dont reset the event script context everytime we start a new "ctdb ↵Ronnie Sahlberg2009-11-191-7/+4
|/ | | | | | | | | | | eventscript ..." command. Use the existing context used for non-monitor events Multiple concurrent uses of "ctdb eventscript ..." could otherwise lead to a SEGV (This used to be ctdb commit 80a8d728e9680040e00d24361dfc9367dd372a56)
* Fix a segfault in the eventscript timeout handler.Volker Lendecke2009-11-051-1/+1
| | | | | | | | The state was freed too early. Signed-off-by: Michael Adam <obnox@samba.org> (This used to be ctdb commit eda052101728cf922ce892e3c53b4f37e7ceac42)
* create a separate context for non-monitor eventscripts so they dont collideRonnie Sahlberg2009-10-281-10/+21
| | | | (This used to be ctdb commit 325de818f88f339a16dc4544e899a2d735933c44)
* return 0 in the event script callback if it was aborted by a different scriptRonnie Sahlberg2009-10-281-1/+1
| | | | (This used to be ctdb commit 8d5cb2586a1d5a0255cc18295430927b914d4527)
* change the eventscript handling to allow EventScriptTimeout for each ↵Ronnie Sahlberg2009-10-281-67/+111
| | | | | | | | individual script isntead of for the entire set of scripts restructure the talloc hierarchy to allow this (This used to be ctdb commit 64da4402c6ad485f1d0a604878a7b0c01a0ea5f0)
* Enhance the logging fromeventscripts.Ronnie Sahlberg2009-10-281-3/+4
| | | | | | | | When a single script is finished, also log the name of the script, the duration it took and the return status. In the loop where we signal back to the main daemon that the script finished, do this once every 100ms instead of once every 1 second (This used to be ctdb commit 6a1f7a7b1b3a0b8f89998db8fdad83bbb4e9b5a5)
* dont run the monitor event so frequently after a event has failed.Ronnie Sahlberg2009-10-271-1/+1
| | | | | | use _exit() instead of exit() when terminating an eventscript. (This used to be ctdb commit cc30ee2f4f33cb75b2be980c2d4dff6c7c23852f)
* when scripts timeout, log pstree to a file in /tmp and just log the filename ↵Ronnie Sahlberg2009-10-231-26/+10
| | | | | | in the messages file (This used to be ctdb commit 0785afba8e5cd501b9e0ecb4a6a44edf43b57ab0)
* From Volker LRonnie Sahlberg2009-10-221-1/+1
| | | | | | Fix some warnings and an incorrect check for a talloc failure (This used to be ctdb commit 27296a47b3d057a6729287acf128b2b67775ecde)
* During tests it is common to add/delete test eventscripts at runtime.Ronnie Sahlberg2009-10-211-0/+5
| | | | | | | | | | This can race with teh eventascript handling that does a : list all scripts, sort them, then execute them so trap status code 127 which means the script could not be executed (or /bin/sh does not exist) and treat it as not to cause the node to become unhealthy (This used to be ctdb commit befabc917edb036ca81f5216f65a6d62b26ee83e)
* lower the debug levels for the "create FD messages" so we dont fill up the logs.Ronnie Sahlberg2009-10-211-1/+1
| | | | (This used to be ctdb commit 87146db2769c2ec494813685bf9cec0d2a6336c3)
* From wolfgang MuellerRonnie Sahlberg2009-10-201-4/+9
| | | | | | Add a tuneable so that when scripts starts to hang/timeout, we can make the node unhealthy instead of banned (This used to be ctdb commit 2e9fc6f0609833c6d8146196011ef780669d615d)
* add logging everytime we create a filedescriptor in the main ctdb daemonRonnie Sahlberg2009-10-151-0/+2
| | | | | | | | | so we can spot if there are leaks. plug two leaks for filedescriptors related to when sending ARP fail and one leak when we can not parse the local address during tcp connection establish (This used to be ctdb commit ddd089810a14efe4be6e1ff3eccaa604e4913c9e)
* add more debugging output to eventscripts and when a script has timed out,Ronnie Sahlberg2009-10-141-4/+45
| | | | | | | | | | | | print a full "pstree -p" to the log. Example : |-ctdbd(29826)-+-ctdbd(29862) | `-ctdbd(31897)-+-00.ctdb(31898)---sleep(31908) change the default timeout to 60 seconds for eventscripts (This used to be ctdb commit a3406c10d70f89d332eab25d481083142dff987d)
* Fix bug spotted by Metze,Ronnie Sahlberg2009-10-091-3/+3
| | | | | | the argument to ctdb_control_event_Script_disabled() is a string not a uint32 (This used to be ctdb commit 687535b51622d1fac7ccb38fa640bf1febd69fd8)
* we should close this file on execRonnie Sahlberg2009-10-021-0/+1
| | | | (This used to be ctdb commit c1c0ebb8da9a6c29ee83868a311f07f30cb4ed16)
* dont force an election just because the ban flag differs across the cluster.Ronnie Sahlberg2009-09-091-1/+7
| | | | | | a simple push to resync this flag is sufficient (This used to be ctdb commit 8903b858ddd3a016d9cf765187839814443a67ca)
* new prototype banning codeRonnie Sahlberg2009-09-041-11/+6
| | | | (This used to be ctdb commit 0c4c2240267af183d54ffd4c0aacda208f6eff6a)
* add new controls to make it possible to enable/disable individual eventscriptsRonnie Sahlberg2009-08-131-77/+305
| | | | | | update scriptstatus output so it lists disabled scripts (This used to be ctdb commit 7e799b7523c9699bd65a8a8207f7e03d668b0b81)
* create a new event : stopped.Ronnie Sahlberg2009-07-171-1/+1
| | | | | | | | This event is called when a node is stopped and is used by eventscripts that need to do certain cleanup and removal of configuration or ip addresses or routing ... Note that a STOPPED node is considered "inactive" and as such will not be running the "recovered" event when the rest of the cluster has recovered. (This used to be ctdb commit 65e9309564611bf937ded3c74a79abff895d7c59)
* lower the loglevel when we long that we skip an evenscript because it is not ↵Ronnie Sahlberg2009-06-011-1/+1
| | | | | | executable (This used to be ctdb commit c265df3c7950aab51b8b6ef17040229b97345c35)
* add missing checks on so far ignored return valuesSumit Bose2009-05-211-1/+5
| | | | | | Most of these were found during a review by Jim Meyering <meyering@redhat.com> (This used to be ctdb commit 3aee5ee1deb4a19be3bd3a4ce3abbe09de763344)
generated by cgit (git 2.34.1) at 2025-06-16 05:22:44 +0000