summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* s3:lib: fix/simplify srprs_hex()Stefan Metzmacher2014-11-251-10/+6
| | | | | | | | | | | | | | | | | | | | | There're a few problems with this function. - it pretends to support values up to UINT64_MAX in it only returns 'unsigned' which support only values up to UINT32_MAX. Currently we only have callers with len=2 and len=8, so it's not a triggered bug. We just allow (len >= 1 && len <= 8) now. - The compiler is not able to inspect the format string to sscanf(). We copy up to 8 bytes into a stack buffer and always pass "%8x" to sscanf. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib-pyldb: Block elements should be surrounded by {} in py_msg.setitem()Kamen Mazdrashki2014-11-251-1/+2
| | | | | | | | | Change-Id: I0d09374b27708fcaad3523d985a2db7983dbd81a Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Nov 25 07:24:12 CET 2014 on sn-devel-104
* lib-pyldb: Fix docstring for msg.add() method - it was "S.append()"Kamen Mazdrashki2014-11-251-1/+1
| | | | | | Change-Id: I9492d3c3993fc3d68d7bf24405db6e8cd746eaac Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib-ldb-test: Test copying message element from a message to a new messageKamen Mazdrashki2014-11-251-0/+14
| | | | | | Change-Id: Iefcafb418a170ee410aec900bb36eb8e01e946b1 Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib-pyldb: Avoid crash when copying MessageElements between Python Message ↵Kamen Mazdrashki2014-11-251-4/+22
| | | | | | | | | | | | | | | | | | | | objects This patch allows for following snipets in Python: res = ldb.search(...) m_from = res[0] m_to = Message() m_to.add(m_from["attrName"]) The problem previously is that we are trying to reference a ldb_message_element that may not be a memory context on its own. For instance, when search request from above example returns Messages with more than one attribute, this leads immediately to "Bad talloc magic value" crash, every message element beside the first one is not a memory context Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib-ldb_ldif: Stop processing if ldb_message element name is NULLKamen Mazdrashki2014-11-251-0/+7
| | | | | | | | | | I have hit this while using Python bindings for testing and forgot to pass 'name' argument to MessageElement constructor Passing NULL as 'name' is obviously a mistake and this commits aims to warn about such unintetional mistakes. Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib-ldb: Check for input parameter when searching attributes by nameKamen Mazdrashki2014-11-251-2/+13
| | | | | | | | This prevents a segfault that is hard to be tracked down from Python bindings for instance. Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib-pyldb: Throw exception when we can't create MessageElement objectKamen Mazdrashki2014-11-251-0/+2
| | | | | | | | At the moment we return an error, but no exception and it is hard to instantly see what the problem is from Python Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib-pyldb: Avoid leaking memory in error casesKamen Mazdrashki2014-11-251-2/+6
| | | | | Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* lib-pyldb: Avoid SEGFAULT in case we can't convert passed value to py_StringKamen Mazdrashki2014-11-251-0/+5
| | | | | Signed-off-by: Kamen Mazdrashki <kamenim@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3-smbstatus: Fix exit code of profile output.Andreas Schneider2014-11-241-2/+5
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10961 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Nov 24 21:13:51 CET 2014 on sn-devel-104
* messaging3: Fix sending large messages on FreeBSDVolker Lendecke2014-11-241-0/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Reformat unix_dgram_send a bitVolker Lendecke2014-11-241-1/+3
| | | | | | | This makes the next commit a bit more readable Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3-smbclient: Return success if we listed the shares.Andreas Schneider2014-11-241-1/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10960 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* dsdb: Remove a self-assignmentVolker Lendecke2014-11-241-1/+0
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* dbwrap: Fix a enum conversionVolker Lendecke2014-11-241-1/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Nov 24 18:36:00 CET 2014 on sn-devel-104
* Print number of slow tests from script rather than wscript.Jelmer Vernooij2014-11-242-3/+4
| | | | | | | | | | Change-Id: I6eaa0803b95cc81f514a2176f4e06f1e3fff4077 Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org> Autobuild-Date(master): Mon Nov 24 13:06:46 CET 2014 on sn-devel-104
* sam: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-241-8/+4
| | | | | | Change-Id: Ic2ac4b335cf805ddbd442a065c4eaf6ef2b210d9 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Use samba.tests.subunitrun in dsdb ldap and ldap_schema tests.Jelmer Vernooij2014-11-242-39/+50
| | | | | | Change-Id: I51ddc55720a23013a2c6ae20e3225f027348083c Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Use samba.tests.subunitrun in urgent replication test.Jelmer Vernooij2014-11-241-13/+4
| | | | | | Change-Id: I3e7a32876d557ac376326ab75e851298e874d584 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Include mimeparse, which is used by subunit/testtools.Jelmer Vernooij2014-11-2210-3/+717
| | | | | | | | | Change-Id: I984c82acc0bc82a165e8ea17d8948c465c786905 Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org> Autobuild-Date(master): Sat Nov 22 04:44:11 CET 2014 on sn-devel-104
* ldap: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-20/+7
| | | | | | Change-Id: I872654afb31a5eda8c88aac716f9ce79816e5f05 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* deletetest: use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-62/+54
| | | | | | Change-Id: I13565c7c14ea186709ce1de9038ef840c5b766b8 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* ldap_syntaxes: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-221-24/+16
| | | | | | Change-Id: Ib62b747876b4408fdc8ff44e9b4c63578e1a6408 Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* password lockout: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-100/+91
| | | | | | Change-Id: I848099d22acd4a0ce7d589de48eb72e2d180ceae Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* passwords: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-120/+114
| | | | | | Change-Id: Ib806f63ef412fec264445eefd82146e5140b0bac Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* sec_descriptor: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-17/+7
| | | | | | Change-Id: I5caba3e27ad21cc5381883a823e0ec5e2966a264 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* token_group: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-14/+10
| | | | | | Change-Id: Id7c247451532eded1f44ef9b1aa1808dd18098c6 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* sites: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-13/+8
| | | | | | Change-Id: Ic06e1a0f7174683b6b817a5412b8635145329c00 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* speedtest: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-221-14/+4
| | | | | | Change-Id: Id842c3f74aec24faeab68e975ff4d9e9a0dc337b Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* credentials test: Use samba.tests.subunitrun.Jelmer Vernooij2014-11-222-21/+15
| | | | | | Change-Id: I8970c66de9535cb8d48b17d88b2759b7d1e39cb8 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* sec_descriptor test: Simplify, use samba.tests.subunitrun module.Jelmer Vernooij2014-11-223-20/+14
| | | | | | Change-Id: I4ffda49cf3e209eaa28fc83f6fd9ded47f0ad7ee Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Move option handling into samba.tests.subunitrun.Jelmer Vernooij2014-11-224-20/+21
| | | | | | Change-Id: I65a73b74854af636413f4f284147f3bcf28b6f82 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Move option parsing to samba.tests.subunitrun.Jelmer Vernooij2014-11-223-10/+23
| | | | | | Change-Id: I2939c1b6ebb9739530efa9bc4667668cff7a7aeb Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* subunitrun: Use new samba.tests.subunitrun module.Jelmer Vernooij2014-11-221-13/+3
| | | | | | Change-Id: Ie32f16d72c80c831adfd9a8d32735fa348962123 Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Add convenience class for old-style Samba subunit python tests.Jelmer Vernooij2014-11-222-13/+69
| | | | | | Change-Id: I84a97cc71cfa99c14e0c93ec19ff9eea6149bb5a Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Add bundled copy of 'extras' python module used by newer versions of ↵Jelmer Vernooij2014-11-2214-1/+551
| | | | | | | | testtools/subunit. Change-Id: I5ad9222ccb4228a4b16d54a578276d4b9d4e6c4d Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* Clean up more whitespace.Guy Harris2014-11-223-7/+7
| | | | | | Reviewed-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-By: Kamen Mazdrashki <kamenim@samba.org> Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
* vfs_streams_xattr: check stream typeRalph Boehme2014-11-221-0/+6
| | | | | | | | | | | Only allow access to the stream type "$DATA". vfs_streams_depot does this too and it fixes the failing test "smb2.streams.names". Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Nov 22 01:07:54 CET 2014 on sn-devel-104
* vfs_streams_xattr: initialize pointerRalph Boehme2014-11-211-1/+1
| | | | | | | | Intitialize pointer to NULL, otherwise we talloc_free() an unitialized pointer in the error code path. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* vfs_streams_xattr: fix check with samba_private_attr_name()Ralph Boehme2014-11-211-3/+18
| | | | | | | | | | | | | | | We want to check with samba_private_attr_name() whether the xattr name is a private one, unfortunately it flags xattrs that begin with the default streams prefix as private. By only calling samba_private_attr_name() in case the xattr does NOT begin with the default prefix, we know that if it returns 'true' it definitely one of our internal xattr like "user.DOSATTRIB". This fixes a bug introduced in 634bcb09a08b927fd79ae0e16aeee2a123605f94 that denied all access to valid stream xattrs. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4-dns: dlz-bind: Add trailing '.' to all fqdn stringsAmitay Isaacs2014-11-212-20/+59
| | | | | | | | | | | | | | BIND 9.10.x is strict when sending records via putrr and putnamedrr. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10620 Thanks to Guenter Kukkukk for identifying the problem and resolution. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Guenter Kukkukk <kukks@samba.org> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Nov 21 06:14:55 CET 2014 on sn-devel-104
* s3:libsmb: fix some function header comments.Michael Adam2014-11-201-3/+3
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Nov 20 18:45:28 CET 2014 on sn-devel-104
* lib/ldb-samba: add ldif handler for msDS-TrustForestTrustInfoStefan Metzmacher2014-11-202-0/+21
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* tdb_wrap: Make mutexes easier to useVolker Lendecke2014-11-201-0/+7
| | | | | | | | | This patch makes sure we work fine and open without mutexes if they are not supported. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* tdb: allow tdb_open_ex() with O_RDONLY of TDB_FEATURE_FLAG_MUTEX tdbs.Stefan Metzmacher2014-11-201-9/+9
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10781 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:smbprofile: profile async pread/pwrite/fsync syscallsStefan Metzmacher2014-11-192-0/+13
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Nov 19 23:13:10 CET 2014 on sn-devel-104
* s3:smbprofile: track connect_count and disconnect_countStefan Metzmacher2014-11-193-0/+5
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:smbprofile: remove unused {START,END}_PROFILE_STAMP()Stefan Metzmacher2014-11-191-19/+0
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:smbprofile: report idle state of 'idle_count' and 'idle_time'Stefan Metzmacher2014-11-192-9/+4
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
generated by cgit (git 2.34.1) at 2025-09-18 23:10:36 +0000