summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* ctdb-build: Remove duplicate tevent libraryAmitay Isaacs2014-06-2039-11795/+0
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-build: Remove duplicate talloc libraryAmitay Isaacs2014-06-2044-11915/+0
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-build: Remove duplicate replace libraryAmitay Isaacs2014-06-2072-15062/+0
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-build: Remove duplicate popt libraryAmitay Isaacs2014-06-2014-3340/+0
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org>
* ctdb-eventscripts: Ensure $GANRECDIR points to configured subdirectoryMartin Schwenke2014-06-201-14/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | Check that the $GANRECDIR symlink points to the location specified by $CTDB_GANESHA_REC_SUBDIR and replace it if incorrect. This handles reconfiguration and filesystem changes. While touching this code: * Create the $GANRECDIR link as a separate step if it doesn't exist. This means there is only 1 place where the link is created. * Change some variables names to the style used for local function variables. * Remove some "ln failed" error messages. ln failures will be logged anyway. * Add -v to various mkdir/rm/ln commands so that these actions are logged when they actually do something. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Jun 20 05:40:16 CEST 2014 on sn-devel-104
* ctdb-daemon: Debugging for tickle updatesMartin Schwenke2014-06-201-1/+10
| | | | | | | | | | | | | This was useful for debugging the race fixed by commit 4f79fa6c7c843502fcdaa2dead534ea3719b9f69. It might be useful again. Also fix a nearby comment typo. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Jun 20 02:07:48 CEST 2014 on sn-devel-104
* ctdb-tests: Try harder to avoid failures due to repeated recoveriesMartin Schwenke2014-06-192-15/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | About a year ago a check was added to _cluster_is_healthy() to make sure that node 0 isn't in recovery. This was to avoid unexpected recoveries causing tests to fail. However, it was misguided because each test initially calls cluster_is_healthy() and will now fail if an unexpected recovery occurs. Instead, have cluster_is_healthy() warn if the cluster is in recovery. Also: * Rename wait_until_healthy() to wait_until_ready() because it waits until both healthy and out of recovery. * Change the post-recovery sleep in restart_ctdb() to 2 seconds and add a loop to wait (for 2 seconds at a time) if the cluster is back in recovery. The logic here is that the re-recovery timeout has been set to 1 second, so sleeping for just 1 second might race against the next recovery. * Use reverse logic in node_has_status() so that it works for "all". * Tweak wait_until() so that it can handle timeouts with a recheck-interval specified. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* messaging3: Make messaging_dgm_init return 0/errnoVolker Lendecke2014-06-183-23/+22
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 18 21:17:57 CEST 2014 on sn-devel-104
* messaging3: Use "goto fail_nomem" where appropriateVolker Lendecke2014-06-181-4/+2
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* messaging3: simplify messaging_dgm_lockfile_removeVolker Lendecke2014-06-181-14/+11
| | | | | | | full_path_tos() isn't really required here, this is not a hot code path Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* messaging3: Make messaging_dgm_wipe return 0/errnoVolker Lendecke2014-06-184-17/+17
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* messaging3: Make messaging_dgm_cleanup return 0/errnoVolker Lendecke2014-06-184-20/+22
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* messaging3: Make the _send function return 0/errnoVolker Lendecke2014-06-184-28/+38
| | | | | | | This is to eventually make messaging_dgm usable in ctdb Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* messaging3: Remove two uses of talloc_tos()Volker Lendecke2014-06-181-4/+5
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* messaging3: Remove use of full_path_tos()Volker Lendecke2014-06-181-8/+6
| | | | | | | | This is not performance critical, and this removes source3 specific code Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Lift sockaddr_un handling from unix_msg_sendVolker Lendecke2014-06-185-33/+24
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Lift sockaddr_un handling from unix_msg_initVolker Lendecke2014-06-185-43/+43
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Lift sockaddr_un handling from unix_dgram_sendVolker Lendecke2014-06-181-19/+17
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Lift sockaddr_un handling from unix_dgram_send_queue_initVolker Lendecke2014-06-181-13/+7
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Lift sockaddr_un handling from unix_dgram_initVolker Lendecke2014-06-181-16/+23
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib: Apply const to nt_time_to_unix_timespecVolker Lendecke2014-06-182-2/+2
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Jun 18 16:35:26 CEST 2014 on sn-devel-104
* samba-tool domain: remove duplicate check if site is setBjörn Baumbach2014-06-181-3/+0
| | | | | | Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
* samba-tool: add --site parameter to provision commandBjörn Baumbach2014-06-181-1/+4
| | | | | | | | | This new parameter offers the option to specify a default initial site name. Otherwise it will be "Default-First-Site-Name". Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
* provision/sambadns: remove redundant site parameterBjörn Baumbach2014-06-182-3/+4
| | | | | | | | The sitename is already included in "names" parameter. Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
* s4: torture : Add test case to show that a bad impersonation level causes an ↵Jeremy Allison2014-06-182-0/+47
| | | | | | | | | | | | error on a regular file open. An invalid impersonation level is only allowed for durable handle reopen. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 18 09:42:43 CEST 2014 on sn-devel-104
* s3: torture test. We now pass "samba3.smb2.create.leading-slash" so remove ↵Jeremy Allison2014-06-181-1/+0
| | | | | | | from knownfail. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
* s3: smb2 - strictly obey file name restrictions w.r.t. the SMB2 protocol spec.Jeremy Allison2014-06-181-0/+16
| | | | | | | | | | | | | MS-SMB2: 3.3.5.9 - Receiving an SMB2 CREATE Request If the file name length is greater than zero and the first character is a path separator character, the server MUST fail the request with STATUS_INVALID_PARAMETER. Found and fix confirmed by Microsoft test tool. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
* s3: smb2 - Check supplied impersonation level on SMB2_CREATE.Jeremy Allison2014-06-181-0/+18
| | | | | | | | | | | | | | | MS-SMB2: 2.2.13 SMB2 CREATE Request ImpersonationLevel ... MUST contain one of the following values. The server MUST validate this field, but otherwise ignore it. NB. source4/torture/smb2/durable_open.c shows that this check is only done on real opens, not on durable handle reopens. Found and fix confirmed by Microsoft test tool. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
* s3: smb2 - Negprot should return INVALID_PARAMETER if flags2 signed bit is set.Jeremy Allison2014-06-181-2/+17
| | | | | | | | | | | | | MS-SMB2: 3.3.5.2.4 Verifying the Signature. If the SMB2 header of the SMB2 NEGOTIATE request has the SMB2_FLAGS_SIGNED bit set in the Flags field, the server MUST fail the request with STATUS_INVALID_PARAMETER. Found and fix confirmed by Microsoft test tool. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
* s3: auth: Fix winbindd_pam_auth_pac_send() to create a new info3 and merge ↵Jeremy Allison2014-06-181-2/+22
| | | | | | | | | | | | | in resource groups from a trusted PAC. Based on a patch from Richard Sharpe <realrichardsharpe@gmail.com>. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Simo Sorce <idra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 18 03:30:36 CEST 2014 on sn-devel-104
* s3: auth: Change auth3_generate_session_info_pac() to use a copy of the ↵Jeremy Allison2014-06-181-2/+9
| | | | | | | | | | | info3 struct from the struct PAC_LOGON_INFO. Call create_info3_from_pac_logon_info() to add in any resource SIDs from the struct PAC_LOGON_INFO to the info3. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Simo Sorce <idra@samba.org>
* s3: auth: Add create_info3_from_pac_logon_info() to create a new info3 and ↵Jeremy Allison2014-06-182-0/+80
| | | | | | | | | | merge resource group SIDs into it. Originally written by Richard Sharpe Richard Sharpe <realrichardsharpe@gmail.com>. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Simo Sorce <idra@samba.org>
* s3: auth: Change make_server_info_info3() to take a const struct ↵Jeremy Allison2014-06-183-6/+6
| | | | | | | | | | netr_SamInfo3 pointer instead of a struct PAC_LOGON_INFO. make_server_info_info3() only reads from the info3 pointer. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Simo Sorce <idra@samba.org>
* s3: auth: Add some const to the struct netr_SamInfo3 * arguments of ↵Jeremy Allison2014-06-183-4/+4
| | | | | | | | | | copy_netr_SamInfo3() and make_server_info_info3() Both functions only read from the struct netr_SamInfo3 * argument. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Simo Sorce <idra@samba.org>
* lib: Use BVAL macro in interpret_long_dateVolker Lendecke2014-06-181-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* autobuild: fix samba-ctdb samba build to pick up right tdbMichael Adam2014-06-171-1/+1
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Jun 17 11:58:00 CEST 2014 on sn-devel-104
* autobuild: add cflags and ldflags to find locally installed tdbMichael Adam2014-06-171-1/+1
| | | | | | | So that we can find our self-installed tdb lib and use new features. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: always run freelist_size againMichael Adam2014-06-171-6/+4
| | | | | | | | | | | and not only if repack_limit != 0. This partially reverts commit 48f2d1158820bfb063ba0a0bbfb6f496a8e7522. With the new tdb code this defragments the free list by merging adjacent records. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: add missing return to ctdb_vacuum_traverse_db() error path.Michael Adam2014-06-171-0/+1
| | | | | | | | This got lost in commit 19948702992c94553e1a611540ad398de9f9d8b9 ("ctdb-vacuum: make ctdb_vacuum_traverse_db() void.") Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: remove now unused talloc ctx argument from ctdb_vacuum_db()Michael Adam2014-06-171-3/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: move init of vdata into init_vdata funcionMichael Adam2014-06-171-32/+43
| | | | | | | | | | | | | This is a small code cleanup. vdata is only used in ctdb_vacuum_db() and not in ctdb_vacuum_and_repack_db() where it is currently initialized. This patch moves creation and all previously scattered initialization of vacuum_data into ctdb_vacuum_init_vacuum_data which is called from ctdb_vacuum_db. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: remove vacuum limit from vdata - not usedMichael Adam2014-06-171-2/+0
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: remove a superfluous comment.Michael Adam2014-06-171-4/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: untangle assignmend and check for return of tdb_repack()Michael Adam2014-06-171-1/+3
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: remove a superfluous and misleading commentMichael Adam2014-06-171-3/+0
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: remove now unused ctdb_repack_tdb().Michael Adam2014-06-171-129/+0
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: use plain tdb_repack() instead of ctdb_repack_tdb()Michael Adam2014-06-171-1/+1
| | | | | | | | | Since we usually have 0 records left for repack-deletion, repacking is essentially used for the purpose of defragmenting the freelist, we can use the vanilla tdb_repack function. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: remove a comment in ctdb_vacuum_and_repack_db()Michael Adam2014-06-171-3/+0
| | | | | | | | The repack operation now mainly defragments the freelist and does not usually delete any records any more. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:vacuum: adapt debug message for repacking.Michael Adam2014-06-171-2/+2
| | | | | | | | | Now we usually have records to delete == 0 after the preceding vacuum run. Anyways, deletion is not a major aspect any more of the repack run and will vanish soon. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* messaging3: Use server_id_str_bufVolker Lendecke2014-06-171-2/+4
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Jun 17 09:27:07 CEST 2014 on sn-devel-104