summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* s4-smbtorture: heavily expand printerdata tests in RPC-SPOOLSS.Günther Deschner2009-12-041-67/+299
| | | | | | | | | Including new tests for: - spoolss_SetPrinterDataEx - spoolss_DeletePrinterDataEx - spoolss_DeletePrinterKey Guenther
* s3 aclocal.m4: Fix iconv checks, clean up m4 codeKai Blin2009-12-041-27/+30
| | | | | | | | | | | | | The check for iconv requiring giconv.h and libgiconv as well as the check for iconv requiring biconv.h and libbiconv were using the wrong variable to check for previous successful test results. This caused the checks to always fall back to libbiconv on systems where that library was available. In the course of fixing this, I had to clean up the indentation in that piece of code, and I also rewrote/added some comments. Many thanks to Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp> for the initial patch and diagnosis.
* s4-ldb: fixed show_deleted module not to corrupt parse treesAndrew Tridgell2009-12-041-23/+26
| | | | | | | | | The show_deleted module was using a static private ptr in the module to hold a parse tree to save on parsing. The code caused this static ptr to change with each search, which caused incorrect searches and numerous valgrind errors. This patch replaces it with a hand-built parse tree.
* s4-drsutil: fixed a memory leak in samdb_search_countAndrew Tridgell2009-12-043-8/+12
| | | | | In general functions that don't return any memory should not take a memory context. Otherwise it is too easy to have a bug like this where memory is leaked
* s4 torture: Convert create_complex_file to use BASIC_INFO instead of ↵Zachary Loafman2009-12-031-20/+26
| | | | | | deprecated command Signed-off-by: Tim Prouty <tprouty@samba.org>
* s4 torture: Fix call to smbcli_openZachary Loafman2009-12-031-1/+1
| | | | Signed-off-by: Tim Prouty <tprouty@samba.org>
* s4 torture: Make RAW-SEARCH pass against win7Zachary Loafman2009-12-033-2/+40
| | | | Signed-off-by: Tim Prouty <tprouty@samba.org>
* s4 torture: Parameterize WRITE_AND_CLOSE supportZachary Loafman2009-12-032-0/+6
| | | | Signed-off-by: Tim Prouty <tprouty@samba.org>
* s4 torture: Add lockread_supported based off of CAP_LOCK_AND_READZachary Loafman2009-12-034-0/+14
| | | | Signed-off-by: Tim Prouty <tprouty@samba.org>
* s4 torture: Allow READ to be parameterized, add more readx testsZachary Loafman2009-12-032-2/+30
| | | | Signed-off-by: Tim Prouty <tprouty@samba.org>
* s4-torture: Allow the legacy DENY_FCB/DENY_DOS share modes to be ignoredZachary Loafman2009-12-032-0/+22
| | | | Signed-off-by: Tim Prouty <tprouty@samba.org>
* s4 selftest/quicktest: Update known failures for the sfileinfo and oplock ↵Tim Prouty2009-12-032-1/+2
| | | | | | | | | changes Two new samba4 bugs have been filed for the two corresponding known failures. For the short term raw.sfileinfo had to be removed from quicktest. It is no longer an individual test, but a test-suite and quicktest can only run top level tests.
* s4 torture: Add a new RAW-OPLOCK test: BATCH26Tim Prouty2009-12-031-0/+108
| | | | | | | | | | | | | | | | | | | | | | | Try a rename with a wide-open share mode on an already open file and the there is still share mode contention. For the reason why see: http://social.msdn.microsoft.com/Forums/en-US/os_fileservices/thread/3ca14dc9-da1f-4786-a8f7-a86e9903db0c Msft's anser: After further review, The reason for server to fail with sharing violation is that the windows server that executes a path-based rename request opens the file for DELETE access, but only with FILE_SHARED_READ as ShareAccess . Therefore, the existing open(frame 76), which has shared read/write/delete , is compatible with the Windows servers access mode (DELETE), but Windows servers open is not compatible with access mode in existing open. Note that it is correct to state that the logic in Windows server could have been written to allow shared read/write/delete in which case it would succeed as you mention. The behavior here is historical based on the existing implementation.
* s4 torture: Close the third handle in RAW-OPLOCK-BATCH22Tim Prouty2009-12-031-2/+5
|
* s4 torture: Convert an error to a warning in RAW-OPLOCK-BATCH22Tim Prouty2009-12-031-12/+27
| | | | | | | | | | | | | | Some servers choose to mark a client as bad if they fail an oplock break request by timing out (win7 is an example). Once the client is marked as bad, future oplock requests will timeout instantly. This causes subsequent runs of this test to fail, so rather than erroring out as a failure, a warning is printed instead. There is also a bug in w2k3 where it was incorrectly returning contending a share mode lock. It worked in XP and has been re-fixed in win7. This can also now be run against samba3.
* s4 torture: Add a few more windows target typesTim Prouty2009-12-032-0/+6
|
* s4 torture: Convert to a more modern version of read in RAW-OPLOCK-BATCH4Tim Prouty2009-12-031-5/+7
|
* s4 torture: Allow some implementations to break from level1 to none with two ↵Tim Prouty2009-12-033-7/+21
| | | | breaks
* Make sure we're not using the old smb_fname data.Jeremy Allison2009-12-031-1/+1
| | | | Jeremy.
* Remove smb_fname duplicates that just keep the same information as in ↵Jeremy Allison2009-12-033-24/+11
| | | | | | | | fsp->fsp_name. Moving towards making VFS_OPEN/VFS_MKDIR/VFS_RMDIR handle based... Jeremy.
* s3-spoolss: handle SEC_FLAG_MAXIMUM_ALLOWED in spoolss_OpenPrinterEx.Günther Deschner2009-12-031-0/+4
| | | | | | | In case someone (smbtorture4) requests SEC_FLAG_MAXIMUM_ALLOWED, translate it to a request of PRINTER_ACCESS_ADMINISTER. Guenther
* s4-smbtorture: check more WERRORs in RPC-SPOOLSS.Günther Deschner2009-12-031-34/+35
| | | | Guenther
* s4-smbtorture: call test_EnumPrinterDrivers with architecture in RPC-SPOOLSS.Günther Deschner2009-12-031-25/+6
| | | | Guenther
* Refactor reply_rmdir to use handle based code. AllJeremy Allison2009-12-033-265/+298
| | | | | | calls are now handle based. Put rmdir into close.c and make it private. Jeremy.
* s4:operational LDB module - Fix usage of LDB constantsMatthias Dieter Wallnöfer2009-12-031-4/+4
|
* s4:ntvfs/posix/pvfs_streams - Fix "discard const" warningMatthias Dieter Wallnöfer2009-12-031-1/+1
| | | | | | I removed one "const" in front of a string declaration to achieve this. Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s4:ntvfs/posix/pvfs_resolve - Fix "discard const" warningMatthias Dieter Wallnöfer2009-12-032-4/+4
| | | | | | I removed two "const"s in front of string declarations to achieve this. Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3: Fix crash in winbindd;(bug#6879).Bo Yang2009-12-031-2/+8
| | | | Signed-off-by: Bo Yang <boyang@samba.org>
* Remove unneeded argument from can_set_delete_on_close(). EnsureJeremy Allison2009-12-026-38/+23
| | | | | | can_set_delete_on_close() is correctly called before any setting of the disposition bit (clean up the do_unlink() call). Jeremy.
* s4/selftest: knownfail some locking tests until bugs are fixedSteven Danneman2009-12-021-0/+2
|
* ѕ3: remove superfluous option checkBjörn Jacke2009-12-031-13/+10
| | | | this function is only called when strict alloc is set, no reason to check that twice.
* s4/torture: add multiple lock cancel testSteven Danneman2009-12-021-2/+91
| | | | | | | | | See what happens when we have multiple outstanding lock requests and we try to cancel both of them within a single LockingAndX. On Windows, it seems only the first lock in the array is cancelled, and the second is left pending. Though, this behavior goes against the MS-CIFS spec.
* s4/torture: add addition multiple lock testsSteven Danneman2009-12-022-29/+279
| | | | | | | | * test that 2 locks in a single LockAndX are transactional * test that 1 unlock and 1 lock in a single LockAndX are not transactional * test that SMB2 doesn't like mixed lock/unlock in a single PDU
* s4/torture: fix build warnings by removing unecessary constSteven Danneman2009-12-021-1/+1
|
* s4/torture: Add target functionality parameters to SMBv1 BRL testsSteven Danneman2009-12-023-7/+42
| | | | | | | | Abstract the server requirements to pass some BRL tests. * The new default for >64bit lock tests, is that the server should return STATUS_INVALID_LOCK_RANGE. * Add parameter for targets that don't implement DENY_DOS
* s3-selftest: run LOCAL-NDR when running make selftest.Günther Deschner2009-12-031-1/+1
| | | | Guenther
* s4-smbtorture: be very strict in checking spools_EnumPrinterKey results.Günther Deschner2009-12-032-3/+15
| | | | Guenther
* spoolss: hand-marshall the spoolss_StringArray2 struct for ↵Günther Deschner2009-12-035-51/+63
| | | | | | | | spoolss_EnumPrinterKey. This call is just driving me nuts :-) Guenther
* s4-drs: fixed UDV and overlapping sync calls in DRSAndrew Tridgell2009-12-031-40/+42
| | | | | | | | | When windows abandons a DRS sync, it will sometimes re-use the same bind handle for a new sync. This means we need to check the DN of the sync and blank the getnc_state if the DN has changed. This also fixes the UDV to use the highest uSN for the partition, not for the whole SAM.
* s4-drs: fixed updating of uSNChanged in replmd_modifyAndrew Tridgell2009-12-031-3/+2
| | | | Updating of uSNChanged broke in a recent change
* s3:build: remove redundant qnx block size definitionBjörn Jacke2009-12-031-3/+0
|
* Restructure the ACL code some more, get the internal semanticsJeremy Allison2009-12-023-169/+151
| | | | | | | | | | | | | | | | | right. The previous bugs were due to the fact that get_nt_acl_internal() could return an NTSTATUS error if there was no stored ACL blob, but otherwise would return the underlying ACL from the filysystem. Fix this so it always returns a valid acl if it can, and if it does not its an error to be reported back to the client. This then changes the inherit acl code. Previously we were trying to match Windows by setting a minimal ACL on a new file that didn't inherit anything from a parent directory. This is silly - the returned ACL wouldn't match the underlying UNIX permissions. The current code will correctly inherit from a parent if a parent has any inheritable ACE entries that apply to the new object, but will return a mapping from the underlying UNIX permissions if the parent has no inheritable entries. This makes much more sense for new files/directories. Jeremy.
* s3:build: fix shared library build on QNXBjörn Jacke2009-12-031-3/+4
| | | | Fixes #6860. Thanks to Matt Kraai!
* Ensure check_parent_acl_common() only looks at storedJeremy Allison2009-12-021-2/+16
| | | | | blobs - returns NT_STATUS_OK if there aren't any. Jeremy.
* s3: prefer posix_fallocate for doing "strict allocate"Björn Jacke2009-12-024-5/+37
| | | | | | | | | | | | | | | | posix_fallocate is more efficient than manual zero'ing the file. When preallocation in kernel space is supported it's extremely fast. Support for preallocation at fs layer via posix_fallocate and fallocate at kernel site can be found in Linux kernel 2.6.23/glibc 2.10 with ext4, XFS and OCFS2. Other systems that I know of which support fast preallocation in kernel space are AIX 6.1 with JFS2 and recent Solaris versions with ZFS maybe UFS2, too. People who have a system with preallocation in kernel space might want to set "strict allocate = yes". This reduces file fragentation and it's also safer for setups with quota being turned on. As of today most systems still don't have preallocation in kernel space, and that's why "strict allocate = no" will stay the default for now.
* Ensure get_nt_acl_internal() only looks at the ACL blobs, notJeremy Allison2009-12-022-19/+23
| | | | | | | reads off the underlying filesystem. Ensure that vfs_acl_tdb.c returns NT_STATUS_NOT_FOUND, not NT_STATUS_OBJECT_NAME_NOT_FOUND when it can't find a blob matching the file. Jeremy.
* Fix bug #6837 - "Too many open files" when trying to access large number of ↵Jeremy Allison2009-12-023-3/+35
| | | | | | | | files from Windows 7. Original patch by me fixed up with the correct open files number by jmaggard10@hotmail.com. Jeremy.
* samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.Günther Deschner2009-12-0210-94/+31
| | | | | | | This should finally resolve the endian issues we were seeing on sparc and is much cleaner for spoolss clients and servers. Guenther
* spoolss: add spoolss_StringArray2.Günther Deschner2009-12-026-0/+78
| | | | | | | The difference to spoolss_StringArray is that in spoolss_StringArray2 the string array is put into a subcontext of _ndr_size. Guenther
* s3-spoolss: move MAXDEVICENAME to spoolss idl.Günther Deschner2009-12-024-8/+9
| | | | Guenther
generated by cgit (git 2.34.1) at 2025-09-27 23:06:33 +0000