summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove two unused variablesVolker Lendecke2012-11-071-1/+0
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Nov 7 17:18:06 CET 2012 on sn-devel-104
* lib/util: Simplify bitmap.c a bitVolker Lendecke2012-11-071-7/+6
| | | | | | | This avoids the double-talloc for bitmaps Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* lib/util: Make "struct bitmap" abstractVolker Lendecke2012-11-072-4/+6
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* heimdal_build: Fix finding of system heimdal.Jelmer Vernooij2012-11-061-26/+29
| | | | | | | | | | | When checking for Heimdal headers, make sure HAVE_CONFIG_H is not defined, as config.h will not be available. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org> Autobuild-Date(master): Tue Nov 6 16:27:03 CET 2012 on sn-devel-104
* heimdal_build: HEIMDAL_LIBRARY(): Remove unused cflags argument.Jelmer Vernooij2012-11-061-2/+1
|
* selftest/skip: add samba.tests.samba_tool.gpo until it's stableStefan Metzmacher2012-11-061-0/+1
| | | | | | | | | | | | | See: https://git.samba.org/autobuild.flakey/2012-11-06-0314/samba.stdout https://git.samba.org/autobuild.flakey/2012-11-06-0514/samba.stdout https://git.samba.org/autobuild.flakey/2012-11-06-0713/samba.stdout Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Nov 6 14:24:08 CET 2012 on sn-devel-104
* ldb_secrets_tdb_sync: Add dependency on gssapi.Jelmer Vernooij2012-11-061-1/+1
| | | | | | | | | | | This is required when building with the system heimdal, as gssapi/gssapi_spnego.h is included. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Nov 6 05:12:28 CET 2012 on sn-devel-104
* dsdb: Rename _res argument to _result.Jelmer Vernooij2012-11-061-6/+6
| | | | | | | | Newer versions of heimdal include a macro that is unfortunately named '_res'. This change prevents the clash. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* provision: Make dsacl2fsacl() take a security.dom_sid, not strAndrew Bartlett2012-11-063-6/+5
| | | | | | | | Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Nov 6 00:12:43 CET 2012 on sn-devel-104
* provision: Also walk directories checking ACLsAndrew Bartlett2012-11-061-1/+1
| | | | | | | | | The directory walk was missed due to a cut-and-paste error. Andrew Bartlett Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* wintest: Try harder to recover from apparent failure to dcpromoAndrew Bartlett2012-11-061-1/+12
| | | | | Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* selftest: check that samba-tool gpo works for basic operationsAndrew Bartlett2012-11-063-1/+65
| | | | | Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org>
* dsdb: Simplify DsCrackNameOneFilter a bitVolker Lendecke2012-11-061-1/+4
| | | | | | | | For me "else" branches clutter my flow reading code. If we do a hard return at the end of an "if" branch, "else" is not required. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wafsamba.abi: Fix abi_match with both excludes and includes.Jelmer Vernooij2012-11-062-3/+20
| | | | | | | | | | | This fixes a regression introduced by 9c3e294400234ebdf9b98031bae583524fd0b0ac which caused internal symbols in libldb to be exposed. Bug: https://bugzilla.samba.org/show_bug.cgi?id=9357 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>
* wafsamba.samba_abi: Add basic unit tests.Jelmer Vernooij2012-11-062-1/+51
| | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>
* buildtools: Remove extra space from global: lineAndrew Bartlett2012-11-061-1/+1
| | | | | | | | | | | | This makes it easier to put the expected values in a file as we will not have trailing whitespace that is against git style. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* wafsamba.samba_abi: Refactor abi_write_vscript to take file argument.Jelmer Vernooij2012-11-061-9/+13
| | | | | | Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>
* s3:smbd: pass the current time to make_connection[_smb1]()Stefan Metzmacher2012-11-053-6/+9
| | | | | | | | | | Otherwise smbstatus reports the wrong time for tree connects. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Mon Nov 5 20:43:23 CET 2012 on sn-devel-104
* s3:utils fix a whitespace errorChristian Ambach2012-11-051-1/+1
|
* s3:vfs_default: optimize vfswrap_asys_finished() and read as much as we canStefan Metzmacher2012-11-051-16/+33
| | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Nov 5 19:01:13 CET 2012 on sn-devel-104
* lib/tsocket: optimize syscalls in tstream_readv_pdu_send()Stefan Metzmacher2012-11-051-0/+29
| | | | | | | Once we've got the first part of a pdu we try to optimize readv calls for the rest of the pdu. Signed-off-by: Stefan Metzmacher <metze@samba.org>
* lib/tsocket: disable the syscall optimization for recvfrom/readv by defaultStefan Metzmacher2012-11-052-6/+109
| | | | | | | | | We only do the optimization on recvfrom/readv if the caller asked for it. This is needed because in most cases we preferr to flush send buffers before receiving incoming requests. Signed-off-by: Stefan Metzmacher <metze@samba.org>
* libads: Always free the talloc_stackframe() on error pathAndrew Bartlett2012-11-051-0/+1
| | | | | | | Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Nov 5 03:33:32 CET 2012 on sn-devel-104
* selftest: Add skip for DIR1 test which loops on 64 bit ext4Andrew Bartlett2012-11-051-0/+1
| | | | | | | | Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Nov 5 00:34:56 CET 2012 on sn-devel-104
* s4-dns: Fix format string vulnerability in an error message (bug #9354)Amitay Isaacs2012-11-041-4/+5
| | | | | | | | | | | | Also, fixes few comments. Thanks to Bruno Rohée <bruno@rohee.org> for reporting and patch fix. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-By: Kai Blin <kai@samba.org> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Sun Nov 4 16:58:13 CET 2012 on sn-devel-104
* vfs_acl_common: In add_directory_inheritable_components allocate on psd as ↵Andrew Bartlett2012-11-021-4/+16
| | | | | | | | | | | | | | | | parent When we add a new DACL to the security descriptor, we need to use the SD as the memory context, so we can talloc_move() it as a tree to a new parent. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Nov 2 22:16:14 CET 2012 on sn-devel-104
* smb2_server: Fix typo in comment.Karolin Seeger2012-11-021-1/+1
| | | | | | | Karolin Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Nov 2 15:40:22 CET 2012 on sn-devel-104
* build(waf): Fail "configure --with-cluster-support" if ctdb support is not ↵Björn Baumbach2012-11-021-6/+10
| | | | | | | | | available. Currently, configure only warns if cluster support is not found. Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org>
* s3-torture:test_ctdbconn: fix the build against older ctdb versionsBjörn Baumbach2012-11-021-0/+6
| | | | | | | by checking if we have the ctdb_protocol.h and including ctdb_private.h otherwise. Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:ctdb library: fix the build against older ctdb versionsBjörn Baumbach2012-11-021-0/+5
| | | | | | | by checking if we have the ctdb_protocol.h and including ctdb_private.h otherwise. Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org>
* build(waf): check if we have ctdb_protocol.h in the cluster checksBjörn Baumbach2012-11-021-0/+22
| | | | | Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org>
* build(autoconf): check if we have ctdb_protocol.h in the cluster checksBjörn Baumbach2012-11-021-1/+1
| | | | | Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org>
* build(autoconf): fix check for ctdb_private.hBjörn Baumbach2012-11-021-1/+1
| | | | | Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Michael Adam <obnox@samba.org>
* build(waf): fix the cluster(ctdb) build without system talloc installedMichael Adam2012-11-021-0/+3
| | | | | | | | | This is analogous to the earlier patch for tdb. It temporarily adds the talloc include path to the includes search list for the ctdb-header configure checks. Signed-off-by: Michael Adam <obnox@samba.org> Tested-by: Björn Baumbach <bb@sernet.de>
* build(waf): fix a tab indentation to spacesMichael Adam2012-11-021-1/+1
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* docs-xml: fix use of <smbconfoption> tag (fix bug #9345)Björn Baumbach2012-11-021-5/+8
| | | | | | | | Signed-off-by: Björn Baumbach <bb@sernet.de> Reviewed-by: Karolin Seeger <ks@samba.org> Autobuild-User(master): Karolin Seeger <kseeger@samba.org> Autobuild-Date(master): Fri Nov 2 12:37:42 CET 2012 on sn-devel-104
* s3:smbd:smb2: fix a comment typo in the crediting code.Michael Adam2012-11-021-1/+1
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Nov 2 10:09:36 CET 2012 on sn-devel-104
* s3:winbindd: use PROTOCOL_LATEST instead of PROTOCOL_SMB2_02 (bug #9175)Stefan Metzmacher2012-11-011-1/+1
| | | | | | | | | | We should use the latest supported dialect. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewd-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Nov 1 18:11:27 CET 2012 on sn-devel-104
* s3:winbindd: disconnection after getting NETWORK_SESSION_EXPIRED (bug #9175)Stefan Metzmacher2012-11-011-0/+11
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* libcli/smb: add smbXcli_session_set_disconnect_expired() (bug #9175)Stefan Metzmacher2012-11-012-0/+35
| | | | | | | | This should be a short term hack until the upper layers have implemented re-authentication. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* lib/krb5_wrap: request enc_types in the correct order (bug #9272)Stefan Metzmacher2012-11-011-6/+6
| | | | | | | | | aes256-cts-hmac-sha1-96 and aes128-cts-hmac-sha1-96 should have a higher priority than arcfour-hmac-md5, otherwise the KDC still gives us arcfour-hmac-md5 session keys. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3:winbindd:cache: fix offline logons with cached credentials (bug #9321)Michael Adam2012-11-011-0/+7
| | | | | | | | | | | | | The removal of consumption of the time field from the centry as "removal of unused variable" in 21528da9cd12a4f5c3792a482a5d18fe946a6f7a had the side effect of changing the offset for reading the following nt password hash, so the read password hash was wrong. This patch re-installs the consumption of the time, thereby fixing the bug without changing the disk format of the cache. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3-param: Move the options needed for running smbd in the AD DC to loadparmAndrew Bartlett2012-11-012-51/+19
| | | | | | | | | | | | | | | | | | This avoids the whole fileserver.conf thing, and simply handles everything in C. The main challenge is that if s3fs is enabled in a member server configuration (unlikely) then these options will not be set, and it overrides any other attempt to set these as globals. (The previous approach essentially just changed defaults, because the include = of smb.conf was after the values were set in fileserver.conf). Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Nov 1 11:47:22 CET 2012 on sn-devel-104
* file_server: put set create mask and directory mask in fileserver.confAndrew Bartlett2012-11-011-0/+2
| | | | | | | | | | | | This allows any ACL to be set from the client, without restriction from the Samba side. Based on advise from Jermey at https://lists.samba.org/archive/samba-technical/2012-October/088414.html Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* test-chgdcpass: test the ldap case for server password changeAndrew Tridgell2012-11-011-7/+18
| | | | | | | | | use samba-tool drs options which does both RPC and LDAP connections Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Tridgell <tridge@samba.org> Autobuild-Date(master): Thu Nov 1 07:21:17 CET 2012 on sn-devel-104
* s4-ldapclient: cope with logon failure retry in LDAPAndrew Tridgell2012-11-011-37/+79
| | | | | | | | | similar to what was done for rpc and cifs, we now retry once on logon failure for ldap, allowing for a new ticket to be fetched when a server password changes while we have a valid ticket for the old password Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* s4-librpc: set error code to LOGON_FAILURE on RPC fault with access deniedAndrew Tridgell2012-11-011-2/+7
| | | | | | | this allows the client code to trigger a retry with a new password callback for NTLM connections Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* samba-tool: "drs options" does not need a samdb connectionAndrew Tridgell2012-11-011-1/+0
| | | | | | this gives us a handy pure RPC client test for use in blackbox testing Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* s4-librpc: try a 2nd logon for more error casesAndrew Tridgell2012-11-011-3/+10
| | | | | | | not all servers give LOGON_FAILURE on authentication failures, so we need to do the retry with a new ticket on a wider range of error types Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* ldb: fixed callers for ldb_pack_data() and ldb_unpack_data()Andrew Tridgell2012-11-0110-48/+321
| | | | | | | | | | | with ltdb_pack_data() and ltdb_unpack_data() now moved into common, we need to increase the minor version and fixup callers of the API Note that this relies on struct ldb_val being the same shape as TDB_DATA, in much the same way as we rely on ldb_val and DATA_BLOB being the same shape. Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>