summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* s4/test: Refactor test_user_cleanup to be more robustKamen Mazdrashki2010-06-111-12/+84
| | | | | We always call this function with user's account RDN while samr_LookupNames() searches for samAccountName.
* s4/test: remove duplicated commentKamen Mazdrashki2010-06-111-3/+0
|
* s3:misc make use of server_[event/messaging]_context directlyAndreas Schneider2010-06-105-15/+16
| | | | | Untangle these functions from smbd specific dependencies so they can be freely used in multiple servers.
* s3:winbindd use common server context functionsSimo Sorce2010-06-105-55/+3
|
* s3:lib make server contexts genericSimo Sorce2010-06-106-30/+80
| | | | Pair-programmed-with: Andreas Schneider <asn@samba.org>
* Fix the build in the non WITH_AIO case (sorry).Jeremy Allison2010-06-101-0/+20
|
* s3: readd h_errno struct member but rename itBjörn Jacke2010-06-101-2/+2
| | | | | as pointed out by metze this is a structure of fixed size, which should not be changed.
* Since idtree assigns sequentially, it rarely reaches high numbers.Rusty Russell2010-06-101-3/+5
| | | | | | | | | But such numbers can be forced with idr_get_new_above(), and that reveals two bugs: 1) Crash in sub_remove() caused by pa array being too short. 2) Shift by more than 32 in _idr_find(), which is undefined, causing the "outside the current tree" optimization to misfire and return NULL.
* Implement AIO in SMB2. Doesn't allow cancel calls yet (to be added).Jeremy Allison2010-06-105-0/+351
| | | | Jeremy.
* Ensure we correctly setup req->subreq before testing for async. Stops ↵Jeremy Allison2010-06-101-4/+4
| | | | | | | | crashes when XX_send functions set async to stop interim replies being sent. Jeremy.
* Don't use the autofree context for the globals. This causes child smbd's forkedJeremy Allison2010-06-103-3/+19
| | | | | | | by modules to crash due to destructors being called (found when using the vfs_aio_fork module with smb2). Jeremy.
* s3:cleaunp reformatting for readabilitySimo Sorce2010-06-101-85/+160
|
* s3:cleanup remove trailing spacesSimo Sorce2010-06-101-11/+11
|
* s3: fix build on HP-UXBjörn Jacke2010-06-101-1/+6
| | | | | | | this struct member h_errno is not used in the HP-UX code paths, it was just there because Solaris has it, too. As h_errno is a function call macro on HP-UX when thread support is enabled we run into trouble here. Just commenting it out should be okay as we don't use it anyway.
* s4:ldap.py - add testcase which demonstrates the reset of the "primaryGroupID"Matthias Dieter Wallnöfer2010-06-101-0/+7
|
* s4:samldb LDB module - fix up the case when the old and new "primaryGroupID" ↵Matthias Dieter Wallnöfer2010-06-101-7/+7
| | | | are the same
* s4:samldb LDB module - don't create multiple "ac" module contexts on modify ↵Matthias Dieter Wallnöfer2010-06-101-12/+6
| | | | | | | operations Since we do now run sequentially through all checks we don't need multiple "ac" contexts anymore.
* s4:dcesrv_samr_Add/DeleteAliasMember - provide better NTSTATUS return codes ↵Matthias Dieter Wallnöfer2010-06-101-6/+19
| | | | when something didn't work
* s4:dcesrv_samr_GetAliasMembership - fix type of counter variablesMatthias Dieter Wallnöfer2010-06-101-1/+2
|
* s4:dcesrv_samr_DeleteAliasMember - add more braces to fit better the coding ↵Matthias Dieter Wallnöfer2010-06-101-4/+6
| | | | styles
* s4:dcesrv_samr_AddAliasMembership - Merge the two error blocks into oneMatthias Dieter Wallnöfer2010-06-101-6/+3
|
* s4:dcesrv_samr_Add/DelGroupMember - remove the account type checkMatthias Dieter Wallnöfer2010-06-101-11/+10
| | | | MS-SAMR 3.1.5.8 speaks from accounts which are not necessarely only users.
* s4:dcesrv_samr_AddGroupMember - also the error code ↵Matthias Dieter Wallnöfer2010-06-101-0/+1
| | | | | | "LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS" is allowed This is returned when the group is the primary group of the specified entry.
* s4:samba_dsdb LDB module - move the "objectclass_attrs" module backMatthias Dieter Wallnöfer2010-06-101-1/+1
| | | | I think it should be lower in order to control also the "instanceType" module.
* s4:ldap.py - add a test to demonstrate the 'instanceType' behaviourMatthias Dieter Wallnöfer2010-06-101-0/+39
|
* s4:instancetype LDB module - prevent all types of "instanceType" manipulationMatthias Dieter Wallnöfer2010-06-101-0/+16
| | | | Also on Windows Server you aren't able to change it.
* s3: Fix EnumDomainAliases when no aliases are in LDAPVolker Lendecke2010-06-101-6/+4
| | | | | | | We used to return NT_STATUS_ACCESS_DENIED, now we just return 0 entries, just like W2k8 does. usrmgr.exe was pretty unhappy with the NT_STATUS_ACCESS_DENIED
* s3:pdb_ldap: fix bug 7505 - init_sam_from_ldap stores group in sid2uid cacheMichael Adam2010-06-101-1/+1
|
* s3: Add a dummy test to prove the maxfd calculationVolker Lendecke2010-06-101-0/+43
| | | | | To be run in a debugger, there's no way to inspect the internal tevent_select.c maxfd calculation
* tevent: Fix maxfd calculation in tevent_selectVolker Lendecke2010-06-101-1/+2
| | | | | | | | | | | | | | | | | | | | When doing fd1 = tevent_add_fd(ev, ev, 2, 0, NULL, NULL); fd2 = tevent_add_fd(ev, ev, 3, 0, NULL, NULL); TALLOC_FREE(fd2); fd2 = tevent_add_fd(ev, ev, 1, 0, NULL, NULL); we end up with select_ev->maxfd==1. This is wrong. An alternative fix might be to make select_ev->maxfd an unsigned int and make EVENT_INVALID_MAXFD==UINT_MAX. But in theory we might end up with an fd of UINT_MAX. std_event_add_fd() contains exactly the same piece of code, so I'm directly pushing it. Volker
* s3-smbd: Fix typo in comment.Karolin Seeger2010-06-101-1/+1
| | | | Karolin
* s3-passdb: Fix typo in comment.Karolin Seeger2010-06-101-1/+1
| | | | Karolin
* Rename "allow_smb2" -> "using_smb2" and make the usage clearer.Jeremy Allison2010-06-099-24/+33
|
* Split out the "finished write processing" code into a function so it can be ↵Jeremy Allison2010-06-091-40/+62
| | | | | | | | called by both sync and async code. Jeremy.
* Ensure we don't send SMB1 keepalives on an SMB2 connection.Jeremy Allison2010-06-091-0/+6
| | | | Jeremy.
* Split out the "finished read processing" code into a function so it can be ↵Jeremy Allison2010-06-091-36/+75
| | | | | | | | called by both sync and async code. Jeremy.
* s3-winbind: Fixed setting default sequence number.Andreas Schneider2010-06-091-1/+1
|
* s3: fix calculation of st_blocks in streams_xattrBjörn Jacke2010-06-091-3/+3
| | | | Thanks to Joachim Schmitz for finding that miscalculation.
* s3: fix calculation of st_blocks in init_stat_ex_from_statBjörn Jacke2010-06-091-1/+1
| | | | | | | this is just relevant for the very rare systems that don't have the st_blocks struct member. This is a fixup of the fix for bug 7474. Thanks to Joachim Schmitz for spotting this!
* Added guids for the validated writes.Nadezhda Ivanova2010-06-091-0/+7
|
* s3: Fix bug 7253Volker Lendecke2010-06-091-1/+8
| | | | | | | | | acct_ctrl is 32 bit in LOGIN_CACHE, but "w" as a format specifier for tdb_unpack only writes 16 bits. Okay on x86, not okay on Solaris. Thanks to Vladimir.Marek@Sun.COM! Volker
* Fix a valgrind error found by SMB2-COMPOUND test.Jeremy Allison2010-06-083-0/+31
| | | | | | | | If a file is closed we must also NULL out all chained_fsp pointers when the fsp is freed to prevent invalid pointer access. Jeremy.
* Second part of fix for 7501 - SMB2: CREATE request replies getting mangled.Jeremy Allison2010-06-081-67/+67
| | | | | | | | | Based on code from Ira Cooper <samba@ira.wakeful.net>, and also advice on refactoring the patch into a function call. outbuf vectors can be reallocated by smb2 processing code, so when returning interim responses we must not make assumptions about vector size. Jeremy
* Fix for bug 7501 - SMB2: CREATE request replies getting mangled.Ira Cooper2010-06-081-3/+1
| | | | | Code for dup_smb2_req() was duplicating the wrong vector (i, instead of i+2) when returning a non-minimal SMB2 response.
* s3-selftest: disable domain creds smbclient_s3 tests for now.Günther Deschner2010-06-081-2/+2
| | | | | | | | | | | Not sure they were ever working before. With this patch, make selftest is down to 4 failures from 259 tests. (two times LOCK9 from s3 smbtorture, one spoolss notify test and samba3.posix_s3.unix.info2). Guenther
* s3-netdomjoin-gui: Fix Bug #7500. Fix 'not a string literal' warning in ↵Günther Deschner2010-06-081-1/+1
| | | | | | | | | | netdomjoin-gui. Patch from Buchan Milne <bgmilne@mandriva.org>. Thanks! Guenther
* Revert "s3:smbd Fix segfault if register_existing_vuid() fails"Volker Lendecke2010-06-081-12/+4
| | | | This reverts commit 8f1cec5faf4e26de8b9797777059e99f2a66558b.
* Revert "s3:smbd Give the kerberos session key a parent"Volker Lendecke2010-06-081-2/+0
| | | | This reverts commit 4a7f45b7e1cef13bc28d7ee50dd4b5519bdec397.
* Revert "s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS"Volker Lendecke2010-06-085-18/+13
| | | | | | | | This reverts commit edba46ce94c335411ab337eeb4ef6f88fb3aae80. Conflicts: source3/auth/auth_ntlmssp.c
* s3-waf: fix the the waf build.Günther Deschner2010-06-081-2/+3
| | | | Guenther