summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* More of the fix for bug #7118 - nmbd problems with socket address.Jeremy Allison2010-02-101-0/+89
| | | | | | | | | | | | | | | | | | | | | Add a simple "processed packet queue" cache to stop nmbd responding to packets received on the broadcast and non-broadcast socket (which it has opened when "nmbd bind explicit broadcast = yes"). This is a very simple packet queue - it only keeps the packets processed during a single call to listen_for_packets() (i.e. one select call). This means that if the delivery notification for a packet received on both broadcast and non-broadcast addresses is done in two different select calls, the packet will still be processed twice. This is a very rare occurrance and we can just live with it when it does as the protocol is stateless. If this is ever flagged as a repeatable problem then we can add a longer lived cache, using timeout processing to clear etc. etc. But without storing all packets processed we can never be *sure* we've eliminated the race condition so I'm going to go with this simple solution until someone proves a more complex one is needed :-). Jeremy.
* Change the default of "nmbd bind explicit broadcast" to "no"Jeremy Allison2010-02-102-6/+5
| | | | | | until the double processing problem in bug #7118 is fixed. Jeremy.
* testprogs: add more error codes for spoolss test.Günther Deschner2010-02-101-0/+2
| | | | Guenther
* s3: change ldap filter to what really was intendedBjörn Jacke2010-02-101-1/+1
|
* tdb: fix recovery reuse after crashRusty Russell2010-02-101-4/+10
| | | | | | | | | | | | | | | If a process (or the machine) dies after just after writing the recovery head (pointing at the end of file), the recovery record will filled with 0x42. This will not invoke a recovery on open, since rec.magic != TDB_RECOVERY_MAGIC. Unfortunately, the first transaction commit will happily reuse that area: tdb_recovery_allocate() doesn't check the magic. The recovery record has length 0x42424242, and it writes that back into the now-valid-looking transaction header) for the next comer (which happens to be tdb_wipe_all in my tests). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb: give a name to the invalid recovery area constant (0)Rusty Russell2010-02-103-4/+5
| | | | Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
* s4:provision Just 'do the right thing' with empty smb.conf filesAndrew Bartlett2010-02-102-2/+26
| | | | | | | | For some reason, JHT keeps on creating an empty smb.conf file, expecting it to be the same as a non-existant one. It is easier to just realise what he meant. Andrew Bartlett
* s4-smbtorture: use test_GetPrinter_level in RPC-SPOOLSS-NOTIFY.Günther Deschner2010-02-102-45/+27
| | | | Guenther
* Fix bug #7122 - Reading a large browselist fails (server returns invalid ↵Jeremy Allison2010-02-092-3/+6
| | | | | | | | | | | | | | values in subsequent SMBtrans replies) There are two problems: 1). The server is off-by-one in the end of buffer space test. 2). The server returns 0 in the totaldata (smb_vwv1) and totalparams (smb_vwv0) fields in the second and subsequent SMBtrans replies. This patch fixes both. Jeremy.
* Missed one check on the memcpy for bug #7063.Jeremy Allison2010-02-091-1/+1
| | | | Jeremy.
* Second part of fix for bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core ↵Jeremy Allison2010-02-091-1/+4
| | | | | | | | | | dumps. Ensure we have no naked memcpy calls. This isn't a crash bug (it's already checked in the data_blob_talloc_zero() above, but I want to get into the pattern of having all memcpy's covered by safety checks. Jeremy.
* Fix off-by-one error in working out the limit of the NetServerEnum comment.Jeremy Allison2010-02-091-1/+1
| | | | Jeremy.
* s3:smbd: use StrCaseCmp() instead of strcasecmpStefan Metzmacher2010-02-091-4/+3
| | | | metze
* s3:smbd: Fix really ugly bool vs. int bug!!!Stefan Metzmacher2010-02-091-2/+2
| | | | | | | | A comparison function for qsort needs to return an 'int'! Otherwise you'll get random results depending on the compiler and the architecture... metze
* check_python.m4 - Raise the minimum python version up to 2.4Matthias Dieter Wallnöfer2010-02-091-0/+5
| | | | | | | | This is needed since we at the s4 side have some code which requires this. I think everybody should be fine since we got no complaints on the mailing list about this change. Patch template: Jelmer Vernooij <jelmer@samba.org>
* pidl - Remove "Py_RETURN_NONE" compatibility codeMatthias Dieter Wallnöfer2010-02-091-4/+0
| | | | This was needed only by Python 2.3 which we no longer support.
* s4:Remove "Py_RETURN_NONE" compatibility codeMatthias Dieter Wallnöfer2010-02-0911-44/+0
| | | | This was needed only by Python 2.3 which we no longer support.
* s3-docs: Fix make manpages3.Karolin Seeger2010-02-091-1/+1
| | | | Karolin
* s3-docs: Add missing para end tag.Karolin Seeger2010-02-091-0/+1
| | | | | Karolin (cherry picked from commit b78de63ef3cde53e3aabbe46654aac5a335f16a8)
* testprogs: regenerate printlib prototypes for spoolss test.Günther Deschner2010-02-091-27/+39
| | | | Guenther
* testprogs: print job info levels in EnumJobs() spoolss tests.Günther Deschner2010-02-092-0/+101
| | | | Guenther
* testprogs: print datatypes info levels in EnumPrintProcessorDatatypes() ↵Günther Deschner2010-02-092-0/+42
| | | | | | spoolss tests. Guenther
* testprogs: print printprocessor info levels in EnumPrintProcessors() spoolss ↵Günther Deschner2010-02-092-0/+35
| | | | | | tests. Guenther
* testprogs: print monitor info levels in EnumMonitors() spoolss tests.Günther Deschner2010-02-092-0/+45
| | | | Guenther
* testprogs: print port info levels in EnumPorts() spoolss tests.Günther Deschner2010-02-092-0/+79
| | | | Guenther
* testprogs: print form info levels in EnumForms(),GetForm() spoolss tests.Günther Deschner2010-02-092-0/+67
| | | | Guenther
* s3:selftest: make selftest requires bash for nowStefan Metzmacher2010-02-091-1/+1
| | | | | | So force bash until we removed the dependency to bash. metze
* s3:passdb: only use gid_to_sid() result if the result is a group of our ↵Stefan Metzmacher2010-02-091-4/+16
| | | | | | | | local sam Otherwise retry with pdb_gid_to_sid(). metze
* s3: fix some wrong newlines in de translation stringsBjörn Jacke2010-02-091-8/+8
|
* vfs_catia: fix return type warningsBjörn Jacke2010-02-091-2/+2
|
* s4-torture: allow host-only in unc lists in smbtortureAndrew Tridgell2010-02-092-4/+7
| | | | | | | | | | Allow UNC lists like this: 192.168.2.1 192.168.2.2 192.168.2.3 the share name will be taken from the command line
* Make "nmbd bind explicit broadcast" on by default.Jeremy Allison2010-02-083-6/+12
| | | | | | Fix a comment typo. Jeremy.
* Fix bug #6876 for acl_tdb module.Jeremy Allison2010-02-081-2/+1
| | | | | | | As pointed out by bj@sernet.de, the rmdir module initializer was duplicated. Fix this properly. Jeremy.
* s3:libsmb: fix NetServerEnum3 rap calls.Stefan Metzmacher2010-02-081-5/+19
| | | | metze
* s3:smbd: implement api_RNetServerEnum3Stefan Metzmacher2010-02-081-1/+212
| | | | | | This is needed to support large browse lists. metze
* s3:smbd: add/improve some DEBUG messages in api_RNetServerEnum2()Stefan Metzmacher2010-02-081-4/+6
| | | | metze
* s3:smbd: rename api_RNetServerEnum => api_RNetServerEnum2Stefan Metzmacher2010-02-081-3/+3
| | | | metze
* s3:docs-xml: document "nmbd bind explicit broadcast"Stefan Metzmacher2010-02-081-0/+16
| | | | metze
* s3:nmbd: change "nmbd:bind explicit broadcast" into "nmbd bind explicit ↵Stefan Metzmacher2010-02-083-1/+13
| | | | | | broadcast" metze
* s3:nmbd: also listen explicit on the subnet broadcast addressesStefan Metzmacher2010-02-086-115/+222
| | | | | | | | | And send replies always via the unicast address of the subnet. This behavior is off by default (as before) and can be enabled with "nmbd:bind explicit broadcast = yes". metze
* release-scripts: parametrize scriptsSimo Sorce2010-02-083-62/+84
| | | | | | | This should make it easier to keep all release scripts alined as it will reduce the difference between them to ideally a few variables Also moves the tdb script in the scripts directory.
* talloc: Fix abi checks in release scriptSimo Sorce2010-02-081-17/+24
| | | | | We must perform abi checks against the version we are going to release. Not against the current tree we are in.
* talloc: Fix abi checks and ifdefsSimo Sorce2010-02-083-4/+32
| | | | | teach the abi check scripts to skip the DOXYGEN sections fix the header to use #ifdef DOXYGEN and not #if DOXYGEN
* s4-smbtorture: skip over ValidatePassword if DCERPC error is returned.Günther Deschner2010-02-081-0/+4
| | | | Guenther
* s4:subtree_delete - "NULL" as format string isn't allowed on FreeBSDMatthias Dieter Wallnöfer2010-02-081-2/+3
| | | | | | | I changed the format string into "(objectClass=*)" which should be an equivalent expression for choosing all available objects. Consider bug 7115 for the issue.
* s3-net: fix net ads dns usage calls.Günther Deschner2010-02-081-3/+8
| | | | | | Bjoern, please check. Guenther
* s3:pdb_ldap: don't search for the users primary group, if we already know itStefan Metzmacher2010-02-081-31/+35
| | | | metze
* s3:pdb_ldap: optimize ldapsam_alias_memberships() and cache ldap searches.Stefan Metzmacher2010-02-082-7/+34
| | | | | | | | | ldapsam_alias_memberships() does the same LDAP search twice, triggered via add_aliases() from create_local_nt_token(). This happens when no domain aliases are used. metze
* s3:pdb_ldap: try to build the full unix_pw structure with ldapsam:trusted ↵Stefan Metzmacher2010-02-081-5/+85
| | | | | | | | support And also store the gid_to_sid mappings in the idmap_cache. metze
* s3:passdb: speed up pdb_get_group_sid()Stefan Metzmacher2010-02-081-5/+28
| | | | | | | | | | Use the cached version gid_to_sid() instead of pdb_gid_to_sid(). And also avoid the expensive lookup_sid() call for wellkown domain groups. metze
generated by cgit (git 2.34.1) at 2025-09-26 12:13:57 +0000