summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* r14395: Fix coverity bug #55. Ensure no unsigned/signed comparisons.Jeremy Allison2007-10-101-3/+3
| | | | | Jeremy. (This used to be commit cd3ad3f1a6f622b4bad5cb21b132de4cc476e03f)
* r14393: Fix a couple of AIX warnings.Jeremy Allison2007-10-102-1/+2
| | | | | Jeremy. (This used to be commit 8444c997bd3e18b1d04ebe85f06c8c6e34d7373f)
* r14392: Use KRB5_TGS_NAME.Günther Deschner2007-10-101-1/+1
| | | | | Guenther (This used to be commit 4cfd737cc1d8840888f80e360119eeb627acb381)
* r14387: Try and fix the coverity issues (#53, #54) with negativeJeremy Allison2007-10-106-12/+11
| | | | | | | sink by ensuring all uses of rpcstr_push are consistent with a size_t dest size arg. Jeremy. (This used to be commit f65d7afe1977d9d85046732842f9643716c15088)
* r14377: Fix coverity #4 for 3_0 tooSimo Sorce2007-10-101-1/+1
| | | | (This used to be commit aa26642ee19dcf7cfa3cb36032eadc823b01966b)
* r14368: Remove redundant set of logon flags (now in rpc_netlogon.h).Günther Deschner2007-10-101-2/+0
| | | | | Guenther (This used to be commit 8d4290cb8ed75cf12fa45bcf3e93cfe1a5567919)
* r14367: Not that I fully understand what's going on here, but the code as it ↵Volker Lendecke2007-10-101-4/+8
| | | | | | | | | | | | was here was clearly buggy as Coverity showed with bug id #36. According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship it in the request. Volker (This used to be commit 075e784491e6f2b491bd063db08ff1267f9cabbb)
* r14365: As solaris nss includes includes.h, make sure we useJeremy Allison2007-10-101-3/+3
| | | | | | the correct malloc-macros. Jeremy. (This used to be commit 412dc6f5dbc796126b94f3809fe660afac5d3c2a)
* r14359: Try and fix Coverity #176 by making the pointerJeremy Allison2007-10-101-7/+7
| | | | | | | aliasing clearer. This isn't a bug but a code clarification. Jeremy. (This used to be commit a3b8bee3ff8211d78f793877c877ccd2e15825dd)
* r14357: Try and fix Coverity #169 by making the pointerJeremy Allison2007-10-101-4/+6
| | | | | | | | | | aliasing clearer. This isn't a bug but a code clarification. Jeremy. line, and those below, will be ignored-- M source/smbd/posix_acls.c (This used to be commit b8397c9f33424e0d1ed3ff849e1c99812f978000)
* r14355: Try and fix Coverity #158 by making the pointerJeremy Allison2007-10-101-6/+8
| | | | | | | aliasing clearer. This isn't a bug but a code clarification. Jeremy. (This used to be commit 7ada96a1cfb1e928b7dfde101ca250b20024243f)
* r14353: Fix coverity bugs #61 and #62. Remember to divide byJeremy Allison2007-10-102-26/+21
| | | | | | the size of the data table. Clean up the struct a little. Jeremy. (This used to be commit 338538410d484a9358b60b05a86180275344ffa4)
* r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).Jeremy Allison2007-10-101-5/+12
| | | | | | Fix Coverity #59. Jeremy. (This used to be commit d793e1550cc8c79a2764609cddec082470d226e4)
* r14345: Fix Coverity #71. We don't currently propagate *any*Jeremy Allison2007-10-101-10/+15
| | | | | | | alloc error back up the stack from smbldap_set_mod() so ensure we abort correctly. Jeremy. (This used to be commit 9a1e35079af9404e1775e2a098990277b3771086)
* r14342: Fix coverity #68, resource leak on error path.Jeremy Allison2007-10-101-22/+54
| | | | | Jeremy. (This used to be commit 7520a8d2a10c72d330099c6502848afca60f56ff)
* r14340: Fix coverity #78, resource leak in error path.Jeremy Allison2007-10-101-12/+20
| | | | | Jeremy. (This used to be commit 76c4f2c4dc6fcd91a350985b16f4a6a321ac4bf6)
* r14338: Fix coverity #55 by explicit cast.Jeremy Allison2007-10-101-2/+5
| | | | | Jeremy. (This used to be commit 1fece52da4d667fa182aa9a87aaee3917860448b)
* r14336: Try and quieten coverity #53 and #54. Make it obviousJeremy Allison2007-10-101-2/+2
| | | | | | we're using -1 as a special size_t case by casting. Jeremy. (This used to be commit 415530bd082bf351f5e4c1fd32408f123ed77f85)
* r14333: Fix coverity #77, ensure we can't exit after allocation.Jeremy Allison2007-10-101-0/+4
| | | | | Jeremy. (This used to be commit 15d78ab1fc83249552476d99144389cfe42a786f)
* r14331: Add a comment on top of test_pam_modules about what we're testing.Lars Müller2007-10-101-0/+2
| | | | (This used to be commit 90eb092083383c2b606e21dc65fb036bb973b032)
* r14329: Fix the build on systems without libcom_err.Günther Deschner2007-10-101-2/+2
| | | | | Guenther (This used to be commit 44fcd3113be970edd01f7f076c4b6cad2d03ebcd)
* r14326: First catch of make test_pam_modules.Lars Müller2007-10-101-1/+1
| | | | | | | | | Testing pam_smbpass pam_winbind dlopen() of "./bin/pam_smbpass.so" succeeded. dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so: undefined symbol: secrets_fetch_domain_sid make: *** [test_pam_modules] Error 1 (This used to be commit 4b545e0ce665fe772095c27fe11ce535477f84ce)
* r14325: Add pam_modules rule which builds the configure(d) pam modules. This isLars Müller2007-10-103-4/+109
| | | | | | | | | | | | | | | | called as part of the all rule (again only if pam modules are requested by configure). Add pam_winbind rule. Ensure proto_exists before we build the pam modules. Add test_pam_modules rule to test if the built pam modules have any unresolved symbols. For test_pam_modules we use script/tests/dlopen.sh which was written by Nalin Dahyabhai <nalin@redhat.com>. Thanks Nalin! RedHat and SuSE use this script to test nss and pam modules since several years. (This used to be commit 71b2eb55adcd28f3796254ea1ce0bcee6098e712)
* r14321: When we have libnscd and winbindd comes (back) online, try to flush theGünther Deschner2007-10-104-1/+25
| | | | | | | nscd caches so that NSS-calls can deliver accurate information. Guenther (This used to be commit a32a423a0e9e0d4dd21282fd528bcd3247fddbd1)
* r14317: Use source/bin as dir to link pam_winbind instead of source/nsswitch/Lars Müller2007-10-109-11/+11
| | | | | | | | | | The intention is to have the resulting binaries at one place. This is also usefull for upcoming changes to provide a test_pammodules rule. With these changes I even got aware of testsuite/nsswitch/pam_winbind_syms.exp But this only covers pam_winbind. (This used to be commit 9883957b74ddefb5293e4aef0cc2f53ee4d417ac)
* r14303: Fix coverity #223. In a loop we were forgetting to freeJeremy Allison2007-10-101-1/+3
| | | | | | resources on error exit path. Jeremy. (This used to be commit f71aa3ab8fdfd08c1bec57b6506ead7c4af7299d)
* r14301: Fix coverity #224. In a loop we were forgetting to freeJeremy Allison2007-10-101-1/+3
| | | | | | resources on error exit path. Jeremy. (This used to be commit f1a5e5aefeeb78512c41cc8fc075b240696a3eb7)
* r14299: Fix coverity #225. In a loop we were forgetting to freeJeremy Allison2007-10-101-3/+6
| | | | | | resources on error exit path. Jeremy. (This used to be commit 1c0b4ed0acdb7fccb148d714796752fefc6dd78c)
* r14298: The other half of Coverity # 217Volker Lendecke2007-10-101-1/+1
| | | | (This used to be commit b9fb3fc0e3708b4721aaa1dcb7756d3774fb8db8)
* r14292: Janitor for tridge (samba3 talloc is almost identicalJeremy Allison2007-10-101-3/+19
| | | | | | | | | | to Samba4 talloc). Jeremy - make the snprintf call in talloc portable to older solaris boxes - fixed an error found sing the beam analyser (This used to be commit 1e1bae7afd9cd0051878ff1810c8ddfc28129233)
* r14289: Fix coverity #101, resource leak on error code path.Jeremy Allison2007-10-101-2/+6
| | | | | Jeremy. (This used to be commit d9e1d6fed099e7651807aa839a743fc7756ee326)
* r14286: Similar clarifiction fix for coverity #102.Jeremy Allison2007-10-101-8/+10
| | | | | Jeremy. (This used to be commit f458596b0edd958321c5d4061f034846348a3fe6)
* r14284: Fix coverity bug #103. Make code clearer - probablyJeremy Allison2007-10-101-5/+9
| | | | | | not a real issue but this code is easier to read. Jeremy. (This used to be commit 6621acc68f9a65540330d5c0d07db2488a3e8678)
* r14282: Change centry_string to only use talloc. ShouldJeremy Allison2007-10-101-16/+12
| | | | | | | quieten coverity bug #194 (which I think is a false positive). Jeremy. (This used to be commit 07d8b02d3dddf7322e096f3f0a7cc1c8fa709fa3)
* r14280: Fix Coverity #129 and 130: check before dereferencing a pointer. ThisJim McDonough2007-10-101-4/+4
| | | | | | was especially silly as we checked immediately _after_ dereferencing it :-/ (This used to be commit 7ebfe2cb26b72d7fac397cfe3ceb14f244388224)
* r14279: Fix coverity #86, 87, 88, 89:Jim McDonough2007-10-101-10/+27
| | | | | | Free grp_sid and owner_sid before returning. Also, only allow one group or owner. (This used to be commit 1043e0d90ccb3493417f7bf05b70bdf5513bb1a3)
* r14278: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to beJim McDonough2007-10-101-0/+8
| | | | | | specified once in an ACL, so it can be allocated a second time, overwriting the first (This used to be commit 1804a8a01ebf3353574a2c5b26a1746b34715737)
* r14275: Shut-up coverity false positive (bug #199) by making an assertionJeremy Allison2007-10-101-0/+7
| | | | | | explicit. Jeremy. (This used to be commit aeae20a8d9f3658acb8edd373eb601bdf7eab98b)
* r14273: Fix coverity bug #202. Memory leak on error path.Jeremy Allison2007-10-101-1/+3
| | | | | Jeremy. (This used to be commit d2be8163f2cf69681150ed7de720a37ffaa8e937)
* r14272: Fix Coverity # 81: free alloc'ed storage before returningJim McDonough2007-10-101-6/+7
| | | | (This used to be commit 1899d8ea283845141b24d91d230248009744fe1a)
* r14270: Fix coverity #203. Ensure we free on error exit.Jeremy Allison2007-10-101-2/+2
| | | | | Jeremy. (This used to be commit 9fa2e1bdedb61557b43f86c2898b7bf8762bbb63)
* r14268: Fix coverity error #204. Resource leak on error path.Jeremy Allison2007-10-101-0/+1
| | | | | Jeremy. (This used to be commit 5f74e56b865e0bdde0e574cd5f97cf29b06ad155)
* r14266: Fix coverity #205. Resource leak on error path.Jeremy Allison2007-10-101-0/+1
| | | | | Jeremy. (This used to be commit 23d69758bbff9687ab508e12931a5a49691d7e0d)
* r14264: Fix coverity #207. Resource leak on error path.Jeremy Allison2007-10-101-0/+1
| | | | | Jeremy. (This used to be commit 0429b6e8c34a99d4b2a9a4849075ef2a5acadf9e)
* r14261: Fix coverity #38. No null deref.Jeremy Allison2007-10-101-0/+6
| | | | | Jeremy. (This used to be commit 2a2b966b7b92ac340d61ba157d207a42509a93d1)
* r14259: Fix coverity #42. Ensure contact_domain can't be null derefedJeremy Allison2007-10-101-4/+6
| | | | | | in error code path. Jeremy. (This used to be commit 9f5fcdd8fb437882568e38e174e2df27bd077ba3)
* r14255: Revert r14204 which was horribly broken.James Peach2007-10-103-4/+57
| | | | (This used to be commit 950ed28f9f3f57dc449bd3bd6e7be7acb1e3d26d)
* r14252: Fix Coverity #72: free alloc'ed storage before return. Also found oneJim McDonough2007-10-101-1/+6
| | | | | more that coverity didn't find from asprintf. (This used to be commit 37b6e2c8de41754a5a1a3a6f798d57aa5d533ada)
* r14250: Fix coverity bug #107. Resource leak on error path.Jeremy Allison2007-10-101-1/+3
| | | | | Jeremy. (This used to be commit ca96c7be778d01594a540917acd3c5c218d6459c)
* r14249: We've dereferenced the_acl before, no point in checking.Volker Lendecke2007-10-101-1/+1
| | | | | | | Fix Coverity bug # 128. Volker (This used to be commit 84e9e73f3c71a0ccef76d56bc72dcd21160ed286)
generated by cgit (git 2.34.1) at 2025-09-26 16:39:48 +0000