summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* s3: Avoid a race with the async echo handlerVolker Lendecke2011-11-101-33/+28
| | | | | | We can not read from the echo handler socket when we have the main socket locked. This leads to the echo responder to lock up sitting in the fcntl lock while the parent wants to read the remainder of a large packet.
* libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)Stefan Metzmacher2011-11-101-10/+25
| | | | | | | | | | | | After a calling any wrapper of tevent_req_notify_callback(), e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(), a function has to return immediately otherwise it is very likely to crash, unless in calls tevent_req_defer_callback() before. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Nov 10 16:31:59 CET 2011 on sn-devel-104
* s4:finddcs_cldap: debug the correct server address instead of NULLStefan Metzmacher2011-11-101-1/+2
| | | | metze
* s3:smbd: don't limit the number of open dptrs for smb2 (bug #8592)Stefan Metzmacher2011-11-101-3/+12
| | | | | | | | | | This fixes a crash bug that is triggered, when a client has more than 256 directory handles with searches. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Nov 10 14:08:14 CET 2011 on sn-devel-104
* s3:smbd: fully construct the dptr before allocating a dnum in the bitmapStefan Metzmacher2011-11-101-27/+29
| | | | metze
* s3:smbd: avoid string_set() in dir.cStefan Metzmacher2011-11-101-2/+9
| | | | | | And do some more error checks. metze
* Fix -Wunused-but-set-variable compiler warnings in tevent_signal.cMartin Schwenke2011-11-101-4/+2
| | | | | | | | | | | | | | | | | | | | The results of some read(2) and write(2) calls are assigned into a variable that is never used. Presumably this used to avoid compiler warnings or similar. However, from (approximately) GCC 4.6 this produces some warnings: [ 609/3910] Compiling lib/tevent/tevent_signal.c ../lib/tevent/tevent_signal.c: In function ‘tevent_common_signal_handler’: ../lib/tevent/tevent_signal.c:85:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable] ../lib/tevent/tevent_signal.c: In function ‘signal_pipe_handler’: ../lib/tevent/tevent_signal.c:183:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable] The simplest thing to do is remove the variables and cast the function return to void. There is already a comment above each call. Signed-off-by: Martin Schwenke <martin@meltin.net> Signed-off-by: Stefan Metzmacher <metze@samba.org>
* s4: samba-tool time --help documentation improvementsTheresa Halloran2011-11-101-1/+14
| | | | | | | | | Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com> Signed-off-by: Andrew Tridgell <tridge@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Nov 10 06:04:22 CET 2011 on sn-devel-104
* s4: samba-tool group --help documentation improvementsTheresa Halloran2011-11-101-4/+75
| | | | | | Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com> Signed-off-by: Andrew Tridgell <tridge@samba.org>
* test: fixed several tests to use samba.testsAndrew Tridgell2011-11-107-12/+13
| | | | | | | this fixes error checking. Test failures were not being detected otherwise Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* samba-tool: print samaccountname in samba-tool user listAndrew Tridgell2011-11-101-6/+3
| | | | | | this is the attribute the admin needs for other commands Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* test: use planpythontestsuite() for ldb.python testAndrew Tridgell2011-11-101-2/+1
| | | | Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* test: added directory option to planpythontestsuite()Andrew Tridgell2011-11-101-5/+12
| | | | Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* test: added -D option to subunitrunAndrew Tridgell2011-11-101-0/+5
| | | | | | | | this allows for: subunitrun -D lib/ldb/tests/python api which makes this easier for developers
* pyldb: fixed ldb API testAndrew Tridgell2011-11-101-39/+36
| | | | it was failing previously, but the failure wasn't being noticed
* build: only run symbol checking if running all testsAndrew Tridgell2011-11-102-4/+11
| | | | | | this makes it much faster to run 1 test Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* pyldb: enhanced get() method on msg objectAndrew Tridgell2011-11-101-14/+33
| | | | | | | get() now takes a default value and an idx, allowing for much easier usage Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* samba-tool: Added new "user disable" commandGiampaolo Lauria2011-11-102-0/+43
|
* samba-tool: Added "user list" commandGiampaolo Lauria2011-11-101-0/+34
|
* samba-tool: Change internal argument name in domain machinepasswordGiampaolo Lauria2011-11-101-5/+5
|
* samba-tool: Fix domain machinepassword secret db searchGiampaolo Lauria2011-11-101-4/+2
| | | | | pair programmed with Jelmer Vernooij Add search to include secrets.ldb
* samba-tool: Fix domain machinepassword name searchGiampaolo Lauria2011-11-101-0/+2
| | | | | Append '$' to name provided by user to search for a machine account when necessary
* s4-test: improved error checking in samba-tool time testAndrew Tridgell2011-11-101-0/+2
| | | | Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* s4-socket: detect NULL server in socket connection codeAndrew Tridgell2011-11-101-0/+5
| | | | | | return NT_STATUS_NOT_FOUND instead of a segfault Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
* test: enable time and user samba-tool testsSean Dague2011-11-101-0/+4
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* test: add samba-tool user testsSean Dague2011-11-101-0/+215
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* test: Add samba-tool time testsSean Dague2011-11-101-0/+43
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* test: add directory and base class for samba-tool testsSean Dague2011-11-102-0/+124
| | | | | | this allows for more sophisticated testing of samba-tool Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s4-setup Remove servicePrincipalName: DNS/${DNSDOMAIN} from new installationsAndrew Bartlett2011-11-102-2/+0
| | | | | | | | | | | | | This servicePrincipalName is incorrect (windows does not use that servicePrincipalName, as it targets the server it is updating, not the root of the DNS tree), and now that we have multiple DNS backends that use the internal database, it is quite incorrect (as it cannot exist on more than one account). Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Thu Nov 10 01:11:46 CET 2011 on sn-devel-104
* s3-py_passdb Ensure that group mapping list input is initailisedAndrew Bartlett2011-11-091-1/+2
| | | | | | This may help to ensure we consistantly crash on an incorrect de-reference. Andrew Bartlett
* s3-passdb Initialise the correct level of pointer dereferenceAndrew Bartlett2011-11-091-1/+1
| | | | | | | | *pp_rmap may be NULL or un-initialised data. This was introduced by 995d1567265be178b4e45f79ea4562a7041ffa52. Andrew Bartlett
* s4:join.py - fix up "DsAddEntry" against Windows Server 2000Matthias Dieter Wallnöfer2011-11-091-9/+18
| | | | | | | | | | | It is important to consider the result level regarding error information. Windows 2000 seems to send us back v2, all other implementations v3. Consider post "Joining W2k AD domain" Reviewed-by: abartlet Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org> Autobuild-Date: Wed Nov 9 23:37:08 CET 2011 on sn-devel-104
* docs: Make clear to use the workgroup name not the realm.Andreas Schneider2011-11-091-0/+2
| | | | | Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Nov 9 21:17:09 CET 2011 on sn-devel-104
* s4: Install samba-tool and samba_kcc to bin/ rather than sbin/.Jelmer Vernooij2011-11-091-1/+2
| | | | | Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Wed Nov 9 19:43:07 CET 2011 on sn-devel-104
* samba_kcc: Remove unnecessary return statements.Jelmer Vernooij2011-11-071-17/+0
|
* util/time: Make some functions explicitly public.Jelmer Vernooij2011-11-031-3/+3
|
* util/time: Remove unnecessary _PUBLIC_ - that's implicit for things in ↵Jelmer Vernooij2011-11-031-44/+40
| | | | header files.
* s3:registry: prevent unnecessary transactions in regdb_initMichael Adam2011-11-091-0/+4
| | | | | | | | Skip the transaction for the upgrade code, if the database is already at code-level. Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Wed Nov 9 15:06:59 CET 2011 on sn-devel-104
* s3: Use autotools to set the winbind socket directory.Andreas Schneider2011-11-092-5/+38
| | | | | Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Nov 9 13:31:27 CET 2011 on sn-devel-104
* s3:smb2_server: grant credits in async interim responses (bug #8357)Stefan Metzmacher2011-11-091-1/+3
| | | | | | | | | | | The first fix for bug #8357 intruduced a regression, so that we no longer grant credits for real async interim responses with STATUS_PENDING. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Nov 9 11:56:29 CET 2011 on sn-devel-104
* s3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)Stefan Metzmacher2011-11-091-1/+1
| | | | | | | | | | | | Otherwise we may get unexpected results. This is a fix that was missing in commit 95595dd93fd04999fcf56ecaab7c29b064d021f8 (s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326)) metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Nov 9 10:13:32 CET 2011 on sn-devel-104
* s4-provision: Create ldap records for DNS partitions similar to windowsAmitay Isaacs2011-11-092-5/+3
| | | | | | | this allows easy comparison between windows and samba ldap trees Autobuild-User: Amitay Isaacs <amitay@samba.org> Autobuild-Date: Wed Nov 9 08:27:46 CET 2011 on sn-devel-104
* s4-provision: Set security descriptor for DNS recordsAmitay Isaacs2011-11-092-18/+103
|
* s4:torture:smb2: rewrite durable-open.open test to use smb2_*_create functionsMichael Adam2011-11-091-26/+7
| | | | | Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Wed Nov 9 02:36:36 CET 2011 on sn-devel-104
* s4:torture:smb2: rewrite the durable-open.lock test to use smb2_lease_create()Michael Adam2011-11-091-23/+3
|
* s4:torture:smb2: rewrite the durable-open.lease test to use smb2_lease_create()Michael Adam2011-11-091-29/+6
|
* s4:torture:smb2: rewrite the durable-open.oplock test to use ↵Michael Adam2011-11-091-19/+3
| | | | smb2_oplock_create()
* s4:torture:smb2: rewrite the durable-open.file-position test to use ↵Michael Adam2011-11-091-18/+2
| | | | smb2_oplock_create()
* s4:torture:smb2: rewrite the durable-open.open2 test to use ↵Michael Adam2011-11-091-26/+6
| | | | smb2_lease_create_share()
* s4:torture:smb2: rewrite the durable-open.open1 test to use ↵Michael Adam2011-11-091-21/+6
| | | | smb2_oplock_create_share()