summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* shadow_copy2: Fix some typosDavid Keegel2013-12-122-4/+4
| | | | | | | | Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Dec 12 17:58:24 CET 2013 on sn-devel-104
* libgpo/security_CSE: more preamble header checks of SecEdit/GptTmpl.inf files.Günther Deschner2013-12-121-1/+1
| | | | | | | | | | | | $CHICAGO$ needs to be double quoted. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Dec 12 15:31:14 CET 2013 on sn-devel-104
* libgpo/security_CSE: fix unicode preamble check of SecEdit/GptTmpl.inf files.Günther Deschner2013-12-121-2/+2
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: add gp_inifile_getbool().Günther Deschner2013-12-122-0/+25
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: fix segfault in gpo_process_gpo_list().Günther Deschner2013-12-121-6/+4
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: make sure we correctly can store the group policy state.Günther Deschner2013-12-121-3/+3
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: remove use of deprecated talloc functions.Günther Deschner2013-12-121-10/+15
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: remove unused libgpo wscript_build.Günther Deschner2013-12-121-8/+0
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: use existing connection to the ds for the sysvol queries.Günther Deschner2013-12-121-1/+2
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: remove unused loadparm_context from functions.Günther Deschner2013-12-125-19/+7
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* libgpo: remove duplicate parse_gpt_ini header.Günther Deschner2013-12-121-7/+0
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* tevent: version 0.9.20Stefan Metzmacher2013-12-122-1/+88
| | | | | | | | | | | | | | This adds the following new features: - tevent_queue_wait_send/recv() - tevent_num_signals() - tevent_sa_info_queue_count() Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Dec 12 00:39:35 CET 2013 on sn-devel-104
* tevent: give the user the chance to ask for TEVENT_NUM_SIGNALS and ↵Stefan Metzmacher2013-12-111-0/+10
| | | | | | | | | | | TEVENT_SA_INFO_QUEUE_COUNT This way the caller can change use the supported limits without using hardcoded values. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10214 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: change TEVENT_SA_INFO_QUEUE_COUNT from 64 to 256Stefan Metzmacher2013-12-111-1/+1
| | | | | | | | | | | There are some existing callers which assume the old SA_INFO_QUEUE_COUNT 100 value. 256 should give room for the future. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10214 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: tevent_epoll_set_panic_fallback() can be a void functionStefan Metzmacher2013-12-113-6/+3
| | | | | | | There's no case where this could return an error. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: make use of talloc_get_type_abort() in tevent_epoll.cStefan Metzmacher2013-12-111-15/+11
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: make use of talloc_get_type_abort() in tevent_signal.cStefan Metzmacher2013-12-111-6/+6
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: make use of talloc_get_type_abort() in tevent_select.cStefan Metzmacher2013-12-111-6/+8
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: make use of talloc_get_type_abort() in tevent_req.cStefan Metzmacher2013-12-111-4/+6
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: make use of talloc_get_type_abort() in tevent_queue.cStefan Metzmacher2013-12-111-2/+3
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: use talloc_get_type_abort() in the documentation examplesStefan Metzmacher2013-12-111-2/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: add tevent_queue_wait_send/recv()Gregor Beck2013-12-112-0/+85
| | | | | | | | | Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Gregor Beck <gbeck@sernet.de> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: tevent_req_create() already uses ZERO_STRUCT(req)Stefan Metzmacher2013-12-111-2/+0
| | | | | | | There's no need to zero individual members. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: let tevent_req_received() clear the private_cancel functionStefan Metzmacher2013-12-111-0/+1
| | | | | | | This makes sure it's not called when the private state is already gone. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tevent: cancel the timeout timer when the request is finishedStefan Metzmacher2013-12-111-0/+6
| | | | | | | | As we might defer the callback with tevent_req_defer_callback() when calling tevent_req_done(), we should cancel the timeout directly. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3/rpc_server: don't unmarshall PDUs twiceDavid Disseldorp2013-12-115-453/+28
| | | | | | | | | | | | | DCE/RPC PDUs are currently unmarshalled firstly by the generic librpc dcerpc_read_ncacn_packet_[send/recv] functions, and subsequently a second time by the source3 rpc_server, which ignores the unmarshalled packet and re-parses the receive buffer. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Dec 11 22:24:31 CET 2013 on sn-devel-104
* shadow_copy2: add a comment explaining why we don't talloc_zero_array().Michael Adam2013-12-111-0/+9
| | | | | | | | | | | Since I stumbled over this slighly sublte point, I thought it is worthwile to point it our in a comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Dec 11 19:55:20 CET 2013 on sn-devel-104
* shadow_copy2: revert expensive and unnecessary zero-initializationMichael Adam2013-12-111-1/+1
| | | | | | | | | | | | | | | I was being overly cautious. This is initialization is not necessary, since further down in the for-loop, the memory always gets fully initialized because the insert string is inserted at various slash positions. So this talloc_zero_array can be skipped: this an expensive thing to do in virtually every VFS call. This essentially reverts commit 249e9b4a34d8959bd94735c1921ecfc24d6a2705. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* lib:util: fix a comment typoMichael Adam2013-12-111-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3: use directory_create_or_exist_strict() to create corepathGregor Beck2013-12-111-16/+17
| | | | | | | | | This simplifies the code and even works in testenv where the chown call fails. Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* selftest: pass -l logdir to daemon processes.Gregor Beck2013-12-111-3/+7
| | | | | | | | | The daemons try to set up the corefile path within logdir before the config file was read. Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* selftest: use MALLOC_CHECK_=3 to give a diagnostic on failureGregor Beck2013-12-112-2/+2
| | | | | | | | | | With MALLOC_CHECK_ set to 2 in case of a failure abort() is called silently which hopefully creates a core dump. MALLOC_CHECK_=3 additionally gives an error message on stderr in case. Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* selftest: set valgrind optionsGregor Beck2013-12-111-1/+5
| | | | | | | | | In particular '--db-attach' interferes badly with the io redirection of the test environment and is superseded by the vgdb feature of valgrind. Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* selftest: setup {NMBD,WINBINDD,SMBD}_VALGRINDStefan Metzmacher2013-12-111-0/+3
| | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* selftest/Samba3: export ENVNAMEStefan Metzmacher2013-12-111-1/+9
| | | | | | | | This is used by selftest/in_screen. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* docs: Fix typos in vfs_shadow_copy2.8.xml.Karolin Seeger2013-12-101-2/+2
| | | | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Tue Dec 10 18:49:21 CET 2013 on sn-devel-104
* s3-lib: Fix %G substitution for domain users in smbdAndreas Schneider2013-12-101-1/+11
| | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=10286 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Tue Dec 10 16:39:43 CET 2013 on sn-devel-104
* s3:winbindd fix use of uninitialized variablesChristian Ambach2013-12-101-0/+13
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10280 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:lib/asys modify included headersChristian Ambach2013-12-101-4/+2
| | | | | | | use the headers from libreplace, not the system ones Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* smbd: Always use UCF_PREP_CREATEFILE for filename_convert calls to resolve a ↵Jeremy Allison2013-12-093-10/+5
| | | | | | | | | | | | path for open. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10297 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Dec 9 21:02:21 CET 2013 on sn-devel-104
* smbd: change flag name from UCF_CREATING_FILE to UCF_PREP_CREATEFILEJeremy Allison2013-12-095-10/+10
| | | | | | | | | In preparation to using it for all open calls. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10297 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* smbd: Fix regression for the dropbox case.Volker Lendecke2013-12-091-5/+5
| | | | | | | | | | We need to allow to save a file to a directory with perm -wx. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10297 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3-winbindd: Fix DEBUG statement in winbind_msg_offline().Jan Brummer2013-12-091-1/+1
| | | | | | | | | | | | Guenther BUG: https://bugzilla.samba.org/show_bug.cgi?id=10285 Reviewed-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Mon Dec 9 17:28:37 CET 2013 on sn-devel-104
* CVE-2013-4408:s3:Ensure LookupRids() replies arrays are range checked.Jeremy Allison2013-12-096-5/+62
| | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Karolin Seeger <kseeger@samba.org> Autobuild-Date(master): Mon Dec 9 09:00:41 CET 2013 on sn-devel-104
* CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.Jeremy Allison2013-12-0920-46/+359
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:Ensure LookupSids replies arrays are range checked.Jeremy Allison2013-12-098-7/+102
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:Ensure we always check call_id when validating an RPC reply.Jeremy Allison2013-12-091-8/+25
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* CVE-2013-4408:s3:ctdb_conn: add some length verification to ctdb_packet_more()Stefan Metzmacher2013-12-091-0/+5
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:libcli/util: add some size verification to ↵Stefan Metzmacher2013-12-091-0/+5
| | | | | | | | | tstream_read_pdu_blob_done() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:util_tsock: add some overflow detection to ↵Stefan Metzmacher2013-12-091-0/+5
| | | | | | | | | tstream_read_packet_done() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>