summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* talloc: fix compiler warnings with -Wc++-compatStefan Metzmacher2011-04-131-5/+5
| | | | | | | metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Apr 13 14:33:23 CEST 2011 on sn-devel-104
* s3: Fix Coverity ID 2470: STRAY_SEMICOLONVolker Lendecke2011-04-131-1/+1
| | | | | | | Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Apr 13 12:57:43 CEST 2011 on sn-devel-104
* s3: Use talloc_tos() in the S3 buildVolker Lendecke2011-04-131-1/+7
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Apr 13 09:30:55 CEST 2011 on sn-devel-104
* build: Bring DYNCONFIG into samba-util library to avoid symbol duplicationAndrew Bartlett2011-04-132-6/+6
| | | | | | | | | | When this was depended on directly as a subsystem, it ended up in multiple libraries. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Apr 13 08:39:35 CEST 2011 on sn-devel-104
* s3-build Remove distinct LOCALEDIR subsystemAndrew Bartlett2011-04-1310-28/+9
| | | | | | | This is no different to the rest of dynconfig, and so should be dealt with there. Andrew Bartlett
* s4-test: added a test for E_deshash()Andrew Tridgell2011-04-133-1/+72
| | | | | | | | | | this particularly checks the boundary conditions near passwords of length 14 characters Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Wed Apr 13 07:31:55 CEST 2011 on sn-devel-104
* s3-charcnv: Move convert_string() et al to lib/util/charsetAndrew Bartlett2011-04-135-447/+471
| | | | | | | | | This is the first step to this being the common convert_string implementation. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* libcli/auth Use convert_string_error to check LM hash calculation.Andrew Bartlett2011-04-131-9/+24
| | | | | | | | | | This allows us to know if the LM hash was built correctly or not. NOTE: talloc_tos() is not available in the common code at this time. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Add many more charset testsAndrew Bartlett2011-04-132-15/+446
| | | | | | | | | This confirms that the behaviour of the convert_string() API (with the process-wide iconv handle). Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Add convert_string_error()Andrew Bartlett2011-04-132-0/+25
| | | | | | | | This adds an interface that matches the source3/ convert string code. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Make ASCII conversion validate it's inputAndrew Bartlett2011-04-131-4/+69
| | | | | | | | | We should not just strip the high bits off unicode strings being converted to ASCII, we need to actually fail the conversion. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-selftest Add workaround for RAP test failureAndrew Bartlett2011-04-131-0/+2
| | | | | | | | | | | The rap.sam test reads 0xFFFFFFFF as a string in the level 2 r->HomeDir attribute, which once we start validating ASCII strings fails. This restores a unchecked dos charset for this test only, until it is determined if the client or server RAP code is at fault. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Rename convert_string test to allow a 'non_handle' testAndrew Bartlett2011-04-132-4/+3
| | | | | | | | | A future commit will test (with a subset of tests) the varient of this function without _handle. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Add more tests for convert_string_error_handle()Andrew Bartlett2011-04-131-0/+101
| | | | | | | | | This helps define the semantics of this function very clearly, particularly for partial and invalid inputs. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Preserve 'pull' errors even when converting via UTF16Andrew Bartlett2011-04-131-3/+8
| | | | | | | | | | | | | | When we do not have a direct iconv handle between any two charsets, we must go iva UTF16. However, we should still return the same buffer and error code as if we were able to go direct - including the partial conversion and the error code. This is important for locating the invalid multibyte character in the stream, for example. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Add tests for convert_string_error_handleAndrew Bartlett2011-04-131-1/+68
| | | | | | | | | These confirm that the errno is set correctly and that we stop on a partial multibyte character Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Add expected values for upper/lower case testsAndrew Bartlett2011-04-131-0/+16
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Fix and add public interface for convert_string_error_handleAndrew Bartlett2011-04-132-7/+14
| | | | | | | | | It makes much more sense for this to match the source3/ interface and return a bool. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s4/torture Fix calls to charcnv functions to always supply converted_sizeAndrew Bartlett2011-04-132-2/+3
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util: Make string_replace from s3 commonAndrew Bartlett2011-04-133-53/+43
| | | | | | | | | The s4 implementation didn't do multibyte strings, so was only good for '/' which is known to be safe in all multibyte charsets. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util ucs2_align is identical, put it in commonAndrew Bartlett2011-04-133-14/+7
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util Move simple string routines into common code.Andrew Bartlett2011-04-136-105/+84
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* lib/util/charset Move source3/lib/util_unistr.c to the common code.Andrew Bartlett2011-04-137-74/+73
| | | | | | | | This file (largely) contains functions to deal with UTF16 strings. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib Move strdup_w to it's only user in mangle_hash.cAndrew Bartlett2011-04-133-19/+19
| | | | | | Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib Move isvalid83_w to mangle_hash.cAndrew Bartlett2011-04-135-54/+34
| | | | | | | | | | | | This means that there is no need for the 'valid.dat' table to be loaded by anything other than smbd, so the unloader is also removed. The concept of a 'valid dos character' has been replaced by the hash2 mangle method. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib make static and remove more _w functionsAndrew Bartlett2011-04-132-16/+2
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib Remove unused #defineAndrew Bartlett2011-04-131-4/+0
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib Remove unused skip_unibuf()Andrew Bartlett2011-04-132-21/+0
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib: Remove unused _w functions.Andrew Bartlett2011-04-133-226/+1
| | | | | | | | | In general we don't manipulate UTF16 strings internally, particularly as they are also multibyte, so are no easier to work with than UTF8. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib Correct comment in strlen_w()Andrew Bartlett2011-04-131-1/+1
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib Remove more unused fstring.c functionsAndrew Bartlett2011-04-132-47/+0
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-charcnv: make pull_ucs2 staticAndrew Bartlett2011-04-132-2/+1
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* s3-lib: Remove unused pull_ucs2_fstring()Andrew Bartlett2011-04-132-5/+0
| | | | Signed-off-by: Andrew Tridgell <tridge@samba.org>
* build: use readelf as a replacement for lddAndrew Tridgell2011-04-131-33/+77
| | | | | | | | using readelf allows us to do a non-recursive library listing, which is important to remove false positive symbol duplication Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Wed Apr 13 04:37:33 CEST 2011 on sn-devel-104
* libds: Make flag_mapping a libraryAndrew Bartlett2011-04-131-3/+5
| | | | | | | This is a tiny library, but otherwise the functions end up in multiple other libraries. Andrew Bartlett
* lib/util make UTIL_TDB a libraryAndrew Bartlett2011-04-131-2/+3
|
* libcli/ldap pull LIBCLI_LDAP_MESSAGE and LIBCLI_LDAP_NDR into a libraryAndrew Bartlett2011-04-135-22/+14
| | | | | | This reduces symbol duplication Andrew Bartlett
* build: speed up SYMBOLCHECK codeAndrew Tridgell2011-04-131-6/+41
| | | | | | | this uses a nm and ldd cache to speed up the duplicate symbol checking code Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* s3: For net ads join, create a krb5.confVolker Lendecke2011-04-121-0/+5
| | | | | | | Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Apr 12 14:10:05 CEST 2011 on sn-devel-104
* s3: Initialize output in libnet_JoinVolker Lendecke2011-04-121-0/+2
| | | | Signed-off-by: Günther Deschner <gd@samba.org>
* s3: Retry the join with the short nameVolker Lendecke2011-04-121-0/+5
| | | | Signed-off-by: Günther Deschner <gd@samba.org>
* s3-util: separate out cmdline helpers.Günther Deschner2011-04-125-287/+314
| | | | | | | Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Apr 12 13:06:27 CEST 2011 on sn-devel-104
* s3: add some forward declarations.Günther Deschner2011-04-123-3/+6
| | | | Guenther
* s3-netapi: use dcerpc_try_samr_connects().Günther Deschner2011-04-121-4/+18
| | | | Guenther
* s3-netapi: use libnetapi_get_binding_handle().Günther Deschner2011-04-126-108/+54
| | | | Guenther
* s3-netapi: add libnetapi_get_binding_handle().Günther Deschner2011-04-122-0/+27
| | | | Guenther
* s3-librpc: let librpc/rpc/dcerpc.h include ndr and generated dcerpc headers.Günther Deschner2011-04-121-0/+2
| | | | Guenther
* s3-rpc_client: move rpc_cli_transport structs and protos to rpc_transport.hGünther Deschner2011-04-126-80/+111
| | | | Guenther
* s3/selftest Tear down the environment if we fail to connectAndrew Bartlett2011-04-121-12/+36
| | | | | | | | | | | This removes the exit(1) that previously didn't tear down the environment correctly, and instead just fails to set it up, allowing the rest of the script handle that with more grace. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Tue Apr 12 01:53:37 CEST 2011 on sn-devel-104
* s3-printing: Use become_user_by_session() function.Andreas Schneider2011-04-111-3/+3
| | | | | | | | | | We create a fake connection here and don't have an vuid. So work with the session_info directly here. Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Mon Apr 11 22:56:12 CEST 2011 on sn-devel-104