summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* selftest: remove samba3.rpc.spoolss.*printserver.openprinter_badnamelist ↵Michael Adam2012-04-251-1/+0
| | | | | | from flapping Signed-off-by: Andreas Schneider <asn@samba.org>
* selftest: mark the driver_info_winreg tests knownfail.Michael Adam2012-04-251-0/+2
| | | | | | They only get executed when driver files are around. Signed-off-by: Andreas Schneider <asn@samba.org>
* selftest: mark failing print_tests more specificallyMichael Adam2012-04-251-1/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* selftest: remove .*printer.*print_test_extended from flappingMichael Adam2012-04-251-1/+0
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* selftest: remove the "rpc.spoolss.printer" test from flappingMichael Adam2012-04-251-1/+0
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: replace call to reg_openkey() in reg_createkey() by accesscheck.Michael Adam2012-04-251-8/+10
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: remove a superfluous fill_subkey_cache() in reg_createkey()Michael Adam2012-04-251-5/+0
| | | | | | Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: use fill_subkey_cache to check exsistence in ↵Michael Adam2012-04-251-11/+2
| | | | | | | | regkey_open_onelevel(). Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: let fill_subkey_cache return WERR_BADFILE when the subkey list ↵Michael Adam2012-04-251-1/+1
| | | | | | | | | | could not be loaded WERR_NO_MORE_ITEMS seems inappropriate. Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: convert reg_openkey() to use talloc instead of SMB_STRDUP etcMichael Adam2012-04-251-15/+12
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry untangle an assignment from the check in regkey_open_onelevel()Michael Adam2012-04-251-1/+2
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: untangle assignment from check in regkey_open_onelevel()Michael Adam2012-04-251-1/+2
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: fix seqnum race in regdb_fetch_keys_internalMichael Adam2012-04-251-3/+22
| | | | | | | | | | | This prevents race between fetching seqnum and key content. Because there is currently no way to atomically fetch the record along with the seqnum, I use a loop. This is far from optimal and should should ideally be done differently. But for now it fixes the race. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: fix seqnum race in fetch_values_internalMichael Adam2012-04-251-3/+21
| | | | | | | | | | | This prevents race between fetching seqnum and key content. Because there is currently no way to atomically fetch the record along with the seqnum, I use a loop. This is far from optimal and should should ideally be done differently. But for now it fixes the race. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: update the seqnum in the subkey cache at the end of ↵Michael Adam2012-04-251-1/+5
| | | | | | | | | | | | | regval_store_keys The purpose is to prevent next reads from going to disk. Note that this will currently only be effective with local tdbs, not with ctdb: For tdb, store and delete bump the seqnum while transaction commit does not. For ctdb, transaction commit bumps the seqnum, while store and delete don't... This needs fixing (in ctdb). Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry:db: update the value container seqnum after storing/deleting to ↵Michael Adam2012-04-251-1/+22
| | | | | | | | | | | | prevent next read from going to disk if possible Note that this will currently only be effective in the local TDB implementation. For CTDB, this wont work since seqnum currently works differently there (needs fixing): For tdb, store and delete operations bump the db seqnum, while transaction commits don't. For ctdb, the seqnum is bumped by the transaction commit but not by store and delete operations. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: wrap reg_deletekey() into a transactionMichael Adam2012-04-251-2/+25
| | | | | | This is wrong layering but fixes a race condition. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: wrap reg_createkey() in a transactionMichael Adam2012-04-251-6/+30
| | | | | | | | | This is wrong layering (calling into regdb_transaction* in the reg_api code) but fixes a potential race. It makes the multi-step create procedure atomic. This should completely be done in the backend. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: untangle assignments from checks in reg_createkey()Michael Adam2012-04-251-2/+6
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: wrap reg_deletevalue() in a transactionMichael Adam2012-04-251-4/+30
| | | | | | | This is at the wrong layer, but if fixes a race potentially causing data corruption by concurrent access. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: untangle assignment from check in reg_deletevalue()Michael Adam2012-04-251-1/+2
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: fix race in reg_setvalue that could lead to data corruptionMichael Adam2012-04-251-6/+33
| | | | | | | | (there was no lock around fetching the values and storing them) The layering is wrong in that it uses regdb transactions in reg_api Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: untangle assignment from check and add a debugmessage in ↵Michael Adam2012-04-251-1/+3
| | | | | | reg_setvalue() Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: don't leak the old contents when updating the value cacheMichael Adam2012-04-251-0/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: fix debug message in regdb_store_values_internal()Michael Adam2012-04-251-1/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: improve log message in regdb_unpack_values()Michael Adam2012-04-251-1/+2
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: fix a debug message typoMichael Adam2012-04-251-1/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: add a new function regval_ctr_value_byname()Michael Adam2012-04-252-0/+20
| | | | | | | This is like regval_ctr_key_exists() but does not return bool, but the regval_blob instead, if found, and NULL if not found. Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: rename regval_ctr_key_exists() to regval_ctr_value_exists()Michael Adam2012-04-253-4/+4
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s4:torture:rpc:spoolss: also initialize driverName before checking it in ↵Michael Adam2012-04-251-0/+1
| | | | | | test_PrinterData_DsSpooler() Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry:reg_api: fix reg_queryvalue to not fail when values are modified ↵Michael Adam2012-04-251-1/+45
| | | | | | while it runs Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: make regdb_values_need_update() staticMichael Adam2012-04-252-2/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: make regdb_subkeys_need_update() staticMichael Adam2012-04-252-2/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: make regdb_store_values() staticMichael Adam2012-04-252-2/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: make regdb_fetch_values() staticMichael Adam2012-04-252-2/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: make regdb_fetch_keys() staticMichael Adam2012-04-252-2/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: make regdb_store_keys() staticMichael Adam2012-04-252-2/+1
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: printing backend: use regdb options via ops struct, not directlyMichael Adam2012-04-251-9/+10
| | | | | | | | just like the other backends. This is in preparation of making the backend functions private Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: remove usage of reg_objects from net_rpc_printer.cGregor Beck2012-04-251-131/+71
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: remove usage of reg_objects from cmd_spoolss.cGregor Beck2012-04-251-29/+14
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:eventlogadm make a transaction for addsourceGregor Beck2012-04-251-1/+14
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:eventlogadm reimplement addsource using reg_apiGregor Beck2012-04-251-95/+91
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3-waf: Cleanup smbregistry.Andreas Schneider2012-04-251-10/+4
|
* s3:registry: remove usage of reg_objects from srv_spoolss_nt.cGregor Beck2012-04-251-1/+0
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s3:registry: remove usage of reg_objects from libads/ldap_printer.cGregor Beck2012-04-251-89/+56
| | | | Signed-off-by: Andreas Schneider <asn@samba.org>
* s4-messaging: Use generate_random() to get a unique ID for messaging clientsAndrew Bartlett2012-04-251-1/+2
| | | | | | | | | | | | The call to random() resulted in duplicate values for s3fs configurations which, due to the forked child, all started with the same random seed. A future improvement would be to move to a proven unique value. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Apr 25 11:43:40 CEST 2012 on sn-devel-104
* s4-torture: enable raw.composite test again, and convert to new style testAndrew Bartlett2012-04-256-116/+141
| | | | | | This test has been skipped for some time, but is an important test for parallel operation. Andrew Bartlett
* lib/replace: split out GSSAPI from lib/replace/system/kerberos.h into ↵Alexander Bokovoy2012-04-2518-26/+75
| | | | | | | | | | | | | | lib/replace/system/gssapi.h With waf build include directories are defined by dependencies specified to subsystems. Without proper dependency <gssapi/gssapi.h> cannot be found for embedded Heimdal builds when there are no system-wide gssapi/gssapi.h available. Split out GSSAPI header includes in a separate replacement header and use that explicitly where needed. Autobuild-User: Alexander Bokovoy <ab@samba.org> Autobuild-Date: Wed Apr 25 00:18:33 CEST 2012 on sn-devel-104
* s3: Simplify check_reduced_name a bitVolker Lendecke2012-04-241-9/+5
| | | | | | | | It's pointless to do a talloc_asprintf with a SMB_STRDUP on the result. Use asprintf directly. Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Tue Apr 24 18:18:05 CEST 2012 on sn-devel-104
* s3: Fix a typoVolker Lendecke2012-04-241-1/+1
|