summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* tests: dnsserver: Add a update test with name set to '.'Amitay Isaacs2014-07-291-1/+40
| | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jul 29 19:33:19 CEST 2014 on sn-devel-104
* s4-rpc: dnsserver: Allow . to be specified for @ recordAmitay Isaacs2014-07-291-1/+3
| | | | | | | | | Windows allow both . and @ to be specified with modifying @ record. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10742 Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* selftest: Fix a typo (SIGTERm --> SIGTERM)Amitay Isaacs2014-07-291-1/+1
| | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Jul 29 17:09:00 CEST 2014 on sn-devel-104
* Fix now erroneous comment for directory_create_or_exist()Jeremy Allison2014-07-291-1/+1
| | | | | | | | | | It doesn't do any checking that the permissions are correct. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Jul 29 14:41:42 CEST 2014 on sn-devel-104
* ctdb-eventscripts: Remove unused argument to natgw_ensure_master()Martin Schwenke2014-07-291-3/+1
| | | | | | | | | | This was used to limit damage in the "recovered" event. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Tue Jul 29 10:03:16 CEST 2014 on sn-devel-104
* ctdb-tests: Add another LCP2 takeover testMartin Schwenke2014-07-291-0/+74
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-eventscripts: Remove NAT gateway "monitor" eventMartin Schwenke2014-07-295-10/+4
| | | | | | | | | | | | | | | | | | This event was introduced to handle misconfiguration. For example, where all nodes where configured as NAT gateway slaves. However, this event can fail when there are performance issues and capabilities can't be retrieved from a remote node. The problem is most likely with the remote node, so marking the local node UNHEALTHY is probably a mistake. Having a NAT gateway master node only matters in "ipreallocated", so leave it to do the checking. Given that a node will run "ipreallocated" as part of the first recovery, this should cause misconfigurations to be detected nice and early. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* messaging4: Simplify imessaging_pathVolker Lendecke2014-07-291-9/+4
| | | | | | | | | | Use server_id_str_buf Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Jul 29 00:30:55 CEST 2014 on sn-devel-104
* messaging3: messaging_array is no longer usedVolker Lendecke2014-07-281-5/+0
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: simplify unix_msg_sendVolker Lendecke2014-07-281-12/+5
| | | | | | | | We have a variable array inside one-fragment fast path anyway. Moving that to the toplevel of the function saves us a malloc/free pair. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Use struct initializersVolker Lendecke2014-07-281-32/+32
| | | | | | | Saves a few lines and bytes of .text Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* unix_msg: Use empty arrays in structsVolker Lendecke2014-07-281-3/+3
| | | | | | | Just a simple style update Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib: directory_create_or_exist() does not use "uid" parameterVolker Lendecke2014-07-2814-23/+19
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib: Simplify directory_create_or_exist with an early returnVolker Lendecke2014-07-281-23/+24
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbind/i18n: update Japanese pam winbind translationBjörn Jacke2014-07-261-117/+113
| | | | | | | | | | | | | Thanks to user "victory" and SATOH Fumiyasu for further fixes for Japanese KATAKANA words! BUG: https://bugzilla.samba.org/show_bug.cgi?id=10303 Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: SATOH Fumiyasu <fumiyas@osstech.jp> Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Sat Jul 26 20:43:28 CEST 2014 on sn-devel-104
* s3:idmap: fix talloc hierarchy in idmap_passdb_domain()Michael Adam2014-07-251-1/+1
| | | | | | | | | | (don't init to NULL context - we got one handed in...) Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Jul 25 14:18:20 CEST 2014 on sn-devel-104
* s3:idmap: only check the range values if a range setting has been found.Michael Adam2014-07-251-3/+1
| | | | | | | | Otherwise, the check is superfluous since high and low values are initialized to 0. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:idmap: move loading of idmap options together before range checking in ↵Michael Adam2014-07-251-4/+4
| | | | | | | idmap_init_domain() Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:idmap: in idmap_init_domain() load methods before loading further configMichael Adam2014-07-251-18/+23
| | | | | | | | Check whether the requested backend exists at all, before going further into the config parsing. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:idmap: don't log missing range config if range checking not requestedMichael Adam2014-07-251-2/+2
| | | | | | | | | | | | | | idmap_init_domain() is called with check_range == false from idmap_passdb_domain(). In this case, we usually don't have an idmap range at all, and we don't want to level 1 debug messages complaining about the fact are irritating at least. This patch removes the debug in the case of check_range == false. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10737 Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* messaging3: Remove an unnecessary variableVolker Lendecke2014-07-251-4/+1
| | | | | | | | | | We can inspect rec.buf with a debugger, no separate variable needed Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Jul 25 00:03:48 CEST 2014 on sn-devel-104
* messaging4: Simplify ping_message with server_id_str_buf()Volker Lendecke2014-07-241-3/+2
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* messaging3: Simplify ping_message()Volker Lendecke2014-07-241-10/+4
| | | | | | | | The talloc_strnup was only used to \0-terminate the data for printing. The same can be achieved by %.* in the printf format. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* messaging3: Remove two procid_str_static callsVolker Lendecke2014-07-241-3/+6
| | | | | | | ... and thus implicit talloc_tos() calls Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:smbd: remove unused client_get_tcp_info()Stefan Metzmacher2014-07-241-15/+0
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Jul 24 21:32:17 CEST 2014 on sn-devel-104
* s3:smbd: avoid using client_get_tcp_info()Stefan Metzmacher2014-07-241-25/+17
| | | | | | | | | We already have the required information as stack variable in the current function. There's no need to call get[peer|sock]name() twice. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* torture: Add FSCTL_QUERY_NETWORK_INTERFACE_INFO torture test case to ↵Anubhav Rakshit2014-07-241-0/+47
| | | | | | | | | source4/torture/smb2/ioctl.c Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* librpc: Add NETWORK_INTERFACE_INFO IDL data structureAnubhav Rakshit2014-07-243-1/+86
| | | | | | | | | | This is in preparation for adding NETWORK_INTERFACE_INFO Ioctl smbtorture test case. This data structure is described in MS-SMB2 Sec. 2.2.32.5 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* torture4: Use sizeof(char-array) instead of constantVolker Lendecke2014-07-241-12/+12
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4:torture/smb2: add smb2.session.bind1Stefan Metzmacher2014-07-241-0/+132
| | | | | | | This is a very simple multi-channel test Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s4:libcli/smb2: add smb2_session_channel()Stefan Metzmacher2014-07-242-10/+74
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s4:libcli/smb2: remove unused 'primary' argument of smb2_session_init()Stefan Metzmacher2014-07-243-8/+4
| | | | | | | This also gets rid of a talloc_reference() usage. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3: remove stat_ex.vfs_private completelyMichael Adam2014-07-243-23/+0
| | | | | | | | | | | It is not used any more. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Jul 24 14:23:11 CEST 2014 on sn-devel-104
* s3:vfs:gpfs: remove a block and reduce indentation in gpfs_is_offline()Michael Adam2014-07-241-8/+6
| | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org>
* s3:vfs:gpfs: remove all writing uses of stat_ex.vfs_private from vfs_gpfs.Michael Adam2014-07-241-7/+0
| | | | | | | | | | Now that the vfs_private cache is never read in vfs_gpfs, there is no need any more to write it. With this change, vfs_gpfs does not use vfs_private any more. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org>
* s3:vfs:gpfs: Remove all reading uses of stat_ex.vfs_private from vfs_gfs.Michael Adam2014-07-241-23/+22
| | | | | | | | | | | | | | | | | This was used as a cache for offline-info in the stat buffer. But as the implementation of gpfs_is_offline() showed, this cache does not always carry valid information when the stat itself is valid (since at least one call goes to fstatat() directly, circumventing the vfs). So the correct thing is to always call SMB_VFS_IS_OFFLINE() when checking whether a file is offline. For the pread and pwrite calls, we need to call IS_OFFLINE before the actual read and check afterwards if the file was offline before (as a basis whether to send notifications). Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org>
* Revert "s3:vfs:gpfs: log when winAttr-garbage is detected (by heuristics) in ↵Michael Adam2014-07-241-5/+0
| | | | | | | | | | | | | is_offline" This reverts commit 8f44883db94314c007c197927a9dd0809076754d. The next commits will be removing all access to stat_ex.vfs_private from vfs_gpfs. This revert of the last addition is a preparation. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org>
* selftest: check for fs specific options of the share dir only after creating itMichael Adam2014-07-231-2/+2
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Wed Jul 23 17:37:34 CEST 2014 on sn-devel-104
* ctdb:vacuum: stop vacuuming when the first delete_list traverse fails.Michael Adam2014-07-231-0/+1
| | | | | | | | | This indirect caller of delete_marshall_traverse was missed in fa4a81c86b6073b2563b090aa657d8e8b63c1276 which lets failure of the second travers fail the vacuum run. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-vacuum: Use existing function ctdb_marshall_finishAmitay Isaacs2014-07-232-11/+5
| | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Wed Jul 23 09:44:00 CEST 2014 on sn-devel-104
* ctdb-vacuum: Use ctdb_marshall_add to add a record to marshall bufferAmitay Isaacs2014-07-231-28/+10
| | | | | | | This avoids duplicate code and extra talloc in ctdb_marshall_record. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* ctdb-util: Refactor record marshalling routines to avoid extra tallocAmitay Isaacs2014-07-231-20/+13
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* ctdb-util: Refactor ctdb_marshall_recordAmitay Isaacs2014-07-231-14/+37
| | | | | | | Create new routines ctdb_marshall_record_size and ctdb_marshall_record_copy Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* ctdb-util: Fix nonempty line endingsAmitay Isaacs2014-07-231-3/+3
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* ctdb-vacuum: If talloc_realloc fails, terminate traverseAmitay Isaacs2014-07-231-1/+2
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* ctdb-vacuum: Fix talloc hierarchy in delete_marshall_traverseAmitay Isaacs2014-07-231-1/+1
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Volker Lendecke <vl@samba.org>
* smbd: Fix a typoVolker Lendecke2014-07-221-1/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jul 22 17:57:56 CEST 2014 on sn-devel-104
* smbd: ?True:False is pretty pointless :-)Volker Lendecke2014-07-221-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* smbd: Add missing {}Volker Lendecke2014-07-221-1/+2
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* smbd: Remove superfluous ()Volker Lendecke2014-07-221-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>