summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* tdb: always open internal databases with incompatible hash.Michael Adam2014-02-151-0/+5
| | | | | | | | | | | This makes them more efficient due to better distribution of keys across hash chains. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Feb 15 08:26:07 CET 2014 on sn-devel-104
* tdb: in tdb_delete_hash, make lock/unlock bracket more obviousMichael Adam2014-02-151-1/+1
| | | | | | | | | | by using the same variable as hash as in the lock. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Feb 15 03:21:07 CET 2014 on sn-devel-104
* tdb: simplify tdb_delete_hash() a bitMichael Adam2014-02-141-12/+5
| | | | | | | | | | | | | | | | | | | | Make the lock/unlock bracket more obvious by extracting locking (and finding) from the special cases to the top of the function. This also lets us take lock and find the record outside the special case branches (use dead records or not). There is a small semantic change implied: In the dead records case, the record to delete is looked up before the current dead records are potentially purged. Hence, if the record to delete is not found, the dead records are also not purge. This does not make a big difference though, because purging is only delayed until directly befor the next record to delete is in fact found. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tdb: tdbtool: dump record magic with fixed number of 8 hex digitsMichael Adam2014-02-141-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* tdb: tdbtool: dump record hash with fixed number of 8 hex digitsMichael Adam2014-02-141-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbindd: Use the right flags in dsgetdcnameVolker Lendecke2014-02-141-1/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Feb 14 21:59:22 CET 2014 on sn-devel-104
* regedit_valuelist.c: Coverity fix; Initialize a variable.Christopher R. Hertel (crh)2014-02-141-1/+1
| | | | | | | | | | | | | | The <tmp> variable is tested at the end of the function to determine the return value, but <tmp> is never initialized and there are conditions under which it may be tested before a value is set. This patch initializes <tmp> to NULL, which means that WERR_NOMEM will be returned if the registry lookups fail. CID: 1168007 Signed-off-by: Christopher R. Hertel (crh) <crh@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3:smb2_notify: fix use after free on long living notify requestsStefan Metzmacher2014-02-141-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a hack, but it should fix the bug: change_notify_add_request() talloc moves smb_request away, which is not expected by the smb2_notify.c code... smbd_smb2_notify_reply() uses tevent_req_defer_callback() (in older versions an immediate event) to defer the response. This is needed as change_notify_reply() will do more things after calling reply_fn() (smbd_smb2_notify_reply is this case) and often change_notify_remove_request() is called after change_notify_reply(). change_notify_remove_request() implicitly free's the smb_request that was passed to change_notify_add_request(). smbd_smb2_fake_smb_request() added the smb_request as smb2req->smb1req, which is expected to be available after smbd_smb2_notify_recv() returned. The long term solution would be the following interface: struct tevent_req *change_notify_request_send(TALLOC_CTX *mem_ctx, struct tevent_context *ev, struct files_struct *fsp, uint32_t max_length, uint32_t filter, bool recursive); NTSTATUS change_notify_request_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx, DATA_BLOB *buffer); Bug: https://bugzilla.samba.org/show_bug.cgi?id=10442 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Feb 14 11:18:15 CET 2014 on sn-devel-104
* ctdb:vacuum: move retrieval of freelist to after vacuum runMichael Adam2014-02-141-6/+7
| | | | | | | | | | The fast vacuum run may have increased the freelist size. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Fri Feb 14 03:15:30 CET 2014 on sn-devel-104
* ctdb:vacuum: fix debug message typo in add_record_to_delete_list()Michael Adam2014-02-141-1/+1
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* librpc/nbt: increase MAX_COMPONENTS limit for nbt_names.Günther Deschner2014-02-131-1/+1
| | | | | | | | | | | | | | domains with more then 10 subdomains are not so uncommon. https://bugzilla.samba.org/show_bug.cgi?id=10439 Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Thu Feb 13 16:30:50 CET 2014 on sn-devel-104
* s3-dsgetdcname: print IP address for LDAP ping.Günther Deschner2014-02-131-1/+3
| | | | | | | Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* librpc/rpc: finaly make struct dcerpc_binding privateStefan Metzmacher2014-02-132-13/+15
| | | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Thu Feb 13 13:55:47 CET 2014 on sn-devel-104
* s4:librpc/rpc: make dcerpc_pipe->binding constStefan Metzmacher2014-02-133-8/+14
| | | | | | | | This should not be changed after the connection is ready for requests. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: pass dcerpc_binding arround as 'const'Stefan Metzmacher2014-02-134-13/+13
| | | | | | | This should only be modified by the owner. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: only pass down dcecli_connection to the low level connect ↵Stefan Metzmacher2014-02-131-16/+16
| | | | | | | | | functions They don't need dcerpc_pipe. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: don't create a ncacn_np: bindingStefan Metzmacher2014-02-131-26/+0
| | | | | | | It's up to the caller to store the dcerpc_pipe->binding. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: use dcerpc_binding_get_string_option() for "host" and ↵Stefan Metzmacher2014-02-132-17/+17
| | | | | | | "target_hostname" Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: use dcerpc_binding_get_string_option("target_principal")Stefan Metzmacher2014-02-131-4/+8
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: make use of dcerpc_binding_get_string_option("endpoint")Stefan Metzmacher2014-02-133-21/+62
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/libnet: make use of dcerpc_binding_get_string_option("host")Stefan Metzmacher2014-02-134-7/+10
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: make use of dcerpc_binding_get_string_option("host")Stefan Metzmacher2014-02-132-2/+3
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/drs: make use of dcerpc_binding_get_string_option("host")Stefan Metzmacher2014-02-131-2/+5
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/drs: use make use of dcerpc_binding_get_string_option("host")Stefan Metzmacher2014-02-131-1/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/drs: make use of dcerpc_binding_set_flags()Stefan Metzmacher2014-02-132-2/+13
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: make use of dcerpc_binding_set_flags()Stefan Metzmacher2014-02-133-3/+11
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc/rpc: make use of dcerpc_binding_get_flags()Stefan Metzmacher2014-02-133-16/+31
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: use dcerpc_binding_set_abstract_syntax() in epmapper.cStefan Metzmacher2014-02-131-1/+3
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: make use of dcerpc_binding_set_abstract_syntax() in epmapper.cStefan Metzmacher2014-02-131-3/+4
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: make use of dcerpc_binding_set_flags()Stefan Metzmacher2014-02-135-19/+34
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: make use of dcerpc_binding_set_*() in torture_rpc_scanner()Stefan Metzmacher2014-02-131-1/+14
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: make use of dcerpc_binding_[g|s]et_transport()Stefan Metzmacher2014-02-134-22/+31
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture: use dcerpc_binding_get_string_option("host") in smbtorture.cStefan Metzmacher2014-02-131-2/+5
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:winbind: make use of dcerpc_binding_[g|s]et_flags()Stefan Metzmacher2014-02-131-9/+31
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:winbind: don't access dcerpc_binding internals in init_domain_binding()Stefan Metzmacher2014-02-131-7/+9
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:dsdb/repl: make use of dcerpc_binding_get_string_option("host")Stefan Metzmacher2014-02-131-4/+11
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:dsdb/repl: make dreplsrv_get_target_principal() staticStefan Metzmacher2014-02-131-5/+6
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:dsdb/repl: make use of dcerpc_binding_set_string_option("target_principal")Stefan Metzmacher2014-02-131-1/+9
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:rpc_server/remote: use dcerpc_binding_set_*() in remote_op_bind()Stefan Metzmacher2014-02-131-5/+16
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:rpc_server/remote: use ndr_table_by_syntax() in remote_op_bind()Stefan Metzmacher2014-02-131-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:rpc_server/epmapper: make use of dcerpc_binding_set_abstract_syntax() in ↵Stefan Metzmacher2014-02-131-1/+5
| | | | | | | build_ep_list() Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:rpc_server: make use of dcerpc_binding_get_transport()Stefan Metzmacher2014-02-135-14/+31
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:rpc_server: make use of dcerpc_binding_get_string_option("endpoint")Stefan Metzmacher2014-02-131-19/+48
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:rpc_server: use dcerpc_binding_get_*() in endpoints_match()Stefan Metzmacher2014-02-131-4/+16
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:lib/com/dcom: use dcerpc_parse_binding() to create the bindingStefan Metzmacher2014-02-131-20/+14
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: add const to libnet_JoinDomain->out.samr_bindingStefan Metzmacher2014-02-132-2/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: use helper functions to access dcerpc_binding->target_hostnameStefan Metzmacher2014-02-134-13/+10
| | | | | | | If possible also specify the already known address as dcerpc_binding->host. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: make use of dcerpc_binding_get_string_option("host")Stefan Metzmacher2014-02-132-2/+5
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: make use of dcerpc_binding_set_flags()Stefan Metzmacher2014-02-133-7/+24
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: make use of dcerpc_binding_[g|s]et_*() in libnet_join.cStefan Metzmacher2014-02-131-4/+29
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
generated by cgit (git 2.34.1) at 2025-10-01 15:42:07 +0000