summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Another attempt to fix bug #4308 - Excel save operation corrupts file ACLs.Jeremy Allison2009-01-221-25/+4
| | | | | | | | | | | | | | | | | | | | Simo is completely correct. We should be doing the chown *first*, and fail the ACL set if this fails. The long standing assumption I made when writing the initial POSIX ACL code was that Windows didn't control who could chown a file in the same was as POSIX. In POSIX only root can do this whereas I wasn't sure who could do this in Windows at the time (I didn't understand the privilege model). So the assumption was that setting the ACL was more important (early tests showed many failed ACL set's due to inability to chown). But now we have privileges in smbd, and we must always fail an ACL set when we can't chown first. The key that Simo noticed is that the CREATOR_OWNER bits in the ACL incoming are relative to the *new* owner, not the old one. This is why the old user owner disappears on ACL set - their access was set via the USER_OBJ in the creator POSIX ACL and when the ownership changes they lose their access. Patch is simple - just ensure we do the chown first before evaluating the incoming ACL re-read the owners. We already have code to do this it just wasn't rigorously being applied. Jeremy.
* Do not start a transaction this way.Simo Sorce2009-01-221-10/+0
| | | | | | | | | | | Because we still want to commit any changes that successfully apply we never want to do a global cancel, and because of how transaction nesting works that means we never cancel any "transaction" at the single modify operation level. Let each operation start its own transaction so that the transaction is properly canceled if any error is returned and half committed operations (though plugins failing) are properly reverted on a per operation basis.
* Fix a segfault: rpccli_* expect the reply_pdu to always be initializedVolker Lendecke2009-01-221-0/+5
|
* lib/replace: add defines to let the callers find out if pwrite and pread are ↵Stefan Metzmacher2009-01-221-0/+6
| | | | | | thread/fork safe metze
* s3:printing: make some functions static and use tevent functionsStefan Metzmacher2009-01-222-10/+12
| | | | metze
* s3:messages: finally make message_dispatch() staticStefan Metzmacher2009-01-222-2/+2
| | | | metze
* s3:printing: handle tevent_context events in the sys_select() callStefan Metzmacher2009-01-221-16/+42
| | | | metze
* s3:winbindd: we don't need to call message_dispatch() anymore it's event ↵Stefan Metzmacher2009-01-222-10/+0
| | | | | | triggered now metze
* s3:nmbd: we don't need to call message_dispatch() anymore it's event ↵Stefan Metzmacher2009-01-221-4/+0
| | | | | | triggered now metze
* s3:smbd: we don't need to call message_dispatch() anymore it's event ↵Stefan Metzmacher2009-01-222-26/+2
| | | | | | triggered now metze
* s3:msgtest: don't call message_dispatch() anymore, use tevent_loop_once() ↵Stefan Metzmacher2009-01-221-8/+19
| | | | | | instead metze
* s3:smbcontrol: don't call message_dispatch() anymore, it's triggered by ↵Stefan Metzmacher2009-01-221-13/+16
| | | | | | tevent_loop_once() metze
* s3:messaging: start with to use signal events instead of the raw signal ↵Stefan Metzmacher2009-01-221-37/+65
| | | | | | interfaces metze
* s3:smbd: restructure kernel oplocks codeStefan Metzmacher2009-01-228-146/+134
| | | | | | | | This converts the irix oplocks code to use a fd event and removes the last special case for file descriptors for the main sys_select(). metze
* s3: always call run_events() before and after sys_select()Stefan Metzmacher2009-01-225-28/+45
| | | | | | And always setup the fd events. metze
* s3:events: always run_events() before sys_select()Stefan Metzmacher2009-01-221-5/+4
| | | | | | We might have pending signal events not only timed events. metze
* Actually complete 3662c2b...Volker Lendecke2009-01-223-6/+5
|
* cli_get_pipe_name_from_iface does not need the cli_stateVolker Lendecke2009-01-222-4/+2
| | | | I leave the TALLOC_CTX in, we might have to allocate it in the future
* s3: run "make samba3-idl"Michael Adam2009-01-221-0/+2
| | | | Michael
* pidl/python: Add explicit casts, fixing implicit cast warnings.Michael Adam2009-01-221-1/+1
| | | | Michael
* run make idl_full, thus adding explicit casts to gen_ndr server codeMichael Adam2009-01-2214-505/+505
| | | | Michael
* pidl: reduce implicit cast warnings in gen_ndr server codeMichael Adam2009-01-221-1/+1
| | | | Michael
* Memory leaks and other fixes found by Coveritytodd stecher2009-01-2119-62/+136
|
* Fix path to check_python.m4.Jelmer Vernooij2009-01-211-1/+1
|
* libsmbconf: Remove use of some Samba3-specific macros.Jelmer Vernooij2009-01-214-9/+15
|
* libsmbconf: Add build magic for Samba 4.Jelmer Vernooij2009-01-212-0/+4
|
* Merge branch 'master' of ssh://git.samba.org/data/git/sambaJelmer Vernooij2009-01-2118-148/+234
|\
| * libsmbconf: move the non-registry parts of libsmbconf to top levelMichael Adam2009-01-217-2/+3
| | | | | | | | Michael
| * s3:libsmbconf: include smbconf headers with lib/smbconf prefixMichael Adam2009-01-212-4/+4
| | | | | | | | Michael
| * s3:libsmbconf: use talloc_free instead of TALLOC_FREE in reg backendMichael Adam2009-01-211-20/+20
| | | | | | | | Michael
| * s3:libsmbconf: use talloc_free instead of TALLOC_FREE in txt backendMichael Adam2009-01-211-5/+6
| | | | | | | | Michael
| * s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf_initMichael Adam2009-01-211-1/+1
| | | | | | | | Michael
| * s3:libsmbconf: use talloc_free instead of TALLOC_FREE in testsuiteMichael Adam2009-01-211-5/+5
| | | | | | | | Michael
| * s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf_util.cMichael Adam2009-01-211-2/+2
| | | | | | | | Michael
| * s3:libsmbconf: use talloc_free instead of TALLOC_FREE in smbconf.cMichael Adam2009-01-211-2/+2
| | | | | | | | Michael
| * s3:libsmbconf: remove the init headers from smbconf.hMichael Adam2009-01-216-19/+103
| | | | | | | | | | | | | | | | | | | | give the smbconf_init() dispatcher and the backends (smbconf_reg and smbconf_txt) a header of their own each. This allows to use the basic infrastructure and single backends individually. Michael
| * s3:libsmbconf: remove unused function smbconf_is_writeable_bystring()Michael Adam2009-01-212-27/+0
| | | | | | | | Michael
| * s3/vfs_extd_audit: Don't ignore "syslog = 0".Karolin Seeger2009-01-211-59/+86
| | | | | | | | | | | | | | | | This fixes bug #5956. Thanks to Oskar Wycislak <cantorek [at] gmail.com> for reporting and providing a patch! Karolin
| * Fix warning; base dn is no longer const.Jelmer Vernooij2009-01-211-2/+2
| |
| * Move check_python.m4 to common m4 directory.Jelmer Vernooij2009-01-213-2/+2
| |
* | pidl/python: Add explicit casts, fixes warnings about casts when enabled.Jelmer Vernooij2009-01-211-4/+4
|/
* expand-includes: Add simple protection against infinite recursion.Jelmer Vernooij2009-01-211-0/+5
|
* Automagically expand includes in Makefile.in during configure timeJelmer Vernooij2009-01-212-1/+42
| | | | when make is not GNU Make.
* Only check for Perl once in Samba 3.Jelmer Vernooij2009-01-213-12/+9
|
* Move check_make.m4 to the top-level.Jelmer Vernooij2009-01-213-2/+2
|
* Merge branch 'master' of ssh://git.samba.org/data/git/sambaJelmer Vernooij2009-01-215-10/+20
|\
| * build-docs: cleanup exit of the scriptMichael Adam2009-01-211-6/+14
| | | | | | | | | | | | exit in the directory where it was called using pushd/popd. Michael
| * s3:docs: clean build/catalog.xml in "make clean"Michael Adam2009-01-211-0/+1
| | | | | | | | Michael
| * s3:docs: clean generated .png images in "make clean"Michael Adam2009-01-211-1/+2
| | | | | | | | Michael
| * Use script path to find the setup directory.Jelmer Vernooij2009-01-213-3/+3
| |