summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* lib/util: Clean up includes for xfile.[ch]Martin Schwenke2014-10-042-1/+8
| | | | | | | | | | | | The include files added to xfile.h are already included unconditionally elsewhere (replace.h, samba_util.h, ...) so Samba can't be built without them. To minimise dependencies, only include specific util headers instead of samba_util.h. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Jeremy Allison <jra@samba.org>
* lib/util: Clean up includes for blocking.cMartin Schwenke2014-10-044-14/+36
| | | | | | | | Add blocking.h. Allows standalone compile without external includes.h. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Make WITH_PROFILE span more in smbprofile.hVolker Lendecke2014-10-031-2/+3
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Oct 3 22:17:46 CEST 2014 on sn-devel-104
* profiling: Remove a big DEBUG statementVolker Lendecke2014-10-031-25/+0
| | | | | | | | | | | | | | | | | | | | | I would like to have the freedom to play with the profiling implementation. This is kindof in the way. This code is from pre-SVN days: > commit 7914e9351abb5271ebb4990c3b1fe495d15a4eda > Author: Jeremy Allison <jra@samba.org> > AuthorDate: Thu Oct 5 18:50:18 2000 +0000 > Commit: Jeremy Allison <jra@samba.org> > CommitDate: Thu Oct 5 18:50:18 2000 +0000 > > Herb's fixes for profiling & compiler warnings. > Jeremy. Herb, please speak up quickly if you still need this :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Remove some #ifdefsVolker Lendecke2014-10-032-8/+0
| | | | | | | | | The DO_PROFILE_INC thingies already #define to nothing without WITH_PROFILE, and any sane compiler will just not compile the if-condition if there is no body to be executed. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Only compile profile/profile.c if profiling is enabledVolker Lendecke2014-10-033-19/+40
| | | | | | | | This conditional compile avoids some #ifdef WITH_PROFILE, which makes the code more readable Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Only compile utils/status_profile.c if profiling is enabledVolker Lendecke2014-10-033-24/+41
| | | | | | | | This conditional compile avoids some #ifdef WITH_PROFILE, which makes the code more readable Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Fix a typoVolker Lendecke2014-10-031-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Move some #defines to profile.cVolker Lendecke2014-10-032-4/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Fix a typoVolker Lendecke2014-10-031-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* profiling: Make "struct profile_header" staticVolker Lendecke2014-10-032-8/+7
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* winbind3: Fix pwent variable substitutionJustin Maggard2014-10-031-1/+1
| | | | | | | | | Commit 0ce46318 (winbind3: Simplify fillup_pw_field) broke variable substitution by copying from the wrong (unsubstituted) buffer. Fix it. Signed-off-by: Justin Maggard <jmaggard10@gmail.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <rsharpe@samba.org>
* Reduce the no-op build times by 30%Thomas Nagy2014-10-032-3/+148
| | | | | | | | | Change-Id: Ie68436c1e7c75c1786e9ed6b6a54d2b55abbbcea Reviewed-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Oct 3 13:25:18 CEST 2014 on sn-devel-104
* waf: add k5crypto to the list of system libraries if they are reported by ↵Matthieu Patou2014-10-031-0/+4
| | | | | | | | | | | | the krb5config but not found as requied by the different tests Otherwise on some systems we have error message like "Implied dependency k5crypto in winbind_krb5_locator is of type EMPTY" Even though krb5config indicated that this library is needed and the library is present Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Michael Adam <obnox@samba.org>
* librpc: simplify ndr_pull_dnsp_stringMatthieu Patou2014-10-031-5/+2
| | | | | | | total_len is 1 and never varies. Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Michael Adam <obnox@samba.org>
* Fix typo in samba-tool manpageАндрей Черепанов2014-10-031-1/+1
| | | | | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Oct 3 11:00:58 CEST 2014 on sn-devel-104
* s4:torture:basic: eliminate potential for false failures in ↵Michael Adam2014-10-031-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | delayed_write_update1c We want to test that the write did update the write time immediately. We check this by getting the file info in a loop for a few seconds. There are several result cases: - the server updated the write time immediately - success - the server updated the write time, but not immediately - failure - the server did not update the write time - failure The loop is only there to be able to discern between the two failure cases. The check for success is whether the first getinfo has reportet the updated write time. The potential for false failures was the additional timing check. So if the first fileinfo call just took too long (e.g. due to a busy system), this was reported as failure. This patch should eliminate interemittent autobuild failures. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: use assert in the second loop in delayed_write_update1bMichael Adam2014-10-031-11/+10
| | | | | | | We can hence replace the assert after the loop by a success torture_comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add check for size after initial write in ↵Michael Adam2014-10-031-0/+3
| | | | | | | delayed_write_update1c Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add update into past as error condition in ↵Michael Adam2014-10-031-3/+4
| | | | | | | delayed_write_update1c Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: make use of torture_assert macros in delayed_write_update1cMichael Adam2014-10-031-42/+23
| | | | | | | | This does not change the logic except for adding early returns in failure cases. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: whitespace cleanup in delayed_write_update1cMichael Adam2014-10-031-7/+7
| | | | | | | no diff with git diff -w Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: eliminate potential for false failures in ↵Michael Adam2014-10-031-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | delayed_write_update1b We want to test that the write did update the write time immediately. We check this by getting the file info in a loop for a few seconds. There are several result cases: - the server updated the write time immediately - success - the server updated the write time, but not immediately - failure - the server did not update the write time - failure The loop is only there to be able to discern between the two failure cases. The check for success is whether the first getinfo has reportet the updated write time. The potential for false failures was the additional timing check. So if the first fileinfo call just took too long (e.g. due to a busy system), this was reported as failure. This patch should eliminate interemittent autobuild failures. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: use assert in the second loop in delayed_write_update1bMichael Adam2014-10-031-11/+10
| | | | | | | We can hence replace the assert after the loop by a success torture_comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add check for size after initial write in ↵Michael Adam2014-10-031-0/+3
| | | | | | | delayed_write_update1b Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add update into past as error condition in ↵Michael Adam2014-10-031-3/+6
| | | | | | | delayed_write_update1b Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: make use of torture_assert macros in delayed_write_update1bMichael Adam2014-10-031-41/+24
| | | | | | | | This does not change the logic except for adding early returns in failure cases. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: whitespace cleanup in delayed_write_update1bMichael Adam2014-10-031-5/+5
| | | | | | | no diff with git diff -w Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: eliminate potential for false failures in ↵Michael Adam2014-10-031-19/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | delayed_write_update1a We want to test that the write did update the write time immediately. We check this by getting the file info in a loop for a few seconds. There are several result cases: - the server updated the write time immediately - success - the server updated the write time, but not immediately - failure - the server did not update the write time - failure The loop is only there to be able to discern between the two failure cases. The check for success is whether the first getinfo has reportet the updated write time. The potential for false failures was the additional timing check. So if the first fileinfo call just took too long (e.g. due to a busy system), this was reported as failure. This patch should eliminate interemittent autobuild failures. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: use assert in the second loop in delayed_write_update1aMichael Adam2014-10-031-11/+10
| | | | | | | We can hence replace the assert after the loop by a success torture_comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add check for size after initial write in ↵Michael Adam2014-10-031-0/+3
| | | | | | | delayed_write_update1a Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add update into past as error condition in ↵Michael Adam2014-10-031-3/+6
| | | | | | | delayed_write_update1a Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: make use of torture_assert macros in delayed_write_update1aMichael Adam2014-10-031-50/+27
| | | | | | | | | This does not change the logic except for adding early returns in failure cases. But it makes the code more compact and obvious. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: fix spacing in the delayed_write_update1a test.Michael Adam2014-10-031-6/+6
| | | | | | | No diff visible with git diff -w Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: eliminate potential for false failures in ↵Michael Adam2014-10-031-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | delayed_write_update1 We want to test that the write did update the write time immediately. We check this by getting the file info in a loop for a few seconds. There are several result cases: - the server updated the write time immediately - success - the server updated the write time, but not immediately - failure - the server did not update the write time - failure The loop is only there to be able to discern between the two failure cases. The check for success is whether the first getinfo has reportet the updated write time. The potential for false failures was the additional timing check. So if the first fileinfo call just took too long (e.g. due to a busy system), this was reported as failure. This patch should eliminate interemittent autobuild failures. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: use assert in the second loop in delayed_write_update1Michael Adam2014-10-031-11/+10
| | | | | | | We can hence replace the assert after the loop by a success torture_comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add check for size after initial write to ↵Michael Adam2014-10-031-0/+3
| | | | | | | delayed_write_update1 Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: add update into past as error condition in ↵Michael Adam2014-10-031-3/+6
| | | | | | | delayed_write_update1 Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: make use of torture_assert macros in delayed_write_update1Michael Adam2014-10-031-56/+28
| | | | | | | No logic change except for adding early returns. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: whitespace fix in delayed_write_update1Michael Adam2014-10-031-4/+4
| | | | | | | No diff with git diff -w Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: remove two unused variables from delayed_write_update3cMichael Adam2014-10-031-4/+2
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: use torture_assert macros in delayed_write_updateMichael Adam2014-10-031-31/+22
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:basic: whitespace cleanup in delayed_write_updateMichael Adam2014-10-031-5/+5
| | | | | | | git diff -w shows no diff Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* torture: add torture_assert_u64_not_equal()Michael Adam2014-10-031-0/+11
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* torture: add torture_assert_int_not_equalMichael Adam2014-10-031-0/+10
| | | | Signed-off-by: Michael Adam <obnox@samba.org>
* idl: declare frstrans_VersionVector public so that we can dump it to blob ↵Matthieu Patou2014-10-021-1/+1
| | | | | | | | | | | | and vice versa Change-Id: Ica8dbe899eb257603ce6f7b2ea224c6533bdea46 Reviewed-by: Matthieu Patou <mat@matws.net> Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Matthieu Patou <mat@samba.org> Autobuild-Date(master): Thu Oct 2 14:27:02 CEST 2014 on sn-devel-104
* idl: frstrans.idl add frstrans_RdcCloseMatthieu Patou2014-10-021-1/+3
| | | | | | | Change-Id: I32e88f542da7df21e253cfbf8c2b3cc17043c6c7 Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* idl: improve frsrpc by adding missing flag, fixing typo (W -> VV) and making ↵Matthieu Patou2014-10-021-2/+3
| | | | | | | | needed structure public Change-Id: Ia507b5f627464ab78a145e54b276fc8d64ee3c14 Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* idl: Add frs blobs for dumping of frs related blobs with ndrdumpMatthieu Patou2014-10-024-3/+45
| | | | | | Change-Id: I5f8375fee663e452c26f264d73f637beffb1f209 Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* idl: Add compression_guidMatthieu Patou2014-10-021-0/+3
| | | | | | Change-Id: I3cfe3c8f4a405fcf9a54092b03e87f00e7abd2fb Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
generated by cgit (git 2.34.1) at 2025-09-25 17:34:15 +0000